Skip to contentSkip to conversation

ASoC: DAPM - Use dev_warn for debugfs warning message.

PATCH Applied Liam Girdwood 3 participants 5 messages Mar 6, 2012 – Mar 7, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ASoC: DAPM - Use dev_warn for debugfs warning message.

Remove printk(KERN_WARNING) and use dev_warn() instead.

---
 sound/soc/soc-dapm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
sound/soc/soc-dapm.c +1 -1
index a4d4aa1..dcd1160 100644
@@ -1667,7 +1667,7 @@ void snd_soc_dapm_debugfs_init(struct snd_soc_dapm_context *dapm,
 	dapm->debugfs_dapm = debugfs_create_dir("dapm", parent);
 
 	if (!dapm->debugfs_dapm) {
-		printk(KERN_WARNING
+		dev_warn(dapm->dev,
 		       "Failed to create DAPM debugfs directory\n");
 		return;
 	}
Signature · 1 line
1.7.5.4
Applied
#1 lore raw
Quoted 1 line · Liam Girdwood

Remove printk(KERN_WARNING) and use dev_warn() instead.

Applied, thanks.

Everyone else seems to be doing ASoC: thing: rather than having a -. As far as I remember it was Peter that started it, though other people (including me) adopted it too.

#2 lore raw
Quoted 8 lines · Mark Brown
Quoted 1 line · Liam Girdwood

Remove printk(KERN_WARNING) and use dev_warn() instead.

Applied, thanks.

Everyone else seems to be doing ASoC: thing: rather than having a -. As far as I remember it was Peter that started it, though other people (including me) adopted it too.

Historically since 2005 the ASoC patch subject prefix has never been in any fixed style. My personal preference is the same as Takashi's for HDA, but I've no problems changing a - to a :. Lets make it more official now and have :-

ASoC: thing: change

Regards

Liam

#3 lore raw
Quoted 2 lines · Liam Girdwood

Historically since 2005 the ASoC patch subject prefix has never been in any fixed style. My personal preference is the same as Takashi's for

Yeah, it's mostly sprung up in the past year or so.

Quoted 4 lines

HDA, but I've no problems changing a - to a :. Lets make it more official now and have :-

ASoC: thing: change

OK. I've not been bothering for people who were only using plain ASoC:, I mostly just mentioned it because you'd picked a different standard for your commits to what everyone else had chosen.

#4 lore raw
In reply to Liam Girdwood

At Wed, 07 Mar 2012 09:48:50 +0000,

Quoted 11 lines · Liam Girdwood
Quoted 8 lines · Mark Brown
Quoted 1 line · Liam Girdwood

Remove printk(KERN_WARNING) and use dev_warn() instead.

Applied, thanks.

Everyone else seems to be doing ASoC: thing: rather than having a -. As far as I remember it was Peter that started it, though other people (including me) adopted it too.

Quoted 6 lines

Historically since 2005 the ASoC patch subject prefix has never been in any fixed style. My personal preference is the same as Takashi's for HDA, but I've no problems changing a - to a :. Lets make it more official now and have :-

ASoC: thing: change

It seems that "A: B: C" is more popular, indeed.

I've been using it since it looks more readable to me, but it's really a matter of taste.

Takashi