pxa: attempt at switch to common clock framework
cover pxa: attempt at switch to common clock framework
Hi,
I have made an attempt at an initial conversion of PXA clocks to the common clock framework (http://lkml.org/lkml/2012/3/16/25), and I'd like to know if somebody is already working on this, or if I am heading in the general right direction.
Unfortunately, this set still hangs during boot on hx4700 (pxa270), unless I also disable the calls to __clk_lookup in drivers/clk/clk.c completely (or apply the patch below). I'll investigate once I get access to my serial cable and hx4700 charger, but I'd be grateful if somebody could spot any embarassingly obvious errors.
For pxa25x and pxa3xx, it's compile-tested only.
regards
Philipp
--- drivers/clk/clk.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-)
drivers/clk/clk.c +3 -2
@@ -336,14 +336,15 @@ static struct clk *__clk_lookup_subtree(const char *name, struct clk *clk)struct hlist_node *tmp;if (!strcmp (clk->name, name)) -return clk; +return NULL ; +#if 0 hlist_for_each_entry (child, tmp, &clk->children, child_node) { ret =__clk_lookup_subtree (name, child);if (ret)return ret; } - +#endif return NULL ; }
Signature · 1 line
1.7.9.1
cover pxa: attempt at switch to common clock framework
Quoted 7 lines · Philipp Zabel
Hi,
I have made an attempt at an initial conversion of PXA clocks to the common clock framework (http://lkml.org/lkml/2012/3/16/25), and I'd like to know if somebody is already working on this, or if I am heading in the general right direction.
Quoted 5 lines
Unfortunately, this set still hangs during boot on hx4700 (pxa270), unless I also disable the calls to
__clk_lookupindrivers/clk/clk.ccompletely (or apply the patch below). I'll investigate once I get access to my serial cable and hx4700 charger, but I'd be grateful if somebody could spot any embarassingly obvious errors.
I responded with details for your patch #4. Looks like the macros are missing a bit of initialization data. Definitely not an embarrassing error! Those macros are not small. It does show yet one more reason why it would be good to get rid of the static initialization code at some point in the future.
Regards,
Mike
Quoted 40 lines
For pxa25x and pxa3xx, it's compile-tested only.
regards
Philipp---
?drivers/clk/clk.c | ? ?8 +++++---
?1 files changed, 5 insertions(+), 3 deletions(-)drivers/clk/clk.c +3
-3@@ -336,14 +336,15 @@ static struct clk *__clk_lookup_subtree(const char *name, struct clk *clk) ? ? ? ?struct hlist_node *tmp; ? ? ? ?if (!strcmp(clk->name, name)) - ? ? ? ? ? ? ? return clk; + ? ? ? ? ? ? ? return NULL; +#if 0 ? ? ? ?hlist_for_each_entry(child, tmp, &clk->children, child_node) { ? ? ? ? ? ? ? ?ret = __clk_lookup_subtree(name, child); ? ? ? ? ? ? ? ?if (ret) ? ? ? ? ? ? ? ? ? ? ? ?return ret; ? ? ? ?} - +#endif ? ? ? ?return NULL; ?} --1.7.9.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel