Skip to content

pxa: attempt at switch to common clock framework

Philipp Zabel linux-arm-kernel 1 version New

Get series with b4
b4 am 1331919343.31118.19.camel@flow

Versions newest first

  1. v1 Latest3 of 4 patches 0 repliesNew

3 of 4 patches are in this archive. The cover letter announces 4.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4pxa: Remove INIT_CLKREG macro, replace it with the equivalent CLKDEV_INITarch/arm/mach-pxa/clock.h arch/arm/mach-pxa/eseries.c arch/arm/mach-pxa/pxa25x.c +5 more+95 -1020 replies
2/4pxa2xx: move clkops definitions into a separate object filearch/arm/mach-pxa/Makefile arch/arm/mach-pxa/clock-pxa25x.c arch/arm/mach-pxa/clock-pxa27x.c +3 more+266 -2280 replies
3/4pxa2xx: checkpatch fixes for clock-pxa25x.c and clock-pxa27x.carch/arm/mach-pxa/clock-pxa25x.c arch/arm/mach-pxa/clock-pxa27x.c+21 -220 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC/PATCH 0/4] pxa: attempt at switch to common clock framework

Hi,

I have made an attempt at an initial conversion of PXA clocks to the common clock framework (http://lkml.org/lkml/2012/3/16/25), and I'd like to know if somebody is already working on this, or if I am heading in the general right direction.

Unfortunately, this set still hangs during boot on hx4700 (pxa270), unless I also disable the calls to __clk_lookup in drivers/clk/clk.c completely (or apply the patch below). I'll investigate once I get access to my serial cable and hx4700 charger, but I'd be grateful if somebody could spot any embarassingly obvious errors.
For pxa25x and pxa3xx, it's compile-tested only.

regards
Philipp

---
 drivers/clk/clk.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)
drivers/clk/clk.c +3 -2
index c7c3bc5..79b46af 100644
@@ -336,14 +336,15 @@ static struct clk *__clk_lookup_subtree(const char *name, struct clk *clk)
 	struct hlist_node *tmp;
 
 	if (!strcmp(clk->name, name))
-		return clk;
+		return NULL;
 
+#if 0
 	hlist_for_each_entry(child, tmp, &clk->children, child_node) {
 		ret = __clk_lookup_subtree(name, child);
 		if (ret)
 			return ret;
 	}
-
+#endif
 	return NULL;
 }
 
Signature · 1 line
1.7.9.1