Skip to contentSkip to conversation

pinctrl/pinctrl-spear: remove IS_ERR checking of pmx->pctl

PATCH Applied Devendra Naga 2 participants 2 messages Jun 18, 2012 – Jun 20, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 pinctrl/pinctrl-spear: remove IS_ERR checking of pmx->pctl

pinctrl_register returns a pointer of struct type struct pinctrl_dev, if successfully registered to pinctrl subsystem, otherwise returns NULL, and there wont' be any pointers which are not dereferencible.

They are not type of pointer addresses but are kind of error codes rather actual addresses, but are a kind of return codes of functions returning integer types.

return -ENODEV if device registration fails.

---
 drivers/pinctrl/spear/pinctrl-spear.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pinctrl/spear/pinctrl-spear.c +2 -2
index 5ae50aa..b9a52c9 100644
@@ -336,9 +336,9 @@ int __devinit spear_pinctrl_probe(struct platform_device *pdev,
 	spear_pinctrl_desc.npins = machdata->npins;
 
 	pmx->pctl = pinctrl_register(&spear_pinctrl_desc, &pdev->dev, pmx);
-	if (IS_ERR(pmx->pctl)) {
+	if (!pmx->pctl) {
 		dev_err(&pdev->dev, "Couldn't register pinctrl driver\n");
-		return PTR_ERR(pmx->pctl);
+		return -ENODEV;
 	}
 
 	return 0;
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 11 lines · Devendra Naga

pinctrl_register returns a pointer of struct type struct pinctrl_dev, if successfully registered to pinctrl subsystem, otherwise returns NULL, and there wont' be any pointers which are not dereferencible.

They are not type of pointer addresses but are kind of error codes rather actual addresses, but are a kind of return codes of functions returning integer types.

return -ENODEV if device registration fails.

Applied, thanks!
Linus Walleij