ALSA: snd-usb-caiaq: initialize card pointer
Subsystems (2)
Daniel Mack
maintainerPATCH 1/1 ALSA: snd-usb-caiaq: initialize card pointer
Fixes the following warning:
CC [M] sound/usb/caiaq/device.osound/usb/caiaq/device.c: In function ‘snd_probe’:sound/usb/caiaq/device.c:500:16: warning: ‘card’ may be used uninitialized in this function [-Wmaybe-uninitialized]
--- sound/usb/caiaq/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/usb/caiaq/device.c +1 -1
@@ -485,7 +485,7 @@ static int __devinit snd_probe(struct usb_interface *intf, const struct usb_device_id *id) {int ret; -struct snd_card *card; +struct snd_card *card =NULL ;struct usb_device *device =interface_to_usbdev (intf); ret =create_card (device, intf, &card);
Signature · 6 lines
1.7.10.2 _______________________________________________ Alsa-devel mailing list [email protected] http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Daniel Mack
maintainerping
Quoted 18 lines · Daniel Mack
Fixes the following warning:
CC [M]
sound/usb/caiaq/device.osound/usb/caiaq/device.c: In function ‘snd_probe’:sound/usb/caiaq/device.c:500:16: warning: ‘card’ may be used uninitialized in this function [-Wmaybe-uninitialized]Signed-off-by Daniel Mack <[email protected]>--- sound/usb/caiaq/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)sound/usb/caiaq/device.c +0
-0
sound/usb/caiaq/device.c static int __devinit snd_probe(struct usb_interface *intf, · line 491
Quoted 8 lines
sound/usb/caiaq/device.c +1
-1@@ -485,7 +485,7 @@ static int __devinit snd_probe(struct usb_interface *intf, const struct usb_device_id *id) {int ret; -struct snd_card *card; +struct snd_card *card =NULL ;struct usb_device *device =interface_to_usbdev (intf); ret =create_card (device, intf, &card);
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
At Mon, 18 Jun 2012 21:16:31 +0200,
Quoted 18 lines · Daniel Mack
Fixes the following warning:
CC [M]
sound/usb/caiaq/device.osound/usb/caiaq/device.c: In function ‘snd_probe’:sound/usb/caiaq/device.c:500:16: warning: ‘card’ may be used uninitialized in this function [-Wmaybe-uninitialized]Signed-off-by Daniel Mack <[email protected]>--- sound/usb/caiaq/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)sound/usb/caiaq/device.c +0
-0
sound/usb/caiaq/device.c static int __devinit snd_probe(struct usb_interface *intf, · line 488
Quoted 5 lines
sound/usb/caiaq/device.c +1
-1@@ -485,7 +485,7 @@ static int __devinit snd_probe(struct usb_interface *intf, const struct usb_device_id *id) {int ret; -struct snd_card *card; +struct snd_card *card =NULL ;
It's always a question how to "fix" such a problem.
The first option is to assign some "reasonable" value. Like your patch. The second option is to use uninitialized_var().
The last option is to ignore it. It's gcc to blame.
I don't mind too much about such a trivial thing, so I just took your patch now.
thanks,
Takashi
Quoted 10 lines
sound/usb/caiaq/device.c +0
-0struct usb_device *device =interface_to_usbdev (intf); ret =create_card (device, intf, &card);Signature · 6 lines
1.7.10.2 _______________________________________________ Alsa-devel mailing list [email protected] http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel