Skip to contentSkip to conversation

ALSA: snd-usb-caiaq: initialize card pointer

PATCH In review Daniel Mack 2 participants 3 messages Jun 18, 2012 – Jun 27, 2012

Subsystems (2)
lore
Share & tools
lore

Daniel Mack

author maintainer
#0 lore raw

PATCH 1/1 ALSA: snd-usb-caiaq: initialize card pointer

Fixes the following warning:

CC [M] sound/usb/caiaq/device.o
sound/usb/caiaq/device.c: In function ‘snd_probe’:
sound/usb/caiaq/device.c:500:16: warning: ‘card’ may be used uninitialized in this function [-Wmaybe-uninitialized]

---
 sound/usb/caiaq/device.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/usb/caiaq/device.c +1 -1
index 64aed43..7da0d0a 100644
@@ -485,7 +485,7 @@ static int __devinit snd_probe(struct usb_interface *intf,
 		     const struct usb_device_id *id)
 {
 	int ret;
-	struct snd_card *card;
+	struct snd_card *card = NULL;
 	struct usb_device *device = interface_to_usbdev(intf);
 
 	ret = create_card(device, intf, &card);
Signature · 6 lines
1.7.10.2

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
author maintainer
#1 lore raw

ping

Quoted 18 lines · Daniel Mack

Fixes the following warning:

CC [M] sound/usb/caiaq/device.o
sound/usb/caiaq/device.c: In function ‘snd_probe’:
sound/usb/caiaq/device.c:500:16: warning: ‘card’ may be used uninitialized in this function [-Wmaybe-uninitialized]

---
 sound/usb/caiaq/device.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/usb/caiaq/device.c +0 -0
index 64aed43..7da0d0a 100644

sound/usb/caiaq/device.c static int __devinit snd_probe(struct usb_interface *intf, · line 491

Quoted 8 lines
sound/usb/caiaq/device.c +1 -1
@@ -485,7 +485,7 @@ static int __devinit snd_probe(struct usb_interface *intf,
 		     const struct usb_device_id *id)
 {
 	int ret;
-	struct snd_card *card;
+	struct snd_card *card = NULL;
 	struct usb_device *device = interface_to_usbdev(intf);
 
 	ret = create_card(device, intf, &card);

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

#2 lore raw
In reply to Daniel Mack

At Mon, 18 Jun 2012 21:16:31 +0200,

Quoted 18 lines · Daniel Mack

Fixes the following warning:

CC [M] sound/usb/caiaq/device.o
sound/usb/caiaq/device.c: In function ‘snd_probe’:
sound/usb/caiaq/device.c:500:16: warning: ‘card’ may be used uninitialized in this function [-Wmaybe-uninitialized]

---
 sound/usb/caiaq/device.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/usb/caiaq/device.c +0 -0
index 64aed43..7da0d0a 100644

sound/usb/caiaq/device.c static int __devinit snd_probe(struct usb_interface *intf, · line 488

Quoted 5 lines
sound/usb/caiaq/device.c +1 -1
@@ -485,7 +485,7 @@ static int __devinit snd_probe(struct usb_interface *intf,
 		     const struct usb_device_id *id)
 {
 	int ret;
-	struct snd_card *card;
+	struct snd_card *card = NULL;

It's always a question how to "fix" such a problem.
The first option is to assign some "reasonable" value. Like your patch. The second option is to use uninitialized_var().
The last option is to ignore it. It's gcc to blame.

I don't mind too much about such a trivial thing, so I just took your patch now.

thanks,

Takashi

Quoted 10 lines
sound/usb/caiaq/device.c +0 -0
 	struct usb_device *device = interface_to_usbdev(intf);
 
 	ret = create_card(device, intf, &card);
Signature · 6 lines
1.7.10.2

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel