mfd: Remove __devexit annotation for pm80x_deinit

PATCH Superseded Axel Lin 2 participants 2 messages Jul 11, 2012 Multifunction devices (MFD)

lore

Share & tools

lore

Axel Lin

author

2012-07-11 01:48 UTC #0 lore raw

PATCH 1/1 mfd: Remove __devexit annotation for pm80x_deinit

This fixes below section mismatch warning:

LD drivers/mfd/built-in.o
WARNING: drivers/mfd/built-in.o(.devinit.text+0x46c): Section mismatch in reference from the function pm800_probe() to the function .devexit.text:pm80x_deinit() The function __devinit pm800_probe() references
a function __devexit pm80x_deinit().
This is often seen when error handling in the init function
uses functionality in the exit path.
The fix is often to remove the __devexit annotation of
pm80x_deinit() so it may be used outside an exit section.

Signed-off-by Axel Lin <[email protected]>

---
 drivers/mfd/88pm80x.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/mfd/88pm80x.c +1 -1

index 62da342..cd0bf52 100644
@@ -91,7 +91,7 @@ err_regmap_init:
 }
 EXPORT_SYMBOL_GPL(pm80x_init);
 
-int __devexit pm80x_deinit(struct i2c_client *client)
+int pm80x_deinit(struct i2c_client *client)
 {
 	struct pm80x_chip *chip = i2c_get_clientdata(client);

Signature · 1 line

1.7.9.5

Qiao Zhou

2012-07-11 01:52 UTC #1 lore raw

Quoted 22 lines · Axel Lin

This fixes below section mismatch warning:
LD drivers/mfd/built-in.o
WARNING: drivers/mfd/built-in.o(.devinit.text+0x46c): Section mismatch in reference from the function pm800_probe() to the function .devexit.text:pm80x_deinit() The function __devinit pm800_probe() references
a function __devexit pm80x_deinit().
This is often seen when error handling in the init function
uses functionality in the exit path.
The fix is often to remove the __devexit annotation of
pm80x_deinit() so it may be used outside an exit section.
Signed-off-by Axel Lin <[email protected]>
---
  drivers/mfd/88pm80x.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mfd/88pm80x.c +0 -0
index 62da342..cd0bf52 100644

drivers/mfd/88pm80x.c err_regmap_init: · line 97

Quoted 8 lines

drivers/mfd/88pm80x.c +1 -1

@@ -91,7 +91,7 @@ err_regmap_init:
  }
  EXPORT_SYMBOL_GPL(pm80x_init);
 
-int __devexit pm80x_deinit(struct i2c_client *client)
+int pm80x_deinit(struct i2c_client *client)
  {
  	struct pm80x_chip *chip = i2c_get_clientdata(client);

Alex,

thanks again for the fixing, and would try to avoid such warning in future.

Signature · 2 lines

Best Regards
Qiao