Skip to contentSkip to conversation

drm/i915: be less verbose about inability to provide vendor backlight

PATCH Applied Jani Nikula 3 participants 3 messages Oct 25, 2012 – Oct 26, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: be less verbose about inability to provide vendor backlight

commit 28dcc2d60cb570d9f549c329b2f51400553412a1

Author: Jani Nikula <[email protected]>
Date:   Mon Sep 3 16:25:12 2012 +0300

drm/i915: do not expose a dysfunctional backlight interface to userspace

prevents backlight interface creation if the BIOS has not set the backlight PWM CTL registers that contain the max PWM value. It's apparently normal on those machines, so demote the message about it to debug level.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=56330

---
 drivers/gpu/drm/i915/intel_panel.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_panel.c +1 -1
index e91a0bb..bd96eec 100644
@@ -428,7 +428,7 @@ int intel_panel_setup_backlight(struct drm_connector *connector)
 	props.type = BACKLIGHT_RAW;
 	props.max_brightness = _intel_panel_get_max_backlight(dev);
 	if (props.max_brightness == 0) {
-		DRM_ERROR("Failed to get maximum backlight value\n");
+		DRM_DEBUG_DRIVER("Failed to get maximum backlight value\n");
 		return -ENODEV;
 	}
 	dev_priv->backlight =
Signature · 1 line
1.7.9.5
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Jani Nikula

commit 28dcc2d60cb570d9f549c329b2f51400553412a1

Author: Jani Nikula <[email protected]>
Date:   Mon Sep 3 16:25:12 2012 +0300

drm/i915: do not expose a dysfunctional backlight interface to userspace

Quoted 7 lines

prevents backlight interface creation if the BIOS has not set the backlight PWM CTL registers that contain the max PWM value. It's apparently normal on those machines, so demote the message about it to debug level.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=56330

We may want to create an explicit bug/task to track the missing initialisation as a reminder as well.

-Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
#2 lore raw
Quoted 11 lines · Chris Wilson
Quoted 10 lines · Jani Nikula

commit 28dcc2d60cb570d9f549c329b2f51400553412a1

Author: Jani Nikula <[email protected]>
Date:   Mon Sep 3 16:25:12 2012 +0300

drm/i915: do not expose a dysfunctional backlight interface to userspace

prevents backlight interface creation if the BIOS has not set the backlight PWM CTL registers that contain the max PWM value. It's apparently normal on those machines, so demote the message about it to debug level.

Quoted 6 lines
Quoted 3 lines

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=56330

We may want to create an explicit bug/task to track the missing initialisation as a reminder as well.

I suspect we'll get them automatically when people complain about non-working backlights. Like they already do for non-working edp without the bios' help. Till that happens, I'm choosing blissfull ignorance ;-)

Quoted 1 line

Picked up for -fixes, thanks for the patch.
-Daniel

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch