sparc: dma-mapping: support debug_dma_mapping_error

PATCH Applied Shuah Khan 4 participants 12 messages Oct 26, 2012 – Nov 17, 2012 SPARC + UltraSPARC (sparc/sparc64)

Share & tools

Shuah Khan

author

2012-10-26 00:36 UTC #0 lore raw

PATCH 1/1 sparc: dma-mapping: support debug_dma_mapping_error

From 9e8feb61482288c5a5dd609e0dd17c1a262a48a3 Mon Sep 17 00:00:00 2001
From: Shuah Khan <[email protected]>
Date: Thu, 25 Oct 2012 18:31:42 -0600
Subject: [PATCH RFT] sparc: dma-mapping: support debug_dma_mapping_error

Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated.

Signed-off-by Shuah Khan <[email protected]>

---
 arch/sparc/include/asm/dma-mapping.h |    1 +
 1 file changed, 1 insertion(+)

arch/sparc/include/asm/dma-mapping.h +1 -0

index 8493fd3..05fe53f 100644
@@ -59,6 +59,7 @@ static inline void dma_free_attrs(struct device *dev, size_t size,
 
 static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr)
 {
+	debug_dma_mapping_error(dev, dma_addr);
 	return (dma_addr = DMA_ERROR_CODE);
 }

Signature · 1 line

1.7.9.5

Shuah Khan

2012-10-26 00:38 UTC #1 lore raw

PATCH RESEND 1/1 sparc: dma-mapping: support debug_dma_mapping_error

Signed-off-by Shuah Khan <[email protected]>

---
 arch/sparc/include/asm/dma-mapping.h |    1 +
 1 file changed, 1 insertion(+)

arch/sparc/include/asm/dma-mapping.h +1 -0

index 8493fd3..05fe53f 100644
@@ -59,6 +59,7 @@ static inline void dma_free_attrs(struct device *dev, size_t size,
 
 static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr)
 {
+	debug_dma_mapping_error(dev, dma_addr);
 	return (dma_addr = DMA_ERROR_CODE);
 }

Signature · 1 line

1.7.9.5

Shuah Khan

author

2012-10-26 16:13 UTC #2 lore raw

PATCH RESEND 1/1 sparc: dma-mapping: support debug_dma_mapping_error

Signed-off-by Shuah Khan <[email protected]>

---
 arch/sparc/include/asm/dma-mapping.h |    1 +
 1 file changed, 1 insertion(+)

arch/sparc/include/asm/dma-mapping.h +1 -0

index 8493fd3..05fe53f 100644
@@ -59,6 +59,7 @@ static inline void dma_free_attrs(struct device *dev, size_t size,
 
 static inline int dma_mapping_error(struct device *dev, dma_addr_t dma_addr)
 {
+	debug_dma_mapping_error(dev, dma_addr);
 	return (dma_addr = DMA_ERROR_CODE);
 }

Signature · 1 line

1.7.9.5

David Miller

maintainer

2012-10-26 19:01 UTC #3 lore raw

From: Shuah Khan <[email protected]>
Date: Fri, 26 Oct 2012 10:13:09 -0600

Quoted 6 lines

Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated.
Signed-off-by Shuah Khan <[email protected]>

Why are you resending this?

When you resend patches, you have to give a reason. Did the patch change? Are you updating the CC: list of the patch posting? Are you correcting something else?

David Miller

maintainer

2012-10-26 19:10 UTC #4 lore raw

From: David Miller <[email protected]>
Date: Fri, 26 Oct 2012 15:01:53 -0400 (EDT)

Quoted 8 lines

From: Shuah Khan <[email protected]>
Date: Fri, 26 Oct 2012 10:13:09 -0600
Quoted 5 lines
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated.

Quoted 7 lines

Quoted 1 line
Signed-off-by Shuah Khan <[email protected]>
Why are you resending this?
When you resend patches, you have to give a reason. Did the patch change? Are you updating the CC: list of the patch posting? Are you correcting something else?

In fact you sent this _3_ times. Please, don't do this, or at least explain why you are reposting something each time.

Shuah Khan

author

2012-10-26 21:40 UTC #5 lore raw

Quoted 13 lines · David Miller

From: David Miller <[email protected]>
Date: Fri, 26 Oct 2012 15:01:53 -0400 (EDT)
Quoted 10 lines
From: Shuah Khan <[email protected]>
Date: Fri, 26 Oct 2012 10:13:09 -0600
Quoted 6 lines
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated.
Signed-off-by Shuah Khan <[email protected]>

Quoted 8 lines

Quoted 5 lines
Why are you resending this?
When you resend patches, you have to give a reason. Did the patch change? Are you updating the CC: list of the patch posting? Are you correcting something else?
In fact you sent this _3_ times. Please, don't do this, or at least explain why you are reposting something each time.

I am really sorry for the noise. I forgot to mark this explicitly for linux-next the first time and this patch depends on a patch that went into linux-next. I sent a few patches for several architectures and lost track. I meant to add explanation before I hit send. The reason for resend is to tag it for linux-next.

-- Shuah

David Miller

maintainer

2012-11-10 00:38 UTC #6 lore raw

In reply to Shuah Khan

From: Shuah Khan <[email protected]>
Date: Fri, 26 Oct 2012 10:13:09 -0600

Quoted 6 lines

Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated.
Signed-off-by Shuah Khan <[email protected]>

This doesn't even compile:

/home/davem/src/GIT/sparc/arch/sparc/include/asm/dma-mapping.h: In function 'dma_mapping_error':
/home/davem/src/GIT/sparc/arch/sparc/include/asm/dma-mapping.h:62:2: error: implicit declaration of function 'debug_dma _mapping_error' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
In file included from include/linux/dma-mapping.h:76:0,

                 from include/linux/skbuff.h:33,
                 from include/linux/icmpv6.h:4,
                 from include/linux/ipv6.h:58,
                 from include/net/ipv6.h:16,
                 from include/linux/sunrpc/clnt.h:26,
                 from include/linux/nfs_fs.h:30,
                 from init/do_mounts.c:30:

Shuah Khan

author

2012-11-10 00:52 UTC #7 lore raw

Quoted 17 lines · David Miller

From: Shuah Khan <[email protected]>
Date: Fri, 26 Oct 2012 10:13:09 -0600
Quoted 6 lines
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated.
Signed-off-by Shuah Khan <[email protected]>
This doesn't even compile:
/home/davem/src/GIT/sparc/arch/sparc/include/asm/dma-mapping.h: In function 'dma_mapping_error':
/home/davem/src/GIT/sparc/arch/sparc/include/asm/dma-mapping.h:62:2: error: implicit declaration of function 'debug_dma _mapping_error' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
In file included from include/linux/dma-mapping.h:76:0,

Quoted 7 lines

                 from include/linux/skbuff.h:33,
                 from include/linux/icmpv6.h:4,
                 from include/linux/ipv6.h:58,
                 from include/net/ipv6.h:16,
                 from include/linux/sunrpc/clnt.h:26,
                 from include/linux/nfs_fs.h:30,
                 from init/do_mounts.c:30:

The problem the dependent patch is in linux-next and not in arch trees yet. That is why I am trying it get this through linux-next and/or dma-debug tree. I am open to suggestions on what is the best route.

linux-next commit-id is:

commit 6c9c6d6301287e369a754d628230fa6e50cdb74b

I have another one that I sent to linux-next that fixes the dependency on get_dma_ops():

https://lkml.org/lkml/2012/11/3/219

Thanks,
-- Shuah

David Miller

maintainer Acked-by

2012-11-10 00:54 UTC #8 lore raw

From: Shuah Khan <[email protected]>
Date: Fri, 09 Nov 2012 17:52:23 -0700

Quoted 26 lines · David Miller

Quoted 17 lines
From: Shuah Khan <[email protected]>
Date: Fri, 26 Oct 2012 10:13:09 -0600
Quoted 6 lines
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated.
Signed-off-by Shuah Khan <[email protected]>
This doesn't even compile:
/home/davem/src/GIT/sparc/arch/sparc/include/asm/dma-mapping.h: In function 'dma_mapping_error':
/home/davem/src/GIT/sparc/arch/sparc/include/asm/dma-mapping.h:62:2: error: implicit declaration of function 'debug_dma _mapping_error' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
In file included from include/linux/dma-mapping.h:76:0,
Quoted 7 lines
                 from include/linux/skbuff.h:33,
                 from include/linux/icmpv6.h:4,
                 from include/linux/ipv6.h:58,
                 from include/net/ipv6.h:16,
                 from include/linux/sunrpc/clnt.h:26,
                 from include/linux/nfs_fs.h:30,
                 from init/do_mounts.c:30:

Quoted 3 lines

The problem the dependent patch is in linux-next and not in arch trees yet. That is why I am trying it get this through linux-next and/or dma-debug tree. I am open to suggestions on what is the best route.

Then please put this in via the dma-debug tree:

Acked-by David S. Miller <[email protected]>

Shuah Khan

author

2012-11-10 01:21 UTC #9 lore raw

Quoted 29 lines · David Miller

From: Shuah Khan <[email protected]>
Date: Fri, 09 Nov 2012 17:52:23 -0700
Quoted 26 lines · David Miller
Quoted 24 lines
From: Shuah Khan <[email protected]>
Date: Fri, 26 Oct 2012 10:13:09 -0600
Quoted 6 lines
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated.
Signed-off-by Shuah Khan <[email protected]>
This doesn't even compile:
/home/davem/src/GIT/sparc/arch/sparc/include/asm/dma-mapping.h: In function 'dma_mapping_error':
/home/davem/src/GIT/sparc/arch/sparc/include/asm/dma-mapping.h:62:2: error: implicit declaration of function 'debug_dma _mapping_error' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
In file included from include/linux/dma-mapping.h:76:0,
                 from include/linux/skbuff.h:33,
                 from include/linux/icmpv6.h:4,
                 from include/linux/ipv6.h:58,
                 from include/net/ipv6.h:16,
                 from include/linux/sunrpc/clnt.h:26,
                 from include/linux/nfs_fs.h:30,
                 from init/do_mounts.c:30:

Quoted 7 lines

Quoted 3 lines
The problem the dependent patch is in linux-next and not in arch trees yet. That is why I am trying it get this through linux-next and/or dma-debug tree. I am open to suggestions on what is the best route.
Then please put this in via the dma-debug tree:
Acked-by David S. Miller <[email protected]>

Thanks
-- Shuah

Shuah Khan

author

2012-11-15 17:39 UTC #10 lore raw

In reply to David Miller

Quoted 29 lines · David Miller

From: Shuah Khan <[email protected]>
Date: Fri, 09 Nov 2012 17:52:23 -0700
Quoted 26 lines · David Miller
Quoted 24 lines
From: Shuah Khan <[email protected]>
Date: Fri, 26 Oct 2012 10:13:09 -0600
Quoted 6 lines
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated.
Signed-off-by Shuah Khan <[email protected]>
This doesn't even compile:
/home/davem/src/GIT/sparc/arch/sparc/include/asm/dma-mapping.h: In function 'dma_mapping_error':
/home/davem/src/GIT/sparc/arch/sparc/include/asm/dma-mapping.h:62:2: error: implicit declaration of function 'debug_dma _mapping_error' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
In file included from include/linux/dma-mapping.h:76:0,
                 from include/linux/skbuff.h:33,
                 from include/linux/icmpv6.h:4,
                 from include/linux/ipv6.h:58,
                 from include/net/ipv6.h:16,
                 from include/linux/sunrpc/clnt.h:26,
                 from include/linux/nfs_fs.h:30,
                 from init/do_mounts.c:30:

Quoted 7 lines

Quoted 3 lines
The problem the dependent patch is in linux-next and not in arch trees yet. That is why I am trying it get this through linux-next and/or dma-debug tree. I am open to suggestions on what is the best route.
Then please put this in via the dma-debug tree:
Acked-by David S. Miller <[email protected]>

Marek,

This is for sparc to go through your tree.

Thanks,
-- Shuah

Joerg Roedel

Applied

2012-11-17 12:22 UTC #11 lore raw

In reply to Shuah Khan

Quoted 11 lines · Shuah Khan

Quoted 1 line
From 9e8feb61482288c5a5dd609e0dd17c1a262a48a3 Mon Sep 17 00:00:00 2001
From: Shuah Khan <[email protected]>
Date: Thu, 25 Oct 2012 18:31:42 -0600
Subject: [PATCH RFT] sparc: dma-mapping: support debug_dma_mapping_error
Add support for debug_dma_mapping_error() call to avoid warning from debug_dma_unmap() interface when it checks for mapping error checked status. Without this patch, device driver failed to check map error warning is generated.
Signed-off-by Shuah Khan <[email protected]>

Applied to dma-debug, thanks.

Btw, what about the patches for the other archs? They should depend on the dma-debug branch too and should also be there, no?

Joerg