Skip to contentSkip to conversation

regulator: tps65910: fix BUG_ON() shown with vrtc regulator

PATCH RESEND In review AnilKumar Ch 2 participants 4 messages Nov 14, 2012

Subsystems (2)
OMAP2+ support Voltage and current regulator framework
lore
Share & tools
lore

AnilKumar Ch

author
#0 lore raw

PATCH RESEND 1/1 regulator: tps65910: fix BUG_ON() shown with vrtc regulator

Fix BUG_ON() error if tps65910 VRTC regulator is used with out rdev->desc->volt_table data. Recent changes in regulator core driver which add support for "regulator_list_voltage_table" have BUG_ON() if regulator descriptor do not have voltage table information. This patch adds the voltage table information to fix the issue.

Signed-off-by AnilKumar Ch <[email protected]>
---
 drivers/regulator/tps65910-regulator.c |    7 +++++++
 1 file changed, 7 insertions(+)
drivers/regulator/tps65910-regulator.c +7 -0
index 793adda..1d2dd18 100644
@@ -38,6 +38,11 @@ static const unsigned int VIO_VSEL_table[] = {
 
 /* VSEL tables for TPS65910 specific LDOs and dcdc's */
 
+/* supported VRTC voltages in microvolts */
+static const unsigned int VRTC_VSEL_table[] = {
+	1800000,
+};
+
 /* supported VDD3 voltages in microvolts */
 static const unsigned int VDD3_VSEL_table[] = {
 	5000000,

@@ -95,6 +100,8 @@ static struct tps_info tps65910_regs[] = {
 	{
 		.name = "vrtc",
 		.vin_name = "vcc7",
+		.n_voltages = ARRAY_SIZE(VRTC_VSEL_table),
+		.voltage_table = VRTC_VSEL_table,
 		.enable_time_us = 2200,
 	},
 	{
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 5 lines · AnilKumar Ch

Fix BUG_ON() error if tps65910 VRTC regulator is used with out rdev->desc->volt_table data. Recent changes in regulator core driver which add support for "regulator_list_voltage_table" have BUG_ON() if regulator descriptor do not have voltage table information. This patch adds the voltage table information to fix the issue.

This is already applied... got dropped from -next for a day for some reason but it's there. When resending please do say why.

author
#2 lore raw
Quoted 10 lines · Mark Brown
Quoted 5 lines · AnilKumar Ch

Fix BUG_ON() error if tps65910 VRTC regulator is used with out rdev->desc->volt_table data. Recent changes in regulator core driver which add support for "regulator_list_voltage_table" have BUG_ON() if regulator descriptor do not have voltage table information. This patch adds the voltage table information to fix the issue.

This is already applied... got dropped from -next for a day for some reason but it's there. When resending please do say why.

Hi Mark,

Sorry for the noise (My bad missed the version change details). I have checked in regulator/for-next tree and not found, so resend the patch thanks for you time.

Thanks
AnilKumar

#3 lore raw
Quoted 8 lines · Chimata
Quoted 2 lines · Mark Brown

This is already applied... got dropped from -next for a day for some reason but it's there. When resending please do say why.

Sorry for the noise (My bad missed the version change details). I have checked in regulator/for-next tree and not found, so resend the patch thanks for you time.

Sure, no problem - the thing about saying why you're reposting is more for future reference, if you follow my advice and repost when you think something got forgotten or lost.