Add support for tps65090-charger
v2 cover Add support for tps65090-charger
This patchset adds support for the TPS65090-charger. This charger is registered as a subdevice of the TPS65090 PMIC.
This series includes a fix for the tps65090 header file where all the interrupts were shifted by 1.
Changes since v1:
- cleaned up tps65090 driver per comments (mostly var naming)
- flushed out commit description for driver
- reordered probe so irq is registered after power_supply and cleaned up 1st
Rhyland Klein (4):
mfd: tps65090: Fix enum in header file
mfd: tps65090: Add resources for charger
power_supply: tps65090-charger: Add binding doc
power: tps65090: Add support for tps65090-charger
.../devicetree/bindings/power_supply/tps65090.txt | 23 ++ drivers/mfd/tps65090.c | 10 + drivers/power/Kconfig | 7 + drivers/power/Makefile | 1 + drivers/power/tps65090-charger.c | 316 ++++++++++++++++++++ include/linux/mfd/tps65090.h | 6 + 6 files changed, 363 insertions(+) create mode 100644 Documentation/devicetree/bindings/power_supply/tps65090.txt create mode 100644 drivers/power/tps65090-charger.c
Signature · 1 line
1.7.9.5
PATCH v2 1/4 mfd: tps65090: Fix enum in header file
The enum is missing the definition for the first bit, which makes all the rest off by one. Add definition for the TPS65090_IRQ_INTERRUPT bit which at 0.
---
v2:
- no changes since v1
include/linux/mfd/tps65090.h | 1 + 1 file changed, 1 insertion(+)
include/linux/mfd/tps65090.h +1 -0
@@ -27,6 +27,7 @@/* TPS65090 IRQs */ enum { +TPS65090_IRQ_INTERRUPT ,TPS65090_IRQ_VAC_STATUS_CHANGE ,TPS65090_IRQ_VSYS_STATUS_CHANGE ,TPS65090_IRQ_BAT_STATUS_CHANGE ,
Signature · 1 line
1.7.9.5
PATCH v2 2/4 mfd: tps65090: Add resources for charger
In reply to Rhyland KleinAdd irq resources to pass to the charger mfd sub dev so the charger can listen for interrupts.
---
v2:
- no changes since v1
drivers/mfd/tps65090.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/mfd/tps65090.c +10 -0
@@ -56,12 +56,22 @@#define TPS65090_INT2_MASK_OVERLOAD_FET6 6#define TPS65090_INT2_MASK_OVERLOAD_FET7 7 +static struct resource charger_resources[] = { + { + .start =TPS65090_IRQ_VAC_STATUS_CHANGE , + .end =TPS65090_IRQ_VAC_STATUS_CHANGE , + .flags =IORESOURCE_IRQ , + } +}; +static struct mfd_cell tps65090s[] = { { .name ="tps65090-pmic" , }, { .name ="tps65090-charger" , + .num_resources =ARRAY_SIZE (charger_resources), + .resources = &charger_resources[0 ], }, };
Signature · 1 line
1.7.9.5
PATCH v2 3/4 power_supply: tps65090-charger: Add binding doc
In reply to Rhyland KleinThis change adds the binding documentation for the tps65090-charger.
---
v2:
- no changes since v1
.../devicetree/bindings/power_supply/tps65090.txt | 23 ++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 Documentation/devicetree/bindings/power_supply/tps65090.txt
Documentation/devicetree/bindings/power_supply/tps65090.txt new file +23 -0
@@ -0,0 +1,23 @@ +TPS65090 Frontend PMU with Switchmode Charger + +Required Properties: +-compatible: "ti,tps65090" +-reg: I2C slave address +-interrupts: the interrupt output to which this device connects + +Optional Properties: +-ti,enable-low-current-chrg: Enables charging when a low current is detected + while the default logic is to stop charging. + +Example: + + tps65090@48 { + compatible = "ti,tps65090"; + reg = <0x48>; + interrupts = <0 88 0x4>; + + ti,enable-low-current-chrg; + + regulators { + ... + };
Signature · 1 line
1.7.9.5
Re: [PATCH v2 3/4] power_supply: tps65090-charger: Add binding doc
Quoted 3 lines · Rhyland Klein
This change adds the binding documentation for the tps65090-charger.
Documentation/devicetree/bindings/power_supply/tps65090.txt +0
-0
...
Quoted 3 lines
Documentation/devicetree/bindings/power_supply/tps65090.txt +3
-0+Example: + + tps65090@48 {
...
Documentation/devicetree/bindings/power_supply/tps65090.txt line 23
Quoted 4 lines
Documentation/devicetree/bindings/power_supply/tps65090.txt +3
-0+ regulators { + ... + };
The "regulators" node in the example isn't mentioned in the list of properties/nodes that's above. What goes in there? You probably want to include text similar to what I've quoted below from Documentation/devicetree/bindings/regulator/tps6586x.txt:
Quoted 6 lines
- regulators: A node that houses a sub-node for each regulator within the device. Each sub-node is identified using the node's name (or the deprecated regulator-compatible property if present), with valid values listed below. The content of each sub-node is defined by the standard binding for regulators; see regulator.txt.
sys, sm[0-2], ldo[0-9] andldo_rtc
Re: [PATCH v2 3/4] power_supply: tps65090-charger: Add binding doc
Quoted 8 lines · Stephen Warren
Quoted 2 lines · Rhyland Klein
This change adds the binding documentation for the tps65090-charger.
Documentation/devicetree/bindings/power_supply/tps65090.txt +0
-0...
Quoted 3 lines
Documentation/devicetree/bindings/power_supply/tps65090.txt +3
-0+Example: + + tps65090@48 {...
Quoted 15 lines
Documentation/devicetree/bindings/power_supply/tps65090.txt line 23
Quoted 4 lines
Documentation/devicetree/bindings/power_supply/tps65090.txt +3
-0+ regulators { + ... + };The "regulators" node in the example isn't mentioned in the list of properties/nodes that's above. What goes in there? You probably want to include text similar to what I've quoted below from
Documentation/devicetree/bindings/regulator/tps6586x.txt:Quoted 6 lines
- regulators: A node that houses a sub-node for each regulator within the device. Each sub-node is identified using the node's name (or the deprecated regulator-compatible property if present), with valid values listed below. The content of each sub-node is defined by the standard binding for regulators; see regulator.txt.
sys, sm[0-2], ldo[0-9] andldo_rtc
The reason I didn't bother documenting the regulators node was that since this is a child device driver of an mfd device, there is already a child driver for the regulators with its own documentation
https://patchwork.kernel.org/patch/2051381/
I wasn't sure how I should handle this, as splitting the bindings to make logic sense in the binding layout (charger under power_supply, and regulators under regulator) or combine them somehow into a single documentation entry common to the device. The latter seems to make more sense to me, but since there aren't any dt specific entries for the core mfd part currently, it doesn't have its own documentation, and sticking the charger info under the regulators seemed backwards to me.
I thought doing it this way would be a good way of starting a discussion around how to handle this.
thanks for starting it Stephen :)
-rhyland
Signature · 1 line
nvpublic
Re: [PATCH v2 3/4] power_supply: tps65090-charger: Add binding doc
Quoted 27 lines · Rhyland Klein
Quoted 10 lines · Stephen Warren
Quoted 4 lines · Rhyland Klein
This change adds the binding documentation for the tps65090-charger. diff --git
a/Documentation/devicetree/bindings/power_supply/tps65090.txtb/Documentation/devicetree/bindings/power_supply/tps65090.txt...
Quoted 3 lines
Documentation/devicetree/bindings/power_supply/tps65090.txt new file +3
-0+Example: + + tps65090@48 {...
Quoted 15 lines
Documentation/devicetree/bindings/power_supply/tps65090.txt line 23
Quoted 3 lines
Documentation/devicetree/bindings/power_supply/tps65090.txt new file +3
-0+ regulators { + ... + };The "regulators" node in the example isn't mentioned in the list of properties/nodes that's above. What goes in there? You probably want to include text similar to what I've quoted below from
Documentation/devicetree/bindings/regulator/tps6586x.txt:Quoted 6 lines
- regulators: A node that houses a sub-node for each regulator within the device. Each sub-node is identified using the node's name (or the deprecated regulator-compatible property if present), with valid values listed below. The content of each sub-node is defined by the standard binding for regulators; see regulator.txt.
sys, sm[0-2], ldo[0-9] andldo_rtc
Quoted 6 lines
The reason I didn't bother documenting the regulators node was that since this is a child device
driver of an mfd device, there is already a child driver for the regulators with its own documentation
Ah, I see.
Quoted 6 lines
I wasn't sure how I should handle this, as splitting the bindings to make logic sense in the binding
layout (charger underpower_supply, and regulators under regulator) or combine them somehow
into a single documentation entry common to the device. The latter seems to make more sense to me,
Yes, given we're talking about properties in the same node, rather than a binding for a new child node that could be plugged into arbitrary parent nodes, I think everything should be documented in a single file.
Quoted 4 lines
but since there aren't any dt specific entries for the core mfd part currently, it doesn't have its own
documentation, and sticking the charger info under the regulators seemed backwards to me.
Hmmm. That's a good question. I'm not really sure where the best location for that file would be. Admittedly regulators does seem slightly over-specific, but short of creating a new bindings/mfd/ directory, it doesn't seem to unreasonable to just put the whole binding in the existing file in bindings/regulators/.
Perhaps Grant or Rob can comment on what their preference would be.
PATCH v2 4/4 power: tps65090: Add support for tps65090-charger
In reply to Rhyland KleinThis patch adds support for the tps65090 charger driver. This driver is responsible for controlling the charger aspect of the tps65090 mfd. Currently, this mainly consists of turning on and off the charger, but some features of the charger can be supported through this driver including:
Enable Auto Recharge based on Battery voltage
Fast Charge Safety Timer
Maximum battery discharge current
Maximum battery adapter current
Enable External Charge
Disable charging termination based on low charger current (supported)
Once the driver is accepted, later patches can add support for the features above which are not yet supported.
Based on work by:
Syed Rafiuddin <[email protected]>
Laxman Dewangan <[email protected]>
---
v2:
- updated commit description with more info
- cleaned up misc comments (var names, spacing, etc)
- reordered probe around irq so it is cleaner
drivers/power/Kconfig | 7 + drivers/power/Makefile | 1 + drivers/power/tps65090-charger.c | 316 ++++++++++++++++++++++++++++++++++++++ include/linux/mfd/tps65090.h | 5 + 4 files changed, 329 insertions(+) create mode 100644 drivers/power/tps65090-charger.c
drivers/power/Kconfig +7 -0
@@ -340,6 +340,13 @@ config CHARGER_SMB347 Say Y to include support for Summit Microelectronics SMB347 Battery Charger. +config CHARGER_TPS65090 + tristate "TPS65090 battery charger driver" + depends on MFD_TPS65090 + help + Say Y here to enable support for battery charging with TPS65090 + PMIC chips. + config AB8500_BM bool "AB8500 Battery Management Driver" depends on AB8500_CORE && AB8500_GPADC
drivers/power/Makefile +1 -0
@@ -53,4 +53,5 @@ obj-$(CONFIG_CHARGER_MAX8998) += max8998_charger.o obj-$(CONFIG_CHARGER_BQ2415X) += bq2415x_charger.o obj-$(CONFIG_POWER_AVS) += avs/ obj-$(CONFIG_CHARGER_SMB347) += smb347-charger.o +obj-$(CONFIG_CHARGER_TPS65090) += tps65090-charger.o obj-$(CONFIG_POWER_RESET) += reset/
drivers/power/tps65090-charger.c new file +316 -0
316 lines not on this page · raw message
include/linux/mfd/tps65090.h +5 -0
@@ -87,6 +87,11 @@ struct tps65090_regulator_plat_data {struct tps65090_platform_data {int irq_base; + +char **supplied_to; +size_t num_supplicants; +int enable_low_current_chrg; +struct tps65090_regulator_plat_data *reg_pdata[TPS65090_REGULATOR_MAX ]; };
Signature · 1 line
1.7.9.5