Skip to contentSkip to conversation

gpio: viperboard: Remove duplicate code to set gpio->gpiob_val

PATCH In review Axel Lin 3 participants 3 messages Mar 5, 2013 – Mar 27, 2013 GPIO

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 gpio: viperboard: Remove duplicate code to set gpio->gpiob_val

Set it once is enough, and it's done in vprbrd_gpiob_set() which is called by vprbrd_gpiob_direction_output().

---
 drivers/gpio/gpio-viperboard.c |    4 ----
 1 file changed, 4 deletions(-)
drivers/gpio/gpio-viperboard.c +0 -4
index 59d7239..095ab14 100644
@@ -380,10 +380,6 @@ static int vprbrd_gpiob_direction_output(struct gpio_chip *chip,
 	struct vprbrd *vb = gpio->vb;
 
 	gpio->gpiob_out |= (1 << offset);
-	if (value)
-		gpio->gpiob_val |= (1 << offset);
-	else
-		gpio->gpiob_val &= ~(1 << offset);
 
 	mutex_lock(&vb->lock);
 
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 4 lines · Axel Lin

Set it once is enough, and it's done in vprbrd_gpiob_set() which is called by vprbrd_gpiob_direction_output().

Thank you!

Quoted 18 lines
---
 drivers/gpio/gpio-viperboard.c |    4 ----
 1 file changed, 4 deletions(-)
(quoted diff) +0 -0

b/drivers/gpio/gpio-viperboard.c index 59d7239..095ab14 100644

drivers/gpio/gpio-viperboard.c +0 -4
@@ -380,10 +380,6 @@ static int vprbrd_gpiob_direction_output(struct
 gpio_chip *chip, struct vprbrd *vb = gpio->vb;
 
 	gpio->gpiob_out |= (1 << offset);
-	if (value)
-		gpio->gpiob_val |= (1 << offset);
-	else
-		gpio->gpiob_val &= ~(1 << offset);
 
 	mutex_lock(&vb->lock);