gpio: viperboard: Remove duplicate code to set gpio->gpiob_val
PATCH 1/1 gpio: viperboard: Remove duplicate code to set gpio->gpiob_val
Set it once is enough, and it's done in vprbrd_gpiob_set() which is called by vprbrd_gpiob_direction_output().
Signed-off-by Axel Lin <[email protected]>
--- drivers/gpio/gpio-viperboard.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/gpio/gpio-viperboard.c +0 -4
@@ -380,10 +380,6 @@ static int vprbrd_gpiob_direction_output(struct gpio_chip *chip,struct vprbrd *vb = gpio->vb; gpio->gpiob_out |= (1 << offset); -if (value) - gpio->gpiob_val |= (1 << offset); -else - gpio->gpiob_val &= ~(1 << offset);mutex_lock (&vb->lock);
Signature · 1 line
1.7.9.5
Quoted 4 lines · Axel Lin
Set it once is enough, and it's done in
vprbrd_gpiob_set()which is called byvprbrd_gpiob_direction_output().Signed-off-by Axel Lin <[email protected]>
Thank you!
Tested-and-Acked-by Lars Poeschel <[email protected]>
Quoted 18 lines
--- drivers/gpio/gpio-viperboard.c | 4 ---- 1 file changed, 4 deletions(-)(quoted diff) +0
-0
b/drivers/gpio/gpio-viperboard.cindex 59d7239..095ab14 100644drivers/gpio/gpio-viperboard.c +0
-4@@ -380,10 +380,6 @@ static int vprbrd_gpiob_direction_output(struct gpio_chip *chip, struct vprbrd *vb = gpio->vb; gpio->gpiob_out |= (1 << offset); -if (value) - gpio->gpiob_val |= (1 << offset); -else - gpio->gpiob_val &= ~(1 << offset);mutex_lock (&vb->lock);
Quoted 4 lines · Axel Lin
Set it once is enough, and it's done in
vprbrd_gpiob_set()which is called byvprbrd_gpiob_direction_output().Signed-off-by Axel Lin <[email protected]>
Applied with Lars' Tested/Acked-by.
Thanks!
Linus Walleij