Skip to contentSkip to conversation

ARM: dt: tegra114: add PWM nodes

PATCH Superseded Andrew Chew 2 participants 2 messages Mar 11, 2013 1 message not in the archive

Subsystems (2)

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dt: tegra114: add PWM nodes

This patch adds device tree nodes for the four PWM controllers present on tegra114.

---
 arch/arm/boot/dts/tegra114.dtsi |   32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)
arch/arm/boot/dts/tegra114.dtsi +32 -0
index 1dfaf28..68fc0e1 100644
@@ -150,4 +150,36 @@
 			     <1 11 0xf08>,
 			     <1 10 0xf08>;
 	};
+
+	pwm0: pwm@7000a000 {
+		compatible = "nvidia,tegra20-pwm";
+		reg = <0x7000a000 0x4>;
+		#pwm-cells = <2>;
+		clocks = <&tegra_car 17>;
+		status = "disabled";
+	};
+
+	pwm1: pwm@7000a010 {
+		compatible = "nvidia,tegra20-pwm";
+		reg = <0x7000a010 0x4>;
+		#pwm-cells = <2>;
+		clocks = <&tegra_car 17>;
+		status = "disabled";
+	};
+
+	pwm2: pwm@7000a020 {
+		compatible = "nvidia,tegra20-pwm";
+		reg = <0x7000a020 0x4>;
+		#pwm-cells = <2>;
+		clocks = <&tegra_car 17>;
+		status = "disabled";
+	};
+
+	pwm3: pwm@7000a030 {
+		compatible = "nvidia,tegra20-pwm";
+		reg = <0x7000a030 0x4>;
+		#pwm-cells = <2>;
+		clocks = <&tegra_car 17>;
+		status = "disabled";
+	};
 };
Signature · 1 line
1.7.9.5

A message that is not in the archive (sent off-list or not yet received): 1363041036-26358-1-git-send-email-achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org

#2 lore raw
Quoted 2 lines · Andrew Chew

This patch adds device tree nodes for the four PWM controllers present on tegra114.

Nit: Capitalize Tegra.

arch/arm/boot/dts/tegra114.dtsi line 152

Quoted 6 lines
arch/arm/boot/dts/tegra114.dtsi +0 -0
@@ -150,4 +150,36 @@
 			     <1 11 0xf08>,
 			     <1 10 0xf08>;
 	};

DT nodes should be sorted in order by reg address, so I think this is in the wrong place.

arch/arm/boot/dts/tegra114.dtsi line 154

Quoted 2 lines
arch/arm/boot/dts/tegra114.dtsi +2 -0
+	pwm0: pwm@7000a000 {
+		compatible = "nvidia,tegra20-pwm";

If the HW is 100% backwards-compatible, that should be:

compatible = "nvidia,tegra114-pwm", "nvidia,tegra20-pwm";

if not:

compatible = "nvidia,tegra114-pwm";