ARM: OMAP4: clock: Initialize USB DPLL
PATCH 1/1 ARM: OMAP4: clock: Initialize USB DPLL
If the bootloader doesn't configure USB DPLL (e.g. in u-boot, disable CONFIG_USB_EHCI_OMAP), then we get all sorts of problems like
- division by zero errors at boot [1]
- USB DPLL fails to enter locked state
- USB EHCI Host is non functional
- Device can't enter OFF mode
Initializing the USB DPLL fixes all these issues.
[1]
[ 0.000000] clock: dpll_usb_ck failed transition to 'locked' [ 0.000000] Division by zero in kernel. [ 0.000000] [<c001b00c>] (unwind_backtrace+0x0/0xf0) from [<c02b2378>] (Ldiv0+0x8/0x10) [ 0.000000] [<c02b2378>] (Ldiv0+0x8/0x10) from [<c041cf3c>] (clk_divider_set_rate+0x10/0x124) [ 0.000000] [<c041cf3c>] (clk_divider_set_rate+0x10/0x124) from [<c041bfc4>] (clk_change_rate+0x3c/0xb4) [ 0.000000] [<c041bfc4>] (clk_change_rate+0x3c/0xb4) from [<c041c028>] (clk_change_rate+0xa0/0xb4)
--- arch/arm/mach-omap2/cclock44xx_data.c | 19 +++++++++++++++++++ 1 files changed, 19 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/cclock44xx_data.c +19 -0
@@ -53,6 +53,12 @@*/ #define OMAP4_DPLL_ABE_DEFFREQ 98304000 +/* +* OMAP4450 TRM Rev X, section "3.6.3.9.5 DPLL_USB Preferred Settings" +* states it must be at 960MHz +*/ +#define OMAP4_DPLL_USB_DEFFREQ 960000000 +/* Root clocks */ DEFINE_CLK_FIXED_RATE (extalt_clkin_ck,CLK_IS_ROOT ,59000000 ,0x0 );
@@ -1729,6 +1735,19 @@ int __init omap4xxx_clk_init(void)omap2_clk_disable_autoidle_all ();/* +* Lock USB_DPLL to avoid issues with USB host and OFF mode +*/ + rc =clk_set_rate (&dpll_usb_ck,OMAP4_DPLL_USB_DEFFREQ ); +if (rc) { +pr_err ("%s: failed to configure DPLL_USB: %d\n" , __func__, rc); + }else { + rc =clk_set_rate (&dpll_usb_m2_ck,OMAP4_DPLL_USB_DEFFREQ /2 ); +if (rc) +pr_err ("%s: failed to configure DPLL_USB_M2: %d\n" , + __func__, rc); + } + +/* * On OMAP4460 the ABE DPLL fails to turn on if in idle low-power * state when turning the ABE clock domain. Workaround this by * locking the ABE DPLL on boot.
Signature · 1 line
1.7.4.1
Quoted 29 lines · Roger Quadros
If the bootloader doesn't configure USB DPLL (e.g. in u-boot, disable
CONFIG_USB_EHCI_OMAP), then we get all sorts of problems like
- division by zero errors at boot [1]
- USB DPLL fails to enter locked state
- USB EHCI Host is non functional
- Device can't enter OFF modeInitializing the USB DPLL fixes all these issues.
[1]
[ 0.000000] clock: dpll_usb_ck failed transition to 'locked' [ 0.000000] Division by zero in kernel. [ 0.000000] [<c001b00c>] (unwind_backtrace+0x0/0xf0) from [<c02b2378>] (Ldiv0+0x8/0x10) [ 0.000000] [<c02b2378>] (Ldiv0+0x8/0x10) from [<c041cf3c>] (clk_divider_set_rate+0x10/0x124) [ 0.000000] [<c041cf3c>] (clk_divider_set_rate+0x10/0x124) from [<c041bfc4>] (clk_change_rate+0x3c/0xb4) [ 0.000000] [<c041bfc4>] (clk_change_rate+0x3c/0xb4) from [<c041c028>] (clk_change_rate+0xa0/0xb4)Signed-off-by Roger Quadros <[email protected]>--- arch/arm/mach-omap2/cclock44xx_data.c | 19 +++++++++++++++++++ 1 files changed, 19 insertions(+), 0 deletions(-)arch/arm/mach-omap2/cclock44xx_data.c +0
-0
arch/arm/mach-omap2/cclock44xx_data.c line 57
Quoted 5 lines
arch/arm/mach-omap2/cclock44xx_data.c +2
-0@@ -53,6 +53,12 @@*/ #define OMAP4_DPLL_ABE_DEFFREQ 98304000 +/* +* OMAP4450 TRM Rev X, section "3.6.3.9.5 DPLL_USB Preferred Settings"
4460 actually.
cheers,
-roger
+Paul
Quoted 62 lines · Roger Quadros
If the bootloader doesn't configure USB DPLL (e.g. in u-boot, disable
CONFIG_USB_EHCI_OMAP), then we get all sorts of problems like
- division by zero errors at boot [1]
- USB DPLL fails to enter locked state
- USB EHCI Host is non functional
- Device can't enter OFF modeInitializing the USB DPLL fixes all these issues.
[1]
[ 0.000000] clock: dpll_usb_ck failed transition to 'locked' [ 0.000000] Division by zero in kernel. [ 0.000000] [<c001b00c>] (unwind_backtrace+0x0/0xf0) from [<c02b2378>] (Ldiv0+0x8/0x10) [ 0.000000] [<c02b2378>] (Ldiv0+0x8/0x10) from [<c041cf3c>] (clk_divider_set_rate+0x10/0x124) [ 0.000000] [<c041cf3c>] (clk_divider_set_rate+0x10/0x124) from [<c041bfc4>] (clk_change_rate+0x3c/0xb4) [ 0.000000] [<c041bfc4>] (clk_change_rate+0x3c/0xb4) from [<c041c028>] (clk_change_rate+0xa0/0xb4)Signed-off-by Roger Quadros <[email protected]>--- arch/arm/mach-omap2/cclock44xx_data.c | 19 +++++++++++++++++++ 1 files changed, 19 insertions(+), 0 deletions(-)arch/arm/mach-omap2/cclock44xx_data.c +19
-0@@ -53,6 +53,12 @@*/ #define OMAP4_DPLL_ABE_DEFFREQ 98304000 +/* +* OMAP4450 TRM Rev X, section "3.6.3.9.5 DPLL_USB Preferred Settings" +* states it must be at 960MHz +*/ +#define OMAP4_DPLL_USB_DEFFREQ 960000000 +/* Root clocks */ DEFINE_CLK_FIXED_RATE (extalt_clkin_ck,CLK_IS_ROOT ,59000000 ,0x0 );@@ -1729,6 +1735,19 @@ int __init omap4xxx_clk_init(void)omap2_clk_disable_autoidle_all ();/* +* Lock USB_DPLL to avoid issues with USB host and OFF mode +*/ + rc =clk_set_rate (&dpll_usb_ck,OMAP4_DPLL_USB_DEFFREQ ); +if (rc) { +pr_err ("%s: failed to configure DPLL_USB: %d\n" , __func__, rc); + }else { + rc =clk_set_rate (&dpll_usb_m2_ck,OMAP4_DPLL_USB_DEFFREQ /2 ); +if (rc) +pr_err ("%s: failed to configure DPLL_USB_M2: %d\n" , + __func__, rc); + } + +/* * On OMAP4460 the ABE DPLL fails to turn on if in idle low-power * state when turning the ABE clock domain. Workaround this by * locking the ABE DPLL on boot.
Paul Walmsley
maintainerHi Roger,
Quoted 12 lines · Roger Quadros
+Paul
Quoted 9 lines · Roger Quadros
If the bootloader doesn't configure USB DPLL (e.g. in u-boot, disable
CONFIG_USB_EHCI_OMAP), then we get all sorts of problems like
- division by zero errors at boot [1]
- USB DPLL fails to enter locked state
- USB EHCI Host is non functional
- Device can't enter OFF modeInitializing the USB DPLL fixes all these issues.
Looks like I may have lost track of this - do we still need this one?
Also:
Quoted 10 lines
arch/arm/mach-omap2/cclock44xx_data.c line 57
Quoted 10 lines
arch/arm/mach-omap2/cclock44xx_data.c +2
-0@@ -53,6 +53,12 @@*/ #define OMAP4_DPLL_ABE_DEFFREQ 98304000 +/* +* OMAP4450 TRM Rev X, section "3.6.3.9.5 DPLL_USB Preferred Settings"
4450?
- Paul
Quoted 15 lines · Paul Walmsley
Hi Roger,
Quoted 11 lines · Roger Quadros
+Paul
Quoted 8 lines · Roger Quadros
If the bootloader doesn't configure USB DPLL (e.g. in u-boot, disable
CONFIG_USB_EHCI_OMAP), then we get all sorts of problems like
- division by zero errors at boot [1]
- USB DPLL fails to enter locked state
- USB EHCI Host is non functional
- Device can't enter OFF mode
Quoted 3 lines
Quoted 1 line
Quoted 1 line
Initializing the USB DPLL fixes all these issues.
Looks like I may have lost track of this - do we still need this one?
No, this is already in with the typo fix. Thanks.
Quoted 11 lines
Also:
Quoted 8 lines
Quoted 8 lines
arch/arm/mach-omap2/cclock44xx_data.c +0
-0@@ -53,6 +53,12 @@*/ #define OMAP4_DPLL_ABE_DEFFREQ 98304000
Quoted 4 lines
Quoted 2 lines
arch/arm/mach-omap2/cclock44xx_data.c line 57
Quoted 2 lines
arch/arm/mach-omap2/cclock44xx_data.c +2
-0+/* +* OMAP4450 TRM Rev X, section "3.6.3.9.5 DPLL_USB Preferred Settings" 4450?
cheers,
-roger