musb: am335x: disable bulk split-combine feature
PATCH 1/1 musb: am335x: disable bulk split-combine feature
On TI AM335x devices, MUSB has bulk split/combine feature enabled in the ConfigData register, but the current MUSB driver does not support it yet. Therefore, disable the feature for now, until the driver adds the support.
One usecase which is broken because of this feature is that Ether gadget stops working in Fullspeed mode (by un-defining CONFIG_USB_GADGET_DUALSPEED)
After desabled this feature, MUSB driver send packets in proper size (no more than 64 bytes) in Fullspeed mode.
This has been validated with Ether gadget in Fullspeed mode on AM335x EVM.
--- drivers/usb/musb-new/musb_core.c | 5 +++++ include/configs/am335x_evm.h | 1 + 2 files changed, 6 insertions(+)
drivers/usb/musb-new/musb_core.c +5 -0
@@ -1421,6 +1421,7 @@ static int __devinit musb_core_init(u16 musb_type, struct musb *musb)strcat (aInfo,", dyn FIFOs" ); musb->dyn_fifo = true; } +#ifndef CONFIG_MUSB_DISABLE_BULK_COMBINE_SPLIT if (reg &MUSB_CONFIGDATA_MPRXE ) {strcat (aInfo,", bulk combine" ); musb->bulk_combine = true;
@@ -1429,6 +1430,10 @@ static int __devinit musb_core_init(u16 musb_type, struct musb *musb)strcat (aInfo,", bulk split" ); musb->bulk_split = true; } +#else + musb->bulk_combine = false; + musb->bulk_split = false; +#endif if (reg &MUSB_CONFIGDATA_HBRXE ) {strcat (aInfo,", HB-ISO Rx" ); musb->hb_iso_rx = true;
include/configs/am335x_evm.h +1 -0
@@ -450,6 +450,7 @@#define CONFIG_ARCH_MISC_INIT #define CONFIG_MUSB_GADGET #define CONFIG_MUSB_PIO_ONLY +#define CONFIG_MUSB_DISABLE_BULK_COMBINE_SPLIT #define CONFIG_USB_GADGET_DUALSPEED #define CONFIG_USB_GADGET_VBUS_DRAW 2#define CONFIG_MUSB_HOST
Signature · 1 line
1.7.9.5
PATCH 1/1 musb: set MUSB speed based on CONFIG
Do not config MUSB to highspeed mode if CONFIG_USB_GADGET_DUALSPEED is not set, in which case Ether gadget only operates in fullspeed.
--- drivers/usb/musb-new/musb_core.c | 2 ++ drivers/usb/musb-new/musb_uboot.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-)
drivers/usb/musb-new/musb_core.c +2 -0
@@ -943,7 +943,9 @@ void musb_start(struct musb *musb)/* put into basic highspeed mode and start session */ musb_writeb (regs,MUSB_POWER ,MUSB_POWER_ISOUPDATE +#ifdef CONFIG_USB_GADGET_DUALSPEED |MUSB_POWER_HSENAB +#endif/* ENSUSPEND wedges tusb */ /* | MUSB_POWER_ENSUSPEND */ );
drivers/usb/musb-new/musb_uboot.c +1 -1
@@ -174,7 +174,7 @@ int usb_gadget_register_driver(struct usb_gadget_driver *driver) {int ret; -if (!driver || driver->speed <USB_SPEED_HIGH || !driver->bind || +if (!driver || driver->speed <USB_SPEED_FULL || !driver->bind || !driver->setup) {printf ("bad parameter.\n" );return -EINVAL ;
Signature · 1 line
1.7.9.5
[U-Boot] musb: set MUSB speed based on CONFIG
Quoted 5 lines · Bin Liu
Do not config MUSB to highspeed mode if
CONFIG_USB_GADGET_DUALSPEEDis not set, in which case Ether gadget only operates in fullspeed.Reviewed-by Tom Rini <[email protected]>Signed-off-by Bin Liu <[email protected]>
Applied to u-boot-ti/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130408/1a2deced/attachment.pgp>
Quoted 9 lines · Bin Liu
On TI AM335x devices, MUSB has bulk split/combine feature enabled in the ConfigData register, but the current MUSB driver does not support it yet. Therefore, disable the feature for now, until the driver adds the support.
One usecase which is broken because of this feature is that Ether gadget stops working in Fullspeed mode (by un-defining
CONFIG_USB_GADGET_DUALSPEED)
Quoted 7 lines
After desabled this feature, MUSB driver send packets in proper size (no more than 64 bytes) in Fullspeed mode.
This has been validated with Ether gadget in Fullspeed mode on AM335x EVM.
Signed-off-by Bin Liu <[email protected]>
Applied to u-boot-ti/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130408/8bea7571/attachment.pgp>