Skip to contentSkip to conversation

arm: mvebu: Fix pinctrl for Armada 370 Mirabox SDIO port.

PATCH New Ryan Press 2 participants 2 messages Mar 26, 2013 – Mar 28, 2013 Device tree bindings

lore
Share & tools
lore

Ryan Press

author
#0 lore raw

PATCH 1/1 arm: mvebu: Fix pinctrl for Armada 370 Mirabox SDIO port.

The previous configuration used the wrong "clk" pin. Without this change mv_sdio worked because the bootloader would set the pin up, but with a bootloader that does not set the pin, mv_sdio fails to detect any card.

I have tested this change using a mwifiex_sdio wireless network adapter over the SDIO interface.

---
 arch/arm/boot/dts/armada-370-mirabox.dts | 2 +-
 arch/arm/boot/dts/armada-370.dtsi        | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)
arch/arm/boot/dts/armada-370-mirabox.dts +1 -1
index dd0c57d..3234875 100644
@@ -54,7 +54,7 @@
 		};
 
 		mvsdio at d00d4000 {
-			pinctrl-0 = <&sdio_pins2>;
+			pinctrl-0 = <&sdio_pins3>;
 			pinctrl-names = "default";
 			status = "okay";
 			/*
arch/arm/boot/dts/armada-370.dtsi +6 -0
index 8188d13..a195deb 100644
@@ -59,6 +59,12 @@
 					     "mpp50", "mpp51", "mpp52";
 			      marvell,function = "sd0";
 			};
+
+			sdio_pins3: sdio-pins3 {
+			      marvell,pins = "mpp48", "mpp49", "mpp50",
+					     "mpp51", "mpp52", "mpp53";
+			      marvell,function = "sd0";
+			};
 	        };
 
 		gpio0: gpio at d0018100 {
Signature · 1 line
1.8.1.2
Applied
#1 lore raw

PATCH 1/1 arm: mvebu: Fix pinctrl for Armada 370 Mirabox SDIO port.

Quoted 5 lines · Ryan Press

The previous configuration used the wrong "clk" pin. Without this change mv_sdio worked because the bootloader would set the pin up, but with a bootloader that does not set the pin, mv_sdio fails to detect any card.

Quoted 8 lines

I have tested this change using a mwifiex_sdio wireless network adapter over the SDIO interface.

---
 arch/arm/boot/dts/armada-370-mirabox.dts | 2 +-
 arch/arm/boot/dts/armada-370.dtsi        | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)

Applied to mvebu/fixes

I changed the commit message to wrap at the appropriate width.

thx,

Jason.