Skip to contentSkip to conversation

ARM: mx28: add dma channels for all auarts

PATCH In review Eric Bénard 2 participants 3 messages Apr 19, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: mx28: add dma channels for all auarts

Only auart0 was filled.
Tested on a custom i.MX283 board for ttyAPP1/2/3/4.

---
 arch/arm/boot/dts/imx28.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/imx28.dtsi +4 -0
index 25f2243..15933ed 100644
@@ -886,6 +886,7 @@
 				compatible = "fsl,imx28-auart", "fsl,imx23-auart";
 				reg = <0x8006c000 0x2000>;
 				interrupts = <113 72 73>;
+				fsl,auart-dma-channel = <10 11>;
 				clocks = <&clks 45>;
 				status = "disabled";
 			};
@@ -894,6 +895,7 @@
 				compatible = "fsl,imx28-auart", "fsl,imx23-auart";
 				reg = <0x8006e000 0x2000>;
 				interrupts = <114 74 75>;
+				fsl,auart-dma-channel = <12 13>;
 				clocks = <&clks 45>;
 				status = "disabled";
 			};
@@ -902,6 +904,7 @@
 				compatible = "fsl,imx28-auart", "fsl,imx23-auart";
 				reg = <0x80070000 0x2000>;
 				interrupts = <115 76 77>;
+				fsl,auart-dma-channel = <14 15>;
 				clocks = <&clks 45>;
 				status = "disabled";
 			};
@@ -910,6 +913,7 @@
 				compatible = "fsl,imx28-auart", "fsl,imx23-auart";
 				reg = <0x80072000 0x2000>;
 				interrupts = <116 78 79>;
+				fsl,auart-dma-channel = <0 1>;
 				clocks = <&clks 45>;
 				status = "disabled";
 			};
Signature · 1 line
1.7.11.7
reviewer
#1 lore raw

Hi Eric,

Quoted 13 lines · Eric B?nard

Only auart0 was filled.
Tested on a custom i.MX283 board for ttyAPP1/2/3/4.

---
 arch/arm/boot/dts/imx28.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/imx28.dtsi +0 -0
index 25f2243..15933ed 100644

arch/arm/boot/dts/imx28.dtsi line 889

Quoted 4 lines
arch/arm/boot/dts/imx28.dtsi +1 -0
@@ -886,6 +886,7 @@
                                compatible = "fsl,imx28-auart", "fsl,imx23-auart";
                                reg = <0x8006c000 0x2000>;
                                interrupts = <113 72 73>;
+                               fsl,auart-dma-channel = <10 11>;

Now we use the generic 'dmas' binding to passing such information.

If you look at linux-next tree these UART dma channels are already been passed via the new 'dmas' method:

			auart1: serial at 8006c000 {
				compatible = "fsl,imx28-auart", "fsl,imx23-auart";
				reg = <0x8006c000 0x2000>;
				interrupts = <113 72 73>;
				dmas = <&dma_apbx 10>, <&dma_apbx 11>;
				dma-names = "rx", "tx";
				clocks = <&clks 45>;
				status = "disabled";
			};
#2 lore raw

Hi Fabio,

Le Fri, 19 Apr 2013 12:26:33 -0300,
Fabio Estevam <[email protected]> a ?crit :

Quoted 24 lines · Eric B?nard
Quoted 13 lines

Only auart0 was filled.
Tested on a custom i.MX283 board for ttyAPP1/2/3/4.

---
 arch/arm/boot/dts/imx28.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/imx28.dtsi +0 -0
index 25f2243..15933ed 100644

arch/arm/boot/dts/imx28.dtsi line 889

Quoted 4 lines
arch/arm/boot/dts/imx28.dtsi +1 -0
@@ -886,6 +886,7 @@
                                compatible = "fsl,imx28-auart", "fsl,imx23-auart";
                                reg = <0x8006c000 0x2000>;
                                interrupts = <113 72 73>;
+                               fsl,auart-dma-channel = <10 11>;

Now we use the generic 'dmas' binding to passing such information.

If you look at linux-next tree these UART dma channels are already been passed via the new 'dmas' method:

Quoted 9 lines
			auart1: serial at 8006c000 {
				compatible = "fsl,imx28-auart", "fsl,imx23-auart";
				reg = <0x8006c000 0x2000>;
				interrupts = <113 72 73>;
				dmas = <&dma_apbx 10>, <&dma_apbx 11>;
				dma-names = "rx", "tx";
				clocks = <&clks 45>;
				status = "disabled";
			};

OK so forget my patch it was against 3.9-rc

Eric