clk: bcm63xx-gate: add BCM6318 support
Subsystems (2)
cover clk: bcm63xx-gate: add BCM6318 support
Add support for the gated clock controllers found on the BCM6318.
Álvaro Fernández Rojas (2):
dt-bindings: clock: bcm63xx: add 6318 gated clock bindings
clk: bcm63xx-gate: add BCM6318 support
.../bindings/clock/brcm,bcm63xx-clocks.txt | 2 + drivers/clk/bcm/clk-bcm63xx-gate.c | 44 +++++++++++++++++++ 2 files changed, 46 insertions(+)
Signature · 1 line
2.26.2
PATCH 1/2 dt-bindings: clock: bcm63xx: add 6318 gated clock bindings
Add BCM6318 to the binding documentation for the gated clock controllers found on BCM63xx SoCs.
--- Documentation/devicetree/bindings/clock/brcm,bcm63xx-clocks.txt | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/clock/brcm,bcm63xx-clocks.txt +2 -0
@@ -3,6 +3,8 @@ Gated Clock Controller Bindings for MIPS based BCM63XX SoCs Required properties: - compatible: must be one of: "brcm,bcm3368-clocks" + "brcm,bcm6318-clocks" + "brcm,bcm6318-ubus-clocks" "brcm,bcm6328-clocks" "brcm,bcm6358-clocks" "brcm,bcm6362-clocks"
Signature · 1 line
2.26.2
Re: [PATCH 1/2] dt-bindings: clock: bcm63xx: add 6318 gated clock bindings
Quoted 4 lines · Álvaro Fernández Rojas
Add BCM6318 to the binding documentation for the gated clock controllers found on BCM63xx SoCs.
Signed-off-by Álvaro Fernández Rojas <[email protected]>
Signature · 6 lines
Florian _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH 2/2 clk: bcm63xx-gate: add BCM6318 support
In reply to Álvaro Fernández RojasAdd support for the gated clock controllers found on the BCM6318.
--- drivers/clk/bcm/clk-bcm63xx-gate.c | 44 ++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+)
drivers/clk/bcm/clk-bcm63xx-gate.c +44 -0
@@ -40,6 +40,48 @@ static const struct clk_bcm63xx_table_entry bcm3368_clocks[] = { { }, }; +static const struct clk_bcm63xx_table_entry bcm6318_clocks[] = { + { .name ="adsl_asb" , .bit =0 , }, + { .name ="usb_asb" , .bit =1 , }, + { .name ="mips_asb" , .bit =2 , }, + { .name ="pcie_asb" , .bit =3 , }, + { .name ="phymips_asb" , .bit =4 , }, + { .name ="robosw_asb" , .bit =5 , }, + { .name ="sar_asb" , .bit =6 , }, + { .name ="sdr_asb" , .bit =7 , }, + { .name ="swreg_asb" , .bit =8 , }, + { .name ="periph_asb" , .bit =9 , }, + { .name ="cpubus160" , .bit =10 , }, + { .name ="adsl" , .bit =11 , }, + { .name ="sar124" , .bit =12 , }, + { .name ="mips" , .bit =13 , .flags =CLK_IS_CRITICAL , }, + { .name ="pcie" , .bit =14 , }, + { .name ="robosw250" , .bit =16 , }, + { .name ="robosw025" , .bit =17 , }, + { .name ="sdr" , .bit =19 , .flags =CLK_IS_CRITICAL , }, + { .name ="usb" , .bit =20 , }, + { .name ="hsspi" , .bit =25 , }, + { .name ="pcie25" , .bit =27 , }, + { .name ="phymips" , .bit =28 , }, + { .name ="afe" , .bit =29 , }, + { .name ="qproc" , .bit =30 , }, + { }, +}; + +static const struct clk_bcm63xx_table_entry bcm6318_ubus_clocks[] = { + { .name ="adsl-ubus" , .bit =0 , }, + { .name ="arb-ubus" , .bit =1 , .flags =CLK_IS_CRITICAL , }, + { .name ="mips-ubus" , .bit =2 , .flags =CLK_IS_CRITICAL , }, + { .name ="pcie-ubus" , .bit =3 , }, + { .name ="periph-ubus" , .bit =4 , .flags =CLK_IS_CRITICAL , }, + { .name ="phymips-ubus" , .bit =5 , }, + { .name ="robosw-ubus" , .bit =6 , }, + { .name ="sar-ubus" , .bit =7 , }, + { .name ="sdr-ubus" , .bit =8 , }, + { .name ="usb-ubus" , .bit =9 , }, + { }, +}; +static const struct clk_bcm63xx_table_entry bcm6328_clocks[] = { { .name ="phy_mips" , .bit =0 , }, { .name ="adsl_qproc" , .bit =1 , },
@@ -217,6 +259,8 @@ static int clk_bcm63xx_remove(struct platform_device *pdev)static const struct of_device_id clk_bcm63xx_dt_ids[] = { { .compatible ="brcm,bcm3368-clocks" , .data = &bcm3368_clocks, }, + { .compatible ="brcm,bcm6318-clocks" , .data = &bcm6318_clocks, }, + { .compatible ="brcm,bcm6318-ubus-clocks" , .data = &bcm6318_ubus_clocks, }, { .compatible ="brcm,bcm6328-clocks" , .data = &bcm6328_clocks, }, { .compatible ="brcm,bcm6358-clocks" , .data = &bcm6358_clocks, }, { .compatible ="brcm,bcm6362-clocks" , .data = &bcm6362_clocks, },
Signature · 1 line
2.26.2
Quoted 4 lines · Álvaro Fernández Rojas
drivers/clk/bcm/clk-bcm63xx-gate.c +4
-0+static const struct clk_bcm63xx_table_entry bcm6318_clocks[] = { + { .name ="adsl_asb" , .bit =0 , }, + { .name ="usb_asb" , .bit =1 , }, + { .name ="mips_asb" , .bit =2 , },
drivers/clk/bcm/clk-bcm63xx-gate.c static const struct clk_bcm63xx_table_entry bcm3368_clocks[] = { · line 56
Quoted 10 lines
drivers/clk/bcm/clk-bcm63xx-gate.c +10
-0+ { .name = "pcie_asb", .bit = 3, }, + { .name = "phymips_asb", .bit = 4, }, + { .name = "robosw_asb", .bit = 5, }, + { .name = "sar_asb", .bit = 6, }, + { .name = "sdr_asb", .bit = 7, }, + { .name = "swreg_asb", .bit = 8, }, + { .name = "periph_asb", .bit = 9, }, + { .name = "cpubus160", .bit = 10, }, + { .name = "adsl", .bit = 11, }, + { .name = "sar124", .bit = 12, },
Nit: this should be sar125
drivers/clk/bcm/clk-bcm63xx-gate.c static const struct clk_bcm63xx_table_entry bcm3368_clocks[] = { · line 62
Quoted 6 lines
drivers/clk/bcm/clk-bcm63xx-gate.c +6
-0+ { .name = "mips", .bit = 13, .flags = CLK_IS_CRITICAL, }, + { .name = "pcie", .bit = 14, }, + { .name = "robosw250", .bit = 16, }, + { .name = "robosw025", .bit = 17, }, + { .name = "sdr", .bit = 19, .flags = CLK_IS_CRITICAL, }, + { .name = "usb", .bit = 20, },
This should probably be "usbd" to indicate this is the USB device clock (not host)
With that fixed:
Signature · 1 line
Florian
Hi Florian,
Quoted 5 lines · Florian Fainelli
On 6/9/2020 4:30 AM, Álvaro Fernández Rojas wrote:
Quoted 16 lines
Quoted 4 lines
drivers/clk/bcm/clk-bcm63xx-gate.c +4
-0+static const struct clk_bcm63xx_table_entry bcm6318_clocks[] = { + { .name ="adsl_asb" , .bit =0 , }, + { .name ="usb_asb" , .bit =1 , }, + { .name ="mips_asb" , .bit =2 , },drivers/clk/bcm/clk-bcm63xx-gate.c static const struct clk_bcm63xx_table_entry bcm3368_clocks[] = { · line 56
Quoted 10 lines
drivers/clk/bcm/clk-bcm63xx-gate.c +10
-0+ { .name = "pcie_asb", .bit = 3, }, + { .name = "phymips_asb", .bit = 4, }, + { .name = "robosw_asb", .bit = 5, }, + { .name = "sar_asb", .bit = 6, }, + { .name = "sdr_asb", .bit = 7, }, + { .name = "swreg_asb", .bit = 8, }, + { .name = "periph_asb", .bit = 9, }, + { .name = "cpubus160", .bit = 10, }, + { .name = "adsl", .bit = 11, }, + { .name = "sar124", .bit = 12, },Nit: this should be sar125
Nice catch, I will fix this in v2.
Quoted 10 lines
drivers/clk/bcm/clk-bcm63xx-gate.c static const struct clk_bcm63xx_table_entry bcm3368_clocks[] = { · line 62
Quoted 7 lines
drivers/clk/bcm/clk-bcm63xx-gate.c +6
-0+ { .name = "mips", .bit = 13, .flags = CLK_IS_CRITICAL, }, + { .name = "pcie", .bit = 14, }, + { .name = "robosw250", .bit = 16, }, + { .name = "robosw025", .bit = 17, }, + { .name = "sdr", .bit = 19, .flags = CLK_IS_CRITICAL, }, + { .name = "usb", .bit = 20, },This should probably be "usbd" to indicate this is the USB device clock (not host)
Ok, I will change it. I got confused by the fact that both (usbd and usbh) were present on 6318_map_part.h:
#define USBD_CLK_EN (1 << 20)
#define USBH_CLK_EN (1 << 20)
Quoted 6 lines
With that fixed:
Reviewed-by Florian Fainelli <[email protected]>Signature · 1 line
Florian
Hi,
Quoted 35 lines · Álvaro Fernández Rojas
Hi Florian,
Quoted 20 lines · Florian Fainelli
Quoted 4 lines · Álvaro Fernández Rojas
drivers/clk/bcm/clk-bcm63xx-gate.c +4
-0+static const struct clk_bcm63xx_table_entry bcm6318_clocks[] = { + { .name ="adsl_asb" , .bit =0 , }, + { .name ="usb_asb" , .bit =1 , }, + { .name ="mips_asb" , .bit =2 , },drivers/clk/bcm/clk-bcm63xx-gate.c static const struct clk_bcm63xx_table_entry bcm3368_clocks[] = { · line 56
Quoted 10 lines
drivers/clk/bcm/clk-bcm63xx-gate.c +10
-0+ { .name = "pcie_asb", .bit = 3, }, + { .name = "phymips_asb", .bit = 4, }, + { .name = "robosw_asb", .bit = 5, }, + { .name = "sar_asb", .bit = 6, }, + { .name = "sdr_asb", .bit = 7, }, + { .name = "swreg_asb", .bit = 8, }, + { .name = "periph_asb", .bit = 9, }, + { .name = "cpubus160", .bit = 10, }, + { .name = "adsl", .bit = 11, }, + { .name = "sar124", .bit = 12, },Quoted 1 line
Nit: this should be sar125
Nice catch, I will fix this in v2.
Quoted 8 lines
Quoted 7 lines
drivers/clk/bcm/clk-bcm63xx-gate.c +6
-0+ { .name = "mips", .bit = 13, .flags = CLK_IS_CRITICAL, }, + { .name = "pcie", .bit = 14, }, + { .name = "robosw250", .bit = 16, }, + { .name = "robosw025", .bit = 17, }, + { .name = "sdr", .bit = 19, .flags = CLK_IS_CRITICAL, }, + { .name = "usb", .bit = 20, },
Quoted 6 lines
Quoted 2 lines
This should probably be "usbd" to indicate this is the USB device clock (not host)
Ok, I will change it. I got confused by the fact that both (usbd and usbh) were present on
6318_map_part.h:
#defineUSBD_CLK_EN(1 << 20)
#defineUSBH_CLK_EN(1 << 20)
Is there a datasheet to verify that?
Quoted 8 lines
Quoted 7 lines
With that fixed:
Reviewed-by Florian Fainelli <[email protected]>--
Florian
Quoted 39 lines · Philippe Mathieu-Daudé
Hi,
Quoted 35 lines · Álvaro Fernández Rojas
Hi Florian,
Quoted 20 lines · Florian Fainelli
Quoted 4 lines · Álvaro Fernández Rojas
drivers/clk/bcm/clk-bcm63xx-gate.c +4
-0+static const struct clk_bcm63xx_table_entry bcm6318_clocks[] = { + { .name ="adsl_asb" , .bit =0 , }, + { .name ="usb_asb" , .bit =1 , }, + { .name ="mips_asb" , .bit =2 , },drivers/clk/bcm/clk-bcm63xx-gate.c static const struct clk_bcm63xx_table_entry bcm3368_clocks[] = { · line 56
Quoted 10 lines
drivers/clk/bcm/clk-bcm63xx-gate.c +10
-0+ { .name = "pcie_asb", .bit = 3, }, + { .name = "phymips_asb", .bit = 4, }, + { .name = "robosw_asb", .bit = 5, }, + { .name = "sar_asb", .bit = 6, }, + { .name = "sdr_asb", .bit = 7, }, + { .name = "swreg_asb", .bit = 8, }, + { .name = "periph_asb", .bit = 9, }, + { .name = "cpubus160", .bit = 10, }, + { .name = "adsl", .bit = 11, }, + { .name = "sar124", .bit = 12, },Quoted 1 line
Nit: this should be sar125
Nice catch, I will fix this in v2.
Quoted 8 lines
Quoted 7 lines
drivers/clk/bcm/clk-bcm63xx-gate.c +6
-0+ { .name = "mips", .bit = 13, .flags = CLK_IS_CRITICAL, }, + { .name = "pcie", .bit = 14, }, + { .name = "robosw250", .bit = 16, }, + { .name = "robosw025", .bit = 17, }, + { .name = "sdr", .bit = 19, .flags = CLK_IS_CRITICAL, }, + { .name = "usb", .bit = 20, },
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
This should probably be "usbd" to indicate this is the USB device clock (not host)
Ok, I will change it. I got confused by the fact that both (usbd and usbh) were present on
6318_map_part.h:
#defineUSBD_CLK_EN(1 << 20)
#defineUSBH_CLK_EN(1 << 20)Is there a datasheet to verify that?
Not a public one, but I can confirm this is correct given the internal datasheet.
Signature · 1 line
Florian
Quoted 43 lines · Florian Fainelli
Quoted 42 lines · Philippe Mathieu-Daudé
Hi,
Quoted 38 lines · Álvaro Fernández Rojas
Hi Florian,
Quoted 20 lines · Florian Fainelli
Quoted 4 lines · Álvaro Fernández Rojas
drivers/clk/bcm/clk-bcm63xx-gate.c +4
-0+static const struct clk_bcm63xx_table_entry bcm6318_clocks[] = { + { .name ="adsl_asb" , .bit =0 , }, + { .name ="usb_asb" , .bit =1 , }, + { .name ="mips_asb" , .bit =2 , },drivers/clk/bcm/clk-bcm63xx-gate.c static const struct clk_bcm63xx_table_entry bcm3368_clocks[] = { · line 56
Quoted 10 lines
drivers/clk/bcm/clk-bcm63xx-gate.c +10
-0+ { .name = "pcie_asb", .bit = 3, }, + { .name = "phymips_asb", .bit = 4, }, + { .name = "robosw_asb", .bit = 5, }, + { .name = "sar_asb", .bit = 6, }, + { .name = "sdr_asb", .bit = 7, }, + { .name = "swreg_asb", .bit = 8, }, + { .name = "periph_asb", .bit = 9, }, + { .name = "cpubus160", .bit = 10, }, + { .name = "adsl", .bit = 11, }, + { .name = "sar124", .bit = 12, },Quoted 1 line
Nit: this should be sar125
Nice catch, I will fix this in v2.
Quoted 10 lines
drivers/clk/bcm/clk-bcm63xx-gate.c static const struct clk_bcm63xx_table_entry bcm3368_clocks[] = { · line 62
Quoted 7 lines
drivers/clk/bcm/clk-bcm63xx-gate.c +6
-0+ { .name = "mips", .bit = 13, .flags = CLK_IS_CRITICAL, }, + { .name = "pcie", .bit = 14, }, + { .name = "robosw250", .bit = 16, }, + { .name = "robosw025", .bit = 17, }, + { .name = "sdr", .bit = 19, .flags = CLK_IS_CRITICAL, }, + { .name = "usb", .bit = 20, },This should probably be "usbd" to indicate this is the USB device clock (not host)
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Ok, I will change it. I got confused by the fact that both (usbd and usbh) were present on
6318_map_part.h:
#defineUSBD_CLK_EN(1 << 20)
#defineUSBH_CLK_EN(1 << 20)Is there a datasheet to verify that?
Not a public one, but I can confirm this is correct given the internal datasheet.
OK thank you Florian.
Quoted 2 lines
--
Florian
v2 cover clk: bcm63xx-gate: add BCM6318 support
In reply to Álvaro Fernández RojasAdd support for the gated clock controllers found on the BCM6318.
Álvaro Fernández Rojas (2):
dt-bindings: clock: bcm63xx: add 6318 gated clock bindings
clk: bcm63xx-gate: add BCM6318 support
.../bindings/clock/brcm,bcm63xx-clocks.txt | 2 + drivers/clk/bcm/clk-bcm63xx-gate.c | 44 +++++++++++++++++++ 2 files changed, 46 insertions(+)
Signature · 1 line
2.26.2
PATCH v2 1/2 dt-bindings: clock: bcm63xx: add 6318 gated clock bindings
Add BCM6318 to the binding documentation for the gated clock controllers found on BCM63xx SoCs.
---
v2: no changes.
Documentation/devicetree/bindings/clock/brcm,bcm63xx-clocks.txt | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/clock/brcm,bcm63xx-clocks.txt +2 -0
@@ -3,6 +3,8 @@ Gated Clock Controller Bindings for MIPS based BCM63XX SoCs Required properties: - compatible: must be one of: "brcm,bcm3368-clocks" + "brcm,bcm6318-clocks" + "brcm,bcm6318-ubus-clocks" "brcm,bcm6328-clocks" "brcm,bcm6358-clocks" "brcm,bcm6362-clocks"
Signature · 1 line
2.26.2
Re: [PATCH v2 1/2] dt-bindings: clock: bcm63xx: add 6318 gated clock bindings
Quoted 11 lines · Álvaro Fernández Rojas
Add BCM6318 to the binding documentation for the gated clock controllers found on BCM63xx SoCs.
Signed-off-by Álvaro Fernández Rojas <[email protected]>Reviewed-by Florian Fainelli <[email protected]>---
v2: no changes.Documentation/devicetree/bindings/clock/brcm,bcm63xx-clocks.txt | 2 ++ 1 file changed, 2 insertions(+)
Re: [PATCH v2 1/2] dt-bindings: clock: bcm63xx: add 6318 gated clock bindings
In reply to Álvaro Fernández RojasQuoting Álvaro Fernández Rojas (2020-06-10 07:08:57)
Quoted 6 lines
Add BCM6318 to the binding documentation for the gated clock controllers found on BCM63xx SoCs.
Signed-off-by Álvaro Fernández Rojas <[email protected]>Reviewed-by Florian Fainelli <[email protected]>---
Applied to clk-next
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v2 2/2 clk: bcm63xx-gate: add BCM6318 support
In reply to Álvaro Fernández RojasAdd support for the gated clock controllers found on the BCM6318.
---
v2: correct names for sar125 and usbd
drivers/clk/bcm/clk-bcm63xx-gate.c | 44 ++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+)
drivers/clk/bcm/clk-bcm63xx-gate.c +44 -0
@@ -40,6 +40,48 @@ static const struct clk_bcm63xx_table_entry bcm3368_clocks[] = { { }, }; +static const struct clk_bcm63xx_table_entry bcm6318_clocks[] = { + { .name ="adsl_asb" , .bit =0 , }, + { .name ="usb_asb" , .bit =1 , }, + { .name ="mips_asb" , .bit =2 , }, + { .name ="pcie_asb" , .bit =3 , }, + { .name ="phymips_asb" , .bit =4 , }, + { .name ="robosw_asb" , .bit =5 , }, + { .name ="sar_asb" , .bit =6 , }, + { .name ="sdr_asb" , .bit =7 , }, + { .name ="swreg_asb" , .bit =8 , }, + { .name ="periph_asb" , .bit =9 , }, + { .name ="cpubus160" , .bit =10 , }, + { .name ="adsl" , .bit =11 , }, + { .name ="sar125" , .bit =12 , }, + { .name ="mips" , .bit =13 , .flags =CLK_IS_CRITICAL , }, + { .name ="pcie" , .bit =14 , }, + { .name ="robosw250" , .bit =16 , }, + { .name ="robosw025" , .bit =17 , }, + { .name ="sdr" , .bit =19 , .flags =CLK_IS_CRITICAL , }, + { .name ="usbd" , .bit =20 , }, + { .name ="hsspi" , .bit =25 , }, + { .name ="pcie25" , .bit =27 , }, + { .name ="phymips" , .bit =28 , }, + { .name ="afe" , .bit =29 , }, + { .name ="qproc" , .bit =30 , }, + { }, +}; + +static const struct clk_bcm63xx_table_entry bcm6318_ubus_clocks[] = { + { .name ="adsl-ubus" , .bit =0 , }, + { .name ="arb-ubus" , .bit =1 , .flags =CLK_IS_CRITICAL , }, + { .name ="mips-ubus" , .bit =2 , .flags =CLK_IS_CRITICAL , }, + { .name ="pcie-ubus" , .bit =3 , }, + { .name ="periph-ubus" , .bit =4 , .flags =CLK_IS_CRITICAL , }, + { .name ="phymips-ubus" , .bit =5 , }, + { .name ="robosw-ubus" , .bit =6 , }, + { .name ="sar-ubus" , .bit =7 , }, + { .name ="sdr-ubus" , .bit =8 , }, + { .name ="usb-ubus" , .bit =9 , }, + { }, +}; +static const struct clk_bcm63xx_table_entry bcm6328_clocks[] = { { .name ="phy_mips" , .bit =0 , }, { .name ="adsl_qproc" , .bit =1 , },
@@ -217,6 +259,8 @@ static int clk_bcm63xx_remove(struct platform_device *pdev)static const struct of_device_id clk_bcm63xx_dt_ids[] = { { .compatible ="brcm,bcm3368-clocks" , .data = &bcm3368_clocks, }, + { .compatible ="brcm,bcm6318-clocks" , .data = &bcm6318_clocks, }, + { .compatible ="brcm,bcm6318-ubus-clocks" , .data = &bcm6318_ubus_clocks, }, { .compatible ="brcm,bcm6328-clocks" , .data = &bcm6328_clocks, }, { .compatible ="brcm,bcm6358-clocks" , .data = &bcm6358_clocks, }, { .compatible ="brcm,bcm6362-clocks" , .data = &bcm6362_clocks, },
Signature · 1 line
2.26.2
Quoting Álvaro Fernández Rojas (2020-06-10 07:08:58)
Quoted 5 lines
Add support for the gated clock controllers found on the BCM6318.
Signed-off-by Álvaro Fernández Rojas <[email protected]>Reviewed-by Florian Fainelli <[email protected]>---
Applied to clk-next
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Stephen Boyd
maintainerQuoted 10 lines
Add support for the gated clock controllers found on the BCM6318.
Álvaro Fernández Rojas (2):
dt-bindings: clock: bcm63xx: add 6318 gated clock bindings
clk: bcm63xx-gate: add BCM6318 support.../bindings/clock/brcm,bcm63xx-clocks.txt | 2 + drivers/clk/bcm/clk-bcm63xx-gate.c | 44 +++++++++++++++++++ 2 files changed, 46 insertions(+)
Sorry please don't send these in reply to the original patch series. I have a hard time finding new patch series in my 'thread summary' view.