Skip to contentSkip to conversation

ARM: dts: omap4-panda: Update the twl6040 gpio to macro definition

PATCH In review Dan Murphy 3 participants 3 messages May 31, 2013 – Jun 3, 2013 Device tree bindings

lore
Share & tools
lore

Dan Murphy

author
#0 lore raw

PATCH 1/1 ARM: dts: omap4-panda: Update the twl6040 gpio to macro definition

Update the dt property ti,audpwron-gpio to use the gpio macro definition for GPIO_ACTIVE_HIGH.

---
 arch/arm/boot/dts/omap4-panda-common.dtsi |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/boot/dts/omap4-panda-common.dtsi +1 -1
index 800fa4e..00cbaa5 100644
@@ -190,7 +190,7 @@
 		/* IRQ# = 119 */
 		interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>; /* IRQ_SYS_2N cascaded to gic */
 		interrupt-parent = <&gic>;
-		ti,audpwron-gpio = <&gpio4 31 0>;  /* gpio line 127 */
+		ti,audpwron-gpio = <&gpio4 31 GPIO_ACTIVE_HIGH>;  /* gpio line 127 */
 
 		vio-supply = <&v1v8>;
 		v2v1-supply = <&v2v1>;
Signature · 1 line
1.7.5.4
Reviewed-by on v1 1/1
#1 lore raw

Hello Dan,

Quoted 14 lines · Dan Murphy

Update the dt property ti,audpwron-gpio to use the gpio macro definition for GPIO_ACTIVE_HIGH.

---
  arch/arm/boot/dts/omap4-panda-common.dtsi |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/boot/dts/omap4-panda-common.dtsi +0 -0
index 800fa4e..00cbaa5 100644

arch/arm/boot/dts/omap4-panda-common.dtsi line 196

Quoted 8 lines
arch/arm/boot/dts/omap4-panda-common.dtsi +1 -1
@@ -190,7 +190,7 @@
  		/* IRQ# = 119 */
  		interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>; /* IRQ_SYS_2N cascaded to gic */
  		interrupt-parent = <&gic>;
-		ti,audpwron-gpio = <&gpio4 31 0>;  /* gpio line 127 */
+		ti,audpwron-gpio = <&gpio4 31 GPIO_ACTIVE_HIGH>;  /* gpio line 127 */
 
  		vio-supply = <&v1v8>;
  		v2v1-supply = <&v2v1>;

I missed it during the conversion, thank you.

#2 lore raw

Hi Dan,

Quoted 25 lines · Florian Vaussard

Hello Dan,

Quoted 22 lines · Dan Murphy

Update the dt property ti,audpwron-gpio to use the gpio macro definition for GPIO_ACTIVE_HIGH.

---
  arch/arm/boot/dts/omap4-panda-common.dtsi |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/boot/dts/omap4-panda-common.dtsi +0 -0
index 800fa4e..00cbaa5 100644
@@ -190,7 +190,7 @@
          /* IRQ# = 119 */
          interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>; /*

IRQ_SYS_2N cascaded to gic */

          interrupt-parent = <&gic>;
arch/arm/boot/dts/omap4-panda-common.dtsi +1 -1
-        ti,audpwron-gpio = <&gpio4 31 0>;  /* gpio line 127 */
+        ti,audpwron-gpio = <&gpio4 31 GPIO_ACTIVE_HIGH>;  /* gpio

line 127 */

Quoted 7 lines
Quoted 3 lines
          vio-supply = <&v1v8>;
          v2v1-supply = <&v2v1>;

I missed it during the conversion, thank you.

I've just applied it with Florian's Reviewed-by.

Thanks,
Benoit