samba: remove /var/lock and /var/run from package
PATCH v2 1/1 samba: remove /var/lock and /var/run from package
The /var/lock and /var/run directories are already created by base-files.
--- meta-oe/recipes-connectivity/samba/samba_3.6.8.bb | 6 ++++++ 1 file changed, 6 insertions(+)
meta-oe/recipes-connectivity/samba/samba_3.6.8.bb +6 -0
@@ -57,3 +57,9 @@ do_configure() { do_compile () { base_do_compile } + +do_install_append() { + rmdir "${D}${localstatedir}/lock" + rmdir "${D}${localstatedir}/run" + rmdir --ignore-fail-on-non-empty "${D}${localstatedir}" +}
Signature · 1 line
1.8.3.2
Quoted 13 lines · Jonathan Liu
The
/var/lockand/var/rundirectories are already created by base-files.Signed-off-by Jonathan Liu <[email protected]>---
meta-oe/recipes-connectivity/samba/samba_3.6.8.bb | 6 ++++++1 file changed, 6 insertions(+)meta-oe/recipes-connectivity/samba/samba_3.6.8.bb +0
-0
meta-oe/recipes-connectivity/samba/samba_3.6.8.bb do_configure() { · line 64
Quoted 8 lines
meta-oe/recipes-connectivity/samba/samba_3.6.8.bb +5
-0@@ -57,3 +57,9 @@ do_configure() { do_compile () { base_do_compile } + +do_install_append() { + rmdir "${D}${localstatedir}/lock" + rmdir "${D}${localstatedir}/run" + rmdir --ignore-fail-on-non-empty "${D}${localstatedir}"
what is this last rmdir doing ?
Quoted 8 lines
meta-oe/recipes-connectivity/samba/samba_3.6.8.bb +1
-0+}Signature · 6 lines
1.8.3.2 _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Quoted 11 lines · Khem Raj
Quoted 8 lines · Jonathan Liu
The
/var/lockand/var/rundirectories are already created by base-files.Signed-off-by Jonathan Liu <[email protected]>---
meta-oe/recipes-connectivity/samba/samba_3.6.8.bb | 6 ++++++1 file changed, 6 insertions(+)
Quoted 15 lines
meta-oe/recipes-connectivity/samba/samba_3.6.8.bb do_configure() { · line 64
Quoted 13 lines
meta-oe/recipes-connectivity/samba/samba_3.6.8.bb +5
-0@@ -57,3 +57,9 @@ do_configure() { do_compile () { base_do_compile } + +do_install_append() { + rmdir "${D}${localstatedir}/lock" + rmdir "${D}${localstatedir}/run" + rmdir --ignore-fail-on-non-empty "${D}${localstatedir}"what is this last rmdir doing ?
It will remove the /var directory only if it is empty. In case there is nothing else in /var it's useless to have an empty /var directory.
Regards,
Jonathan
Quoted 15 lines
Quoted 10 lines
meta-oe/recipes-connectivity/samba/samba_3.6.8.bb +1
-1+} --1.8.3.2
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Quoted 7 lines · Jonathan Liu
Quoted 6 lines · Khem Raj
Quoted 3 lines · Jonathan Liu
The
/var/lockand/var/rundirectories are already created by base-files.
Quoted 6 lines
Quoted 6 lines
Review
Quoted 6 lines
Signed-off-by Jonathan Liu <[email protected]>---
meta-oe/recipes-connectivity/samba/samba_3.6.8.bb | 6 ++++++1 file changed, 6 insertions(+)(quoted diff) +0
-0
samba_3.6.8.bb
Quoted 14 lines
Quoted 6 lines
Quoted 6 lines
index a27a28c..255c0b4 100644
meta-oe/recipes-connectivity/samba/samba_3.6.8.bb +0
-0@@ -57,3 +57,9 @@ do_configure() { do_compile () { base_do_compileQuoted 8 lines
meta-oe/recipes-connectivity/samba/samba_3.6.8.bb do_configure() { · line 64
Quoted 6 lines
meta-oe/recipes-connectivity/samba/samba_3.6.8.bb +5
-0} + +do_install_append() { + rmdir "${D}${localstatedir}/lock" + rmdir "${D}${localstatedir}/run" + rmdir --ignore-fail-on-non-empty "${D}${localstatedir}"what is this last rmdir doing ?
Quoted 3 lines
It will remove the /var directory only if it is empty. In case there is nothing else in /var it's useless to have an empty /var directory.
Good. Mention it in commit message
Quoted 23 lines
Regards,
JonathanQuoted 11 lines
Quoted 10 lines
meta-oe/recipes-connectivity/samba/samba_3.6.8.bb +1
-1+} --1.8.3.2
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-develQuoted 4 lines
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel