Skip to contentSkip to conversation

samba: remove /var/run from package

PATCH Superseded Jonathan Liu 2 participants 3 messages Jul 6, 2013 – Jul 8, 2013

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 samba: remove /var/run from package

The /var/run and /var/run/lock directories are already created by base-files.

---
 meta-oe/recipes-connectivity/samba/samba_3.6.8.bb | 5 +++++
 1 file changed, 5 insertions(+)
meta-oe/recipes-connectivity/samba/samba_3.6.8.bb +5 -0
index a27a28c..6bd6644 100644
@@ -57,3 +57,8 @@ do_configure() {
 do_compile () {
     base_do_compile
 }
+
+do_install_append() {
+    rm -rf "${D}${localstatedir}/run"
+    rmdir --ignore-fail-on-non-empty "${D}${localstatedir}"
+}
Signature · 1 line
1.8.3.2
#1 lore raw
Quoted 13 lines · Jonathan Liu

The /var/run and /var/run/lock directories are already created by base-files.

---
 meta-oe/recipes-connectivity/samba/samba_3.6.8.bb | 5 +++++
 1 file changed, 5 insertions(+)
meta-oe/recipes-connectivity/samba/samba_3.6.8.bb +0 -0
index a27a28c..6bd6644 100644

meta-oe/recipes-connectivity/samba/samba_3.6.8.bb do_configure() { · line 62

Quoted 6 lines
meta-oe/recipes-connectivity/samba/samba_3.6.8.bb +3 -0
@@ -57,3 +57,8 @@ do_configure() {
 do_compile () {
     base_do_compile
 }
+
+do_install_append() {
+    rm -rf "${D}${localstatedir}/run"

Seems like lock removal is missing here.

samba-3.6.8: samba: Files/directories were installed but not shipped
/run
/run/lock

Thanks a lot for this patchset, now with libdir and infodir QA checks we'll see a lot more QA issues in world builds, so it's great to have this /run gone.

Quoted 9 lines
meta-oe/recipes-connectivity/samba/samba_3.6.8.bb +2 -0
+    rmdir --ignore-fail-on-non-empty "${D}${localstatedir}"
+}
Signature · 6 lines
1.8.3.2

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#2 lore raw
Quoted 23 lines · Martin Jansa
Quoted 13 lines · Jonathan Liu

The /var/run and /var/run/lock directories are already created by base-files.

---
 meta-oe/recipes-connectivity/samba/samba_3.6.8.bb | 5 +++++
 1 file changed, 5 insertions(+)
meta-oe/recipes-connectivity/samba/samba_3.6.8.bb +0 -0
index a27a28c..6bd6644 100644

meta-oe/recipes-connectivity/samba/samba_3.6.8.bb do_configure() { · line 62

Quoted 6 lines
meta-oe/recipes-connectivity/samba/samba_3.6.8.bb +3 -0
@@ -57,3 +57,8 @@ do_configure() {
 do_compile () {
     base_do_compile
 }
+
+do_install_append() {
+    rm -rf "${D}${localstatedir}/run"

Seems like lock removal is missing here.

Quoted 8 lines

samba-3.6.8: samba: Files/directories were installed but not shipped
/run
/run/lock

Thanks a lot for this patchset, now with libdir and infodir QA checks we'll see a lot more QA issues in world builds, so it's great to have this /run gone.

I have submitted V2 patch for samba. I haven't got around to fixing nostromo yet.

Regards,
Jonathan

Quoted 19 lines
Quoted 10 lines
meta-oe/recipes-connectivity/samba/samba_3.6.8.bb +2 -1
+    rmdir --ignore-fail-on-non-empty "${D}${localstatedir}"
+}
--

1.8.3.2

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
Martin 'JaMa' Jansa jabber: [email protected]

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel