Skip to contentSkip to conversation

video: da8xx-fb: fix 24bpp raster configuration

PATCH In review Darren Etheridge 1 participant 1 message Aug 5, 2013 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH v3 12/20 video: da8xx-fb: fix 24bpp raster configuration

Based on original patch by: Manjunathappa, Prakash <[email protected]>
and Afzal Mohammed <[email protected]>

Set only LCD_V2_TFT_24BPP_MODE bit for 24bpp and LCD_V2_TFT_24BPP_UNPACK bit along with LCD_V2_TFT_24BPP_MODE for 32bpp configuration.

Patch is tested on am335x-evm for 24bpp and da850-evm for 16bpp configurations.

v2: removes confusing fall through in case statement for pixel
depth configuration.

---
 drivers/video/da8xx-fb.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/video/da8xx-fb.c +2 -1
index 9375382..893aefe 100644
@@ -554,10 +554,11 @@ static int lcd_cfg_frame_buffer(struct da8xx_fb_par *par, u32 width, u32 height,
 		break;
 	case 24:
 		reg |= LCD_V2_TFT_24BPP_MODE;
+		break;
 	case 32:
+		reg |= LCD_V2_TFT_24BPP_MODE;
 		reg |= LCD_V2_TFT_24BPP_UNPACK;
 		break;
-
 	case 8:
 		par->palette_sz = 256 * 2;
 		break;
Signature · 1 line
1.7.0.4