Skip to content

video: da8xx-fb: driver enhance to support TI am335x SoC

Darren Etheridge linux-fbdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest20 patches 1 replyIn review
  2. v224 patches 14 repliesSuperseded
  3. v123 patches 8 repliesSuperseded

Changes in v3 from the cover letter

Address the patch authorship requirements
Pull out the DT changes into a separate series
Fix an issue where FB_MODE_HELPERS was not included in build
but is a dependency.
Include the devm_ changes and error reporting that Prabhakar Lad
had pushed a patch for,
A few more cosmetic changes
Add a patch to remove the use on inline from a number of functions

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20video: da8xx-fb: fb_check_var enhancementdrivers/video/da8xx-fb.c+18 -00 replies
2/20video: da8xx-fb: simplify lcd_resetdrivers/video/da8xx-fb.c+2 -20 replies
3/20video: da8xx-fb: use modedb helper to update vardrivers/video/da8xx-fb.c+2 -160 replies
4/20video: da8xx-fb: remove unneeded "var" initializationdrivers/video/da8xx-fb.c+1 -210 replies
5/20video: da8xx-fb: store current display informationdrivers/video/da8xx-fb.c+4 -00 replies
6/20video: da8xx-fb: store clk rate even if !CPUFREQdrivers/video/da8xx-fb.c+1 -30 replies
7/20video: da8xx-fb: pix clk and clk div handling cleanupdrivers/video/da8xx-fb.c+18 -280 replies
8/20video: da8xx-fb: store struct device *drivers/video/da8xx-fb.c+2 -00 replies
9/20video: da8xx-fb: report correct pixclockdrivers/video/da8xx-fb.c+11 -00 replies
10/20video: da8xx-fb: fb_set_par supportdrivers/video/da8xx-fb.c+47 -110 replies
11/20video: da8xx-fb: improve readability of codedrivers/video/da8xx-fb.c include/video/da8xx-fb.h+18 -110 replies
12/20video: da8xx-fb: fix 24bpp raster configurationdrivers/video/da8xx-fb.c+2 -10 replies
13/20video: da8xx-fb: enable sync lost intr for v2 ipdrivers/video/da8xx-fb.c+1 -10 replies
14/20video: da8xx-fb: use devresdrivers/video/da8xx-fb.c+8 -330 replies
15/20video: da8xx-fb: ensure non-null cfg in pdatadrivers/video/da8xx-fb.c+5 -00 replies
16/20video: da8xx-fb: reorganize panel detectiondrivers/video/da8xx-fb.c+21 -00 replies
17/20video: da8xx-fb: set upstream clock rate (if reqd)drivers/video/da8xx-fb.c+65 -200 replies
18/20video: da8xx-fb: make clock naming consistentdrivers/video/da8xx-fb.c+12 -120 replies
19/20video: da8xx-fb: let compiler decide what to inlinedrivers/video/da8xx-fb.c+8 -90 replies
20/20video: da8xx-fb: adding am33xx as dependencydrivers/video/Kconfig+5 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 00/20] video: da8xx-fb: driver enhance to support TI am335x SoC

Changes in v3:
Address the patch authorship requirements
Pull out the DT changes into a separate series
Fix an issue where FB_MODE_HELPERS was not included in build
but is a dependency.
Include the devm_ changes and error reporting that Prabhakar Lad
had pushed a patch for,
A few more cosmetic changes
Add a patch to remove the use on inline from a number of functions

Changes in v2:
Addressing review comments from Tomi Valkeinen:
Dropped readl/writel patch as it is not necessary for non-cached,
non-buffered memory.
Many cosmetic changes to make code easier to understand

This is primarily a resend of a series of patches that were original submitted to linux-fbdev back in January of 2013 for 3.8 by Afzal Mohammed. I have rebased them on 3.10 and also made sure they apply cleanly to the 'for-next' branch of linux-fbdev git. The patches enable use of the current mainline da8xx-fb driver on the TI AM335x SOC along with some bug fixes and cleanup.

The original patch series can be found here:
https://patchwork.kernel.org/project/linux-fbdev/list/?submitter9101
if you want to see the history.

Afzal Mohammed (11):
video: da8xx-fb: fb_check_var enhancement
video: da8xx-fb: simplify lcd_reset
video: da8xx-fb: use modedb helper to update var
video: da8xx-fb: remove unneeded "var" initialization
video: da8xx-fb: store current display information
video: da8xx-fb: store clk rate even if !CPUFREQ
video: da8xx-fb: store struct device *
video: da8xx-fb: report correct pixclock
video: da8xx-fb: enable sync lost intr for v2 ip
video: da8xx-fb: ensure non-null cfg in pdata
video: da8xx-fb: reorganize panel detection

Darren Etheridge (9):
video: da8xx-fb: pix clk and clk div handling cleanup
video: da8xx-fb: fb_set_par support
video: da8xx-fb: improve readability of code
video: da8xx-fb: fix 24bpp raster configuration
video: da8xx-fb: use devres
video: da8xx-fb: set upstream clock rate (if reqd)
video: da8xx-fb: make clock naming consistent
video: da8xx-fb: let compiler decide what to inline
video: da8xx-fb: adding am33xx as dependency

 drivers/video/Kconfig    |    8 +-
 drivers/video/da8xx-fb.c |  352 +++++++++++++++++++++++++++-------------------
 include/video/da8xx-fb.h |    5 +
 3 files changed, 216 insertions(+), 149 deletions(-)