Skip to contentSkip to conversation

usb: Move definition of USB_EHCI_BIG_ENDIAN_MMIO out side of the ifs.

PATCH Superseded David Daney 2 participants 2 messages Aug 10, 2013 USB

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: Move definition of USB_EHCI_BIG_ENDIAN_MMIO out side of the ifs.

From: David Daney <[email protected]>

When CONFIG_USB_SUPPORT is not selected we get things like:

scripts/kconfig/mconf Kconfig
warning: (MIPS_SEAD3 && PMC_MSP && CPU_CAVIUM_OCTEON) selects USB_EHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies (USB_SUPPORT && USB)

It is much cleaner to make the various system Kconfigs select USB_EHCI_BIG_ENDIAN_MMIO rather than move the system config information into USB's Kconfig, but the warnings are annoying.

Eliminate the warning by moving the definition of USB_EHCI_BIG_ENDIAN_MMIO outside of all the Kconfig if statements.

---
 drivers/usb/Kconfig      | 3 +++
 drivers/usb/host/Kconfig | 3 ---
 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/usb/Kconfig +3 -0
index 73f62ca..38f97c5 100644
@@ -9,6 +9,9 @@ config USB_ARCH_HAS_OHCI
 config USB_ARCH_HAS_EHCI
 	bool
 
+config USB_EHCI_BIG_ENDIAN_MMIO
+	bool
+
 config USB_ARCH_HAS_XHCI
 	bool
 
drivers/usb/host/Kconfig +0 -3
index 8e8e694..75e9f30 100644
@@ -113,9 +113,6 @@ config USB_EHCI_HCD_PMC_MSP
 		Enables support for the onchip USB controller on the PMC_MSP7100 Family SoC's.
 		If unsure, say N.
 
-config USB_EHCI_BIG_ENDIAN_MMIO
-	bool
-
 config USB_EHCI_BIG_ENDIAN_DESC
 	bool
 
Signature · 1 line
1.7.11.7
#1 lore raw
Quoted 7 lines · David Daney

From: David Daney <[email protected]>

When CONFIG_USB_SUPPORT is not selected we get things like:

scripts/kconfig/mconf Kconfig
warning: (MIPS_SEAD3 && PMC_MSP && CPU_CAVIUM_OCTEON) selects USB_EHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies (USB_SUPPORT && USB)

Quoted 6 lines

It is much cleaner to make the various system Kconfigs select USB_EHCI_BIG_ENDIAN_MMIO rather than move the system config information into USB's Kconfig, but the warnings are annoying.

Eliminate the warning by moving the definition of USB_EHCI_BIG_ENDIAN_MMIO outside of all the Kconfig if statements.

This is a good thing to do, but you should also move USB_EHCI_BIG_ENDIAN_DESC.

And while you're at it, might as well move USB_OHCI_BIG_ENDIAN_DESC, USB_OHCI_BIG_ENDIAN_MMIO, and USB_OHCI_LITTLE_ENDIAN outside their "if" blocks.

Alan Stern