Skip to contentSkip to conversation

unmodified_drivers: enable unplug per default

PATCH Superseded Olaf Hering 3 participants 4 messages Aug 30, 2013 – Sep 18, 2013

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 unmodified_drivers: enable unplug per default

Since xen-3.3 an official unplug protocol for emulated hardware is available in the toolstack. The pvops kernel does the unplug per default, so it is safe to do it also in the drivers for forward ported xenlinux.
Currently its required to load xen-platform-pci with the module parameter dev_unplug=all, which is cumbersome.

---
 unmodified_drivers/linux-2.6/platform-pci/platform-pci.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
unmodified_drivers/linux-2.6/platform-pci/platform-pci.c +5 -1
index cfd0536..db8fa66 100644
@@ -66,7 +66,7 @@ MODULE_LICENSE("GPL");
 static char *dev_unplug;
 module_param(dev_unplug, charp, 0644);
 MODULE_PARM_DESC(dev_unplug, "Emulated devices to unplug: "
-		 "[all,][ide-disks,][aux-ide-disks,][nics]\n");
+		 "[all,][ide-disks,][aux-ide-disks,][nics] (default is 'all')\n");
 
 struct pci_dev *xen_platform_pdev;
 
@@ -290,6 +290,10 @@ static int check_platform_magic(struct device *dev, long ioaddr, long iolen)
 	short magic, unplug = 0;
 	char protocol, *p, *q, *err;
 
+	/* Unconditionally unplug everything */
+	if (!dev_unplug)
+		unplug = UNPLUG_ALL;
+
 	for (p = dev_unplug; p; p = q) {
 		q = strchr(dev_unplug, ',');
 		if (q)
#1 lore raw
Quoted 6 lines · Olaf Hering

Since xen-3.3 an official unplug protocol for emulated hardware is available in the toolstack. The pvops kernel does the unplug per default, so it is safe to do it also in the drivers for forward ported xenlinux.
Currently its required to load xen-platform-pci with the module parameter dev_unplug=all, which is cumbersome.

Not sure who is supposed to review/ack/nack this change.

Wouldn't you want to add a way to stop the unplug? As it stands I think you can request it do less, but not nothing.

Quoted 35 lines
---
 unmodified_drivers/linux-2.6/platform-pci/platform-pci.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
unmodified_drivers/linux-2.6/platform-pci/platform-pci.c +5 -1
index cfd0536..db8fa66 100644
@@ -66,7 +66,7 @@ MODULE_LICENSE("GPL");
 static char *dev_unplug;
 module_param(dev_unplug, charp, 0644);
 MODULE_PARM_DESC(dev_unplug, "Emulated devices to unplug: "
-		 "[all,][ide-disks,][aux-ide-disks,][nics]\n");
+		 "[all,][ide-disks,][aux-ide-disks,][nics] (default is 'all')\n");
 
 struct pci_dev *xen_platform_pdev;
 
@@ -290,6 +290,10 @@ static int check_platform_magic(struct device *dev, long ioaddr, long iolen)
 	short magic, unplug = 0;
 	char protocol, *p, *q, *err;
 
+	/* Unconditionally unplug everything */
+	if (!dev_unplug)
+		unplug = UNPLUG_ALL;
+
 	for (p = dev_unplug; p; p = q) {
 		q = strchr(dev_unplug, ',');
 		if (q)

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel

#2 lore raw
Quoted 10 lines
Quoted 1 line
Quoted 1 line · Ian Campbell
Quoted 6 lines · Olaf Hering

Since xen-3.3 an official unplug protocol for emulated hardware is available in the toolstack. The pvops kernel does the unplug per default, so it is safe to do it also in the drivers for forward ported xenlinux.
Currently its required to load xen-platform-pci with the module parameter dev_unplug=all, which is cumbersome.

Not sure who is supposed to review/ack/nack this change.

Me. I was merely giving it some time to see whether someone else had an opinion.

Quoted 2 lines

Wouldn't you want to add a way to stop the unplug? As it stands I think you can request it do less, but not nothing.

And voilà - good point.

Jan

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel

#3 lore raw
In reply to Ian Campbell
Quoted 8 lines · Ian Campbell
Quoted 6 lines · Olaf Hering

Since xen-3.3 an official unplug protocol for emulated hardware is available in the toolstack. The pvops kernel does the unplug per default, so it is safe to do it also in the drivers for forward ported xenlinux.
Currently its required to load xen-platform-pci with the module parameter dev_unplug=all, which is cumbersome.

Quoted 4 lines

Not sure who is supposed to review/ack/nack this change.

Wouldn't you want to add a way to stop the unplug? As it stands I think you can request it do less, but not nothing.

I think adding a new dev_unplug=never case would fix this case. I will send another version of this patch.

Olaf