sh4: Fix serial line access for Linux kernels later than 3.2
PATCH 1/1 sh4: Fix serial line access for Linux kernels later than 3.2
With Linux kernel version 3.3 or later, qemu fails with the following message:
sh_serial: unsupported read from 0x18
Aborted
---
See http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg03870.html
for Rob's analysis of the problem. Unfortunately, the patch never made it into qemu.
hw/char/sh_serial.c | 2 -- 1 file changed, 2 deletions(-)
hw/char/sh_serial.c +0 -2
@@ -248,11 +248,9 @@ static uint64_t sh_serial_read(void *opaque, hwaddr offs, s->flags &= ~SH_SERIAL_FLAG_RDF ; }break ; -#if 0 case 0x18 : ret = s->fcr;break ; -#endif case 0x1c : ret = s->rx_cnt;break ;
Signature · 1 line
1.7.9.7
Quoted 11 lines · Guenter Roeck
With Linux kernel version 3.3 or later, qemu fails with the following message:
sh_serial: unsupported read from0x18
AbortedReported-and-analyzed-by Rob Landley <[email protected]>Signed-off-by Guenter Roeck <[email protected]>---
See http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg03870.html
for Rob's analysis of the problem. Unfortunately, the patch never made it into qemu.
since I see from that mail thread that I did check the hardware docs. CCing Aurelien as the listed maintainer for sh4.
-- PMM
Quoted 13 lines · Peter Maydell
Quoted 11 lines · Guenter Roeck
With Linux kernel version 3.3 or later, qemu fails with the following message:
sh_serial: unsupported read from0x18
AbortedReported-and-analyzed-by Rob Landley <[email protected]>Signed-off-by Guenter Roeck <[email protected]>---
See http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg03870.html
for Rob's analysis of the problem. Unfortunately, the patch never made it into qemu.
Quoted 5 lines
Reviewed-by Peter Maydell <[email protected]>since I see from that mail thread that I did check the hardware docs. CCing Aurelien as the listed maintainer for sh4.
I did run the patch through get_maintainer.pl, but Aurelien was not listed. Turns out the file is not listed in MAINTAINERS as belonging to sh4.
Should I submit another patch to fix that ?
Guenter
Quoted 7 lines · Guenter Roeck
With Linux kernel version 3.3 or later, qemu fails with the following message:
sh_serial: unsupported read from0x18
AbortedReported-and-analyzed-by Rob Landley <[email protected]>Signed-off-by Guenter Roeck <[email protected]>
ping ...
Quoted 25 lines
---
See http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg03870.html
for Rob's analysis of the problem. Unfortunately, the patch never made it into qemu.hw/char/sh_serial.c | 2 -- 1 file changed, 2 deletions(-)hw/char/sh_serial.c +0
-2@@ -248,11 +248,9 @@ static uint64_t sh_serial_read(void *opaque, hwaddr offs, s->flags &= ~SH_SERIAL_FLAG_RDF ; }break ; -#if 0 case 0x18 : ret = s->fcr;break ; -#endif case 0x1c : ret = s->rx_cnt;break ;
sh4 is ~orphan so nobody should complain if qemu-trivial picks this up as well.
Paolo
Il 14/09/2013 06:04, Guenter Roeck ha scritto:
Quoted 39 lines · Guenter Roeck
Quoted 8 lines
With Linux kernel version 3.3 or later, qemu fails with the following message:
sh_serial: unsupported read from0x18
AbortedReported-and-analyzed-by Rob Landley <[email protected]>Signed-off-by Guenter Roeck <[email protected]>ping ...
Quoted 26 lines
---
See http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg03870.html
for Rob's analysis of the problem. Unfortunately, the patch never made it into qemu.hw/char/sh_serial.c | 2 -- 1 file changed, 2 deletions(-)hw/char/sh_serial.c +0
-2@@ -248,11 +248,9 @@ static uint64_t sh_serial_read(void *opaque,hwaddr offs, s->flags &= ~SH_SERIAL_FLAG_RDF; }break ; -#if 0 case 0x18 : ret = s->fcr;break ; -#endif case 0x1c : ret = s->rx_cnt;break;
Michael Tokarev
AppliedQuoted 22 lines · Paolo Bonzini
sh4 is ~orphan so nobody should complain if qemu-trivial picks this up as well.
Paolo
Il 14/09/2013 06:04, Guenter Roeck ha scritto:
Quoted 16 lines · Guenter Roeck
Quoted 8 lines
With Linux kernel version 3.3 or later, qemu fails with the following message:
sh_serial: unsupported read from0x18
AbortedReported-and-analyzed-by Rob Landley <[email protected]>Signed-off-by Guenter Roeck <[email protected]>ping ...
Quoted 4 lines
---
See http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg03870.html
for Rob's analysis of the problem. Unfortunately, the patch never made it into qemu.
Thanks, applied to the trivial patches queue.
/mjt