pci: partially implement master abort protocol
v5 cover pci: partially implement master abort protocol
PCI spec requires that a transaction that has not been claimed by any PCI bus devices will be terminated by the initiator with "master abort". For read transactions -1(FFFFFFFF) is returned and writes are silently dropped.
Implementation:
- Allowed the MemoryRegion priority to be negative so a subregion will be visible on all the addresses not covered by other container subregions.
- Added a memory region with negative priority that extends over all the pci address space. This region catches all the accesses
to the unassigned pci addresses.
- The MemoryRegion's ops emulates the master abort scenario.
I am working on implementing the following on top of this series
- Implement upstream master abort
- Handling of RECEIVED MASTER ABORT BIT in Status register
Changes from v4:
- Addressed Peter Maydell comments
- Changed memory patches commit comment
- Addressed Michael S. Tsirkin comments
- Changed PCI master_abort_mem ops endian-nes to DEVICE_LITTLE_ENDIAN
Changes from v3:
- Addressed Peter Maydell comments
- Removed unnecessary changes to priority of MemoryListener
- Ensured that priority is now signed in all related places
- Added to memory docs explanation on signed priorities
- Addresses Michael S. Tsirkin comments
- Changed the name of the new Memory region to master_abort_mem
- Made master abort priority INT_MIN instead of -1
- Removed handling of RECEIVED MASTER ABORT BIT; it will be taken care in a different series
Changes from v2:
- minor: changed nr of patches in the title
- minor: modified series list
Changes from v1:
- "pci-unassigned-mem" MemoryRegion resides now in PCIBus and not on various Host Bridges
- "pci-unassgined-mem" does not have a ".valid.accept" field and implements read write methods
Marcel Apfelbaum (3):
memory: Change MemoryRegion priorities from unsigned to signed docs/memory: Explictly state that MemoryRegion priority is signed hw/pci: partially handle pci master abort
docs/memory.txt | 4 ++++ hw/core/sysbus.c | 4 ++-- hw/pci/pci.c | 27 +++++++++++++++++++++++++++ include/exec/memory.h | 4 ++-- include/hw/pci/pci_bus.h | 1 + include/hw/sysbus.h | 2 +- memory.c | 4 ++-- 7 files changed, 39 insertions(+), 7 deletions(-)
Signature · 1 line
1.8.3.1
PATCH v5 1/3 memory: Change MemoryRegion priorities from unsigned to signed
When memory regions overlap, priority can be used to specify which of them takes priority. By making the priority values signed rather than unsigned, we make it more convenient to implement a situation where one "background" region should appear only where no other region exists: rather than having to explicitly specify a high priority for all the other regions, we can let them take the default (zero) priority and specify a negative priority for the background region.
---
Changes from v4:
- Addressed Peter Maydell comments
- Changed commit comment
Changes from v3:
- Addressed Peter Maydell comments
- Removed unnecessary changes to priority of MemoryListener
- Ensured that priority is now signed in all related places
hw/core/sysbus.c | 4 ++-- include/exec/memory.h | 4 ++-- include/hw/sysbus.h | 2 +- memory.c | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-)
hw/core/sysbus.c +2 -2
@@ -49,7 +49,7 @@ void sysbus_connect_irq(SysBusDevice *dev, int n, qemu_irq irq) }static void sysbus_mmio_map_common (SysBusDevice *dev,int n,hwaddr addr, -bool may_overlap,unsigned priority) +bool may_overlap,int priority) {assert (n >=0 && n < dev->num_mmio);
@@ -81,7 +81,7 @@ void sysbus_mmio_map(SysBusDevice *dev, int n, hwaddr addr) }void sysbus_mmio_map_overlap (SysBusDevice *dev,int n,hwaddr addr, -unsigned priority) +int priority) {sysbus_mmio_map_common (dev, n, addr, true, priority); }
include/exec/memory.h +2 -2
@@ -153,7 +153,7 @@ struct MemoryRegion {bool flush_coalesced_mmio;MemoryRegion *alias;hwaddr alias_offset; -unsigned priority; +int priority;bool may_overlap; QTAILQ_HEAD(subregions, MemoryRegion) subregions;QTAILQ_ENTRY (MemoryRegion) subregions_link;
@@ -779,7 +779,7 @@ void memory_region_add_subregion(MemoryRegion *mr,void memory_region_add_subregion_overlap (MemoryRegion *mr,hwaddr offset,MemoryRegion *subregion, -unsigned priority); +int priority);/** * memory_region_get_ram_addr: Get the ram address associated with a memory
include/hw/sysbus.h +1 -1
@@ -68,7 +68,7 @@ void sysbus_init_ioports(SysBusDevice *dev, pio_addr_t ioport, pio_addr_t size);void sysbus_connect_irq (SysBusDevice *dev,int n,qemu_irq irq);void sysbus_mmio_map (SysBusDevice *dev,int n,hwaddr addr);void sysbus_mmio_map_overlap (SysBusDevice *dev,int n,hwaddr addr, -unsigned priority); +int priority);void sysbus_add_io (SysBusDevice *dev,hwaddr addr,MemoryRegion *mem);void sysbus_del_io (SysBusDevice *dev,MemoryRegion *mem);
memory.c +2 -2
@@ -1473,7 +1473,7 @@ void memory_region_add_subregion(MemoryRegion *mr,void memory_region_add_subregion_overlap (MemoryRegion *mr,hwaddr offset,MemoryRegion *subregion, -unsigned priority) +int priority) { subregion->may_overlap = true; subregion->priority = priority;
@@ -1506,7 +1506,7 @@ void memory_region_set_enabled(MemoryRegion *mr, bool enabled)void memory_region_set_address (MemoryRegion *mr,hwaddr addr) {MemoryRegion *parent = mr->parent; -unsigned priority = mr->priority; +int priority = mr->priority;bool may_overlap = mr->may_overlap;if (addr == mr->addr || !parent) {
Signature · 1 line
1.8.3.1
PATCH v5 2/3 docs/memory: Explictly state that MemoryRegion priority is signed
In reply to Marcel ApfelbaumWhen memory regions overlap, priority can be used to specify which of them takes priority. By making the priority values signed rather than unsigned, we make it more convenient to implement a situation where one "background" region should appear only where no other region exists: rather than having to explicitly specify a high priority for all the other regions, we can let them take the default (zero) priority and specify a negative priority for the background region.
---
Changes from v4:
- Addressed Peter Maydell comments
- Changed commit comment
docs/memory.txt | 4 ++++ 1 file changed, 4 insertions(+)
docs/memory.txt +4 -0
@@ -80,6 +80,10 @@ guest. This is done with memory_region_add_subregion_overlap(), which allows the region to overlap any other region in the same container, and specifies a priority that allows the core to decide which of two regions at the same address are visible (highest wins). +Priority values are signed, and the default value is zero. This means that +you can use memory_region_add_subregion_overlap() both to specify a region +that must sit 'above' any others (with a positive priority) and also a +background region that sits 'below' others (with a negative priority). Visibility ----------
Signature · 1 line
1.8.3.1
PATCH v5 3/3 hw/pci: partially handle pci master abort
In reply to Marcel ApfelbaumA MemoryRegion with negative priority was created and it spans over all the pci address space.
It "intercepts" the accesses to unassigned pci address space and will follow the pci spec:
1. returns -1 on read
2. does nothing on write
Note: setting the RECEIVED MASTER ABORT bit in the STATUS register
of the device that initiated the transaction will be implemented in another series
---
Changes from v4:
- Addressed Michael S. Tsirkin comments
- Changed PCI master_abort_mem ops endian-nes to DEVICE_LITTLE_ENDIAN
- Fixed: overlap master_abort_mem at offset 0, not at
bus->address_space_mem.addr
hw/pci/pci.c | 26 ++++++++++++++++++++++++++ include/hw/pci/pci_bus.h | 1 + 2 files changed, 27 insertions(+)
hw/pci/pci.c +26 -0
@@ -283,6 +283,24 @@ const char *pci_root_bus_path(PCIDevice *dev)return rootbus->qbus.name; } +static uint64_t master_abort_mem_read (void *opaque,hwaddr addr,unsigned size) +{ +return -1ULL ; +} + +static void master_abort_mem_write (void *opaque,hwaddr addr,uint64_t val, +unsigned size) +{ +} + +static const MemoryRegionOps master_abort_mem_ops = { + .read = master_abort_mem_read, + .write = master_abort_mem_write, + .endianness =DEVICE_LITTLE_ENDIAN , +}; + +#define MASTER_ABORT_MEM_PRIORITY INT_MIN + static void pci_bus_init(PCIBus *bus, DeviceState *parent, const char *name, MemoryRegion *address_space_mem,
@@ -294,6 +312,14 @@ static void pci_bus_init(PCIBus *bus, DeviceState *parent, bus->address_space_mem = address_space_mem; bus->address_space_io = address_space_io; + +memory_region_init_io (&bus->master_abort_mem,OBJECT (bus), + &master_abort_mem_ops, bus,"pci-master-abort" , +memory_region_size (bus->address_space_mem)); +memory_region_add_subregion_overlap (bus->address_space_mem, +0 , &bus->master_abort_mem, +MASTER_ABORT_MEM_PRIORITY ); +/* host bridge */ QLIST_INIT (&bus->child);
include/hw/pci/pci_bus.h +1 -0
@@ -23,6 +23,7 @@ struct PCIBus {PCIDevice *parent_dev;MemoryRegion *address_space_mem;MemoryRegion *address_space_io; +MemoryRegion master_abort_mem; QLIST_HEAD(, PCIBus) child; /* this will be replaced by qdev later */QLIST_ENTRY (PCIBus) sibling;/* this will be replaced by qdev later */
Signature · 1 line
1.8.3.1
Re: [Qemu-devel] [PATCH v5 3/3] hw/pci: partially handle pci master abort
Quoted 57 lines · Marcel Apfelbaum
A MemoryRegion with negative priority was created and it spans over all the pci address space.
It "intercepts" the accesses to unassigned pci address space and will follow the pci spec:
1. returns -1 on read
2. does nothing on writeNote: setting the RECEIVED MASTER ABORT bit in the STATUS register
of the device that initiated the transaction will be implemented in another seriesSigned-off-by Marcel Apfelbaum <[email protected]>---
Changes from v4:
- Addressed Michael S. Tsirkin comments
- Changed PCImaster_abort_memops endian-nes toDEVICE_LITTLE_ENDIAN
- Fixed: overlapmaster_abort_memat offset 0, not atbus->address_space_mem.addrhw/pci/pci.c | 26 ++++++++++++++++++++++++++ include/hw/pci/pci_bus.h | 1 + 2 files changed, 27 insertions(+)hw/pci/pci.c +19
-0@@ -283,6 +283,24 @@ const char *pci_root_bus_path(PCIDevice *dev)return rootbus->qbus.name; } +static uint64_t master_abort_mem_read (void *opaque,hwaddr addr,unsigned size) +{ +return -1ULL ; +} + +static void master_abort_mem_write (void *opaque,hwaddr addr,uint64_t val, +unsigned size) +{ +} + +static const MemoryRegionOps master_abort_mem_ops = { + .read = master_abort_mem_read, + .write = master_abort_mem_write, + .endianness =DEVICE_LITTLE_ENDIAN , +}; + +#define MASTER_ABORT_MEM_PRIORITY INT_MIN + static void pci_bus_init(PCIBus *bus, DeviceState *parent, const char *name, MemoryRegion *address_space_mem,@@ -294,6 +312,14 @@ static void pci_bus_init(PCIBus *bus, DeviceState *parent, bus->address_space_mem = address_space_mem; bus->address_space_io = address_space_io; +
hw/pci/pci.c static void pci_bus_init(PCIBus *bus, DeviceState *parent, · line 325
Quoted 10 lines
hw/pci/pci.c +7
-0+memory_region_init_io (&bus->master_abort_mem,OBJECT (bus), + &master_abort_mem_ops, bus,"pci-master-abort" , +memory_region_size (bus->address_space_mem)); +memory_region_add_subregion_overlap (bus->address_space_mem, +0 , &bus->master_abort_mem, +MASTER_ABORT_MEM_PRIORITY ); +/* host bridge */ QLIST_INIT (&bus->child);
Does this handle devices behind bridges?
include/hw/pci/pci_bus.h struct PCIBus { · line 27
Quoted 10 lines
include/hw/pci/pci_bus.h +1
-0@@ -23,6 +23,7 @@ struct PCIBus {PCIDevice *parent_dev;MemoryRegion *address_space_mem;MemoryRegion *address_space_io; +MemoryRegion master_abort_mem;
Looks like this field is left uninitialized for bridge devices (they don't seem to call pci_bus_init)?
Quoted 4 lines
include/hw/pci/pci_bus.h +0
-0QLIST_HEAD(, PCIBus) child; /* this will be replaced by qdev later */QLIST_ENTRY (PCIBus) sibling;/* this will be replaced by qdev later */ Signature · 1 line
1.8.3.1
Re: [Qemu-devel] [PATCH v5 3/3] hw/pci: partially handle pci master abort
Quoted 57 lines · Michael S. Tsirkin
Quoted 56 lines · Marcel Apfelbaum
A MemoryRegion with negative priority was created and it spans over all the pci address space.
It "intercepts" the accesses to unassigned pci address space and will follow the pci spec:
1. returns -1 on read
2. does nothing on writeNote: setting the RECEIVED MASTER ABORT bit in the STATUS register
of the device that initiated the transaction will be implemented in another seriesSigned-off-by Marcel Apfelbaum <[email protected]>---
Changes from v4:
- Addressed Michael S. Tsirkin comments
- Changed PCImaster_abort_memops endian-nes toDEVICE_LITTLE_ENDIAN
- Fixed: overlapmaster_abort_memat offset 0, not atbus->address_space_mem.addrhw/pci/pci.c | 26 ++++++++++++++++++++++++++ include/hw/pci/pci_bus.h | 1 + 2 files changed, 27 insertions(+)hw/pci/pci.c +18
-0@@ -283,6 +283,24 @@ const char *pci_root_bus_path(PCIDevice *dev)return rootbus->qbus.name; } +static uint64_t master_abort_mem_read (void *opaque,hwaddr addr,unsigned size) +{ +return -1ULL ; +} + +static void master_abort_mem_write (void *opaque,hwaddr addr,uint64_t val, +unsigned size) +{ +} + +static const MemoryRegionOps master_abort_mem_ops = { + .read = master_abort_mem_read, + .write = master_abort_mem_write, + .endianness =DEVICE_LITTLE_ENDIAN , +}; + +#define MASTER_ABORT_MEM_PRIORITY INT_MIN + static void pci_bus_init(PCIBus *bus, DeviceState *parent, const char *name, MemoryRegion *address_space_mem,@@ -294,6 +312,14 @@ static void pci_bus_init(PCIBus *bus, DeviceState *parent, bus->address_space_mem = address_space_mem; bus->address_space_io = address_space_io;
Quoted 13 lines
hw/pci/pci.c static void pci_bus_init(PCIBus *bus, DeviceState *parent, · line 325
Quoted 11 lines
hw/pci/pci.c +8
-0+ +memory_region_init_io (&bus->master_abort_mem,OBJECT (bus), + &master_abort_mem_ops, bus,"pci-master-abort" , +memory_region_size (bus->address_space_mem)); +memory_region_add_subregion_overlap (bus->address_space_mem, +0 , &bus->master_abort_mem, +MASTER_ABORT_MEM_PRIORITY ); +/* host bridge */ QLIST_INIT (&bus->child);Does this handle devices behind bridges?
Yes, tested also for devices behind bridge.
Quoted 15 lines
include/hw/pci/pci_bus.h struct PCIBus { · line 27
Quoted 12 lines
include/hw/pci/pci_bus.h +1
-0@@ -23,6 +23,7 @@ struct PCIBus {PCIDevice *parent_dev;MemoryRegion *address_space_mem;MemoryRegion *address_space_io; +MemoryRegion master_abort_mem;Looks like this field is left uninitialized for bridge devices (they don't seem to call
pci_bus_init)?
The bridges have no influence with respect to master_abort_mem as it handles *all* unassigned addresses for PCI address space. As stated above, it was tested.
Thanks,
Marcel
Quoted 5 lines
Quoted 5 lines
include/hw/pci/pci_bus.h +0
-0QLIST_HEAD(, PCIBus) child; /* this will be replaced by qdev later */QLIST_ENTRY (PCIBus) sibling;/* this will be replaced by qdev later */ Signature · 1 line
1.8.3.1
Re: [Qemu-devel] [PATCH v5 3/3] hw/pci: partially handle pci master abort
Quoted 9 lines · Marcel Apfelbaum
Quoted 8 lines · Michael S. Tsirkin
Quoted 7 lines · Marcel Apfelbaum
A MemoryRegion with negative priority was created and it spans over all the pci address space.
It "intercepts" the accesses to unassigned pci address space and will follow the pci spec:
1. returns -1 on read
2. does nothing on write
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Note: setting the RECEIVED MASTER ABORT bit in the STATUS register
of the device that initiated the transaction will be implemented in another seriesSigned-off-by Marcel Apfelbaum <[email protected]>
So let's hold on to this patch and see how the full implementation interacts with it.
Let's apply 1-2 - I'll put it on my tree unless someone objects.
Quoted 57 lines
Quoted 44 lines
Quoted 44 lines
---
Changes from v4:
- Addressed Michael S. Tsirkin comments
- Changed PCImaster_abort_memops endian-nes toDEVICE_LITTLE_ENDIAN
- Fixed: overlapmaster_abort_memat offset 0, not atbus->address_space_mem.addrhw/pci/pci.c | 26 ++++++++++++++++++++++++++ include/hw/pci/pci_bus.h | 1 + 2 files changed, 27 insertions(+)hw/pci/pci.c +18
-0@@ -283,6 +283,24 @@ const char *pci_root_bus_path(PCIDevice *dev)return rootbus->qbus.name; } +static uint64_t master_abort_mem_read (void *opaque,hwaddr addr,unsigned size) +{ +return -1ULL ; +} + +static void master_abort_mem_write (void *opaque,hwaddr addr,uint64_t val, +unsigned size) +{ +} + +static const MemoryRegionOps master_abort_mem_ops = { + .read = master_abort_mem_read, + .write = master_abort_mem_write, + .endianness =DEVICE_LITTLE_ENDIAN , +}; + +#define MASTER_ABORT_MEM_PRIORITY INT_MIN + static void pci_bus_init(PCIBus *bus, DeviceState *parent, const char *name, MemoryRegion *address_space_mem,@@ -294,6 +312,14 @@ static void pci_bus_init(PCIBus *bus, DeviceState *parent, bus->address_space_mem = address_space_mem; bus->address_space_io = address_space_io;Quoted 13 lines
hw/pci/pci.c static void pci_bus_init(PCIBus *bus, DeviceState *parent, · line 325
Quoted 11 lines
hw/pci/pci.c +8
-0+ +memory_region_init_io (&bus->master_abort_mem,OBJECT (bus), + &master_abort_mem_ops, bus,"pci-master-abort" , +memory_region_size (bus->address_space_mem)); +memory_region_add_subregion_overlap (bus->address_space_mem, +0 , &bus->master_abort_mem, +MASTER_ABORT_MEM_PRIORITY ); +/* host bridge */ QLIST_INIT (&bus->child);Does this handle devices behind bridges?
Quoted 1 line
Yes, tested also for devices behind bridge.
BTW why does this only handle memory?
IO should be exactly identical, shouldn't it?
Quoted 30 lines
Quoted 15 lines
include/hw/pci/pci_bus.h struct PCIBus { · line 27
Quoted 12 lines
include/hw/pci/pci_bus.h +1
-0@@ -23,6 +23,7 @@ struct PCIBus {PCIDevice *parent_dev;MemoryRegion *address_space_mem;MemoryRegion *address_space_io; +MemoryRegion master_abort_mem;Looks like this field is left uninitialized for bridge devices (they don't seem to call
pci_bus_init)?The bridges have no influence with respect to
master_abort_memas it handles *all* unassigned addresses for PCI address space. As stated above, it was tested.Thanks,
MarcelQuoted 5 lines
Quoted 5 lines
include/hw/pci/pci_bus.h +0
-0QLIST_HEAD(, PCIBus) child; /* this will be replaced by qdev later */QLIST_ENTRY (PCIBus) sibling;/* this will be replaced by qdev later */ Signature · 1 line
1.8.3.1
Re: [Qemu-devel] [PATCH v5 3/3] hw/pci: partially handle pci master abort
Quoted 77 lines · Michael S. Tsirkin
Quoted 9 lines · Marcel Apfelbaum
Quoted 8 lines · Michael S. Tsirkin
Quoted 7 lines · Marcel Apfelbaum
A MemoryRegion with negative priority was created and it spans over all the pci address space.
It "intercepts" the accesses to unassigned pci address space and will follow the pci spec:
1. returns -1 on read
2. does nothing on writeQuoted 5 lines
Quoted 5 lines
Quoted 5 lines
Note: setting the RECEIVED MASTER ABORT bit in the STATUS register
of the device that initiated the transaction will be implemented in another seriesSigned-off-by Marcel Apfelbaum <[email protected]>So let's hold on to this patch and see how the full implementation interacts with it.
Let's apply 1-2 - I'll put it on my tree unless someone objects.Quoted 57 lines
Quoted 57 lines
Quoted 45 lines
---
Changes from v4:
- Addressed Michael S. Tsirkin comments
- Changed PCImaster_abort_memops endian-nes toDEVICE_LITTLE_ENDIAN
- Fixed: overlapmaster_abort_memat offset 0, not atbus->address_space_mem.addrhw/pci/pci.c | 26 ++++++++++++++++++++++++++ include/hw/pci/pci_bus.h | 1 + 2 files changed, 27 insertions(+)hw/pci/pci.c +19
-0@@ -283,6 +283,24 @@ const char *pci_root_bus_path(PCIDevice *dev)return rootbus->qbus.name; } +static uint64_t master_abort_mem_read (void *opaque,hwaddr addr,unsigned size) +{ +return -1ULL ; +} + +static void master_abort_mem_write (void *opaque,hwaddr addr,uint64_t val, +unsigned size) +{ +} + +static const MemoryRegionOps master_abort_mem_ops = { + .read = master_abort_mem_read, + .write = master_abort_mem_write, + .endianness =DEVICE_LITTLE_ENDIAN , +}; + +#define MASTER_ABORT_MEM_PRIORITY INT_MIN + static void pci_bus_init(PCIBus *bus, DeviceState *parent, const char *name, MemoryRegion *address_space_mem,@@ -294,6 +312,14 @@ static void pci_bus_init(PCIBus *bus, DeviceState *parent, bus->address_space_mem = address_space_mem; bus->address_space_io = address_space_io; +hw/pci/pci.c static void pci_bus_init(PCIBus *bus, DeviceState *parent, · line 325
Quoted 10 lines
hw/pci/pci.c +7
-0+memory_region_init_io (&bus->master_abort_mem,OBJECT (bus), + &master_abort_mem_ops, bus,"pci-master-abort" , +memory_region_size (bus->address_space_mem)); +memory_region_add_subregion_overlap (bus->address_space_mem, +0 , &bus->master_abort_mem, +MASTER_ABORT_MEM_PRIORITY ); +/* host bridge */ QLIST_INIT (&bus->child);Does this handle devices behind bridges?
Quoted 4 lines
Quoted 1 line
Yes, tested also for devices behind bridge.
BTW why does this only handle memory?
IO should be exactly identical, shouldn't it?
IO is handled on a higher level by Jan Kiszka patch:
[Qemu-devel] [PATCH v3 1/2] memory: Provide separate handling of unassigned io ports accesses
Thanks,
Marcel
Quoted 31 lines
Quoted 31 lines
Quoted 16 lines
include/hw/pci/pci_bus.h struct PCIBus { · line 27
Quoted 13 lines
include/hw/pci/pci_bus.h +1
-0@@ -23,6 +23,7 @@ struct PCIBus {PCIDevice *parent_dev;MemoryRegion *address_space_mem;MemoryRegion *address_space_io; +MemoryRegion master_abort_mem;Looks like this field is left uninitialized for bridge devices (they don't seem to call
pci_bus_init)?The bridges have no influence with respect to
master_abort_memas it handles *all* unassigned addresses for PCI address space. As stated above, it was tested.Thanks,
MarcelQuoted 5 lines
Quoted 5 lines
include/hw/pci/pci_bus.h +0
-0QLIST_HEAD(, PCIBus) child; /* this will be replaced by qdev later */QLIST_ENTRY (PCIBus) sibling;/* this will be replaced by qdev later */ Signature · 1 line
1.8.3.1
Quoted 4 lines · Marcel Apfelbaum
PCI spec requires that a transaction that has not been claimed by any PCI bus devices will be terminated by the initiator with "master abort". For read transactions -1(FFFFFFFF) is returned and writes are silently dropped.
OK looks good to me, I put this on the pci branch.
Quoted 55 lines
Implementation:
- Allowed the MemoryRegion priority to be negative so a subregion will be visible on all the addresses not covered by other container subregions.
- Added a memory region with negative priority that extends over all the pci address space. This region catches all the accesses
to the unassigned pci addresses.
- The MemoryRegion's ops emulates the master abort scenario.I am working on implementing the following on top of this series
- Implement upstream master abort
- Handling of RECEIVED MASTER ABORT BIT in Status registerChanges from v4:
- Addressed Peter Maydell comments
- Changed memory patches commit comment
- Addressed Michael S. Tsirkin comments
- Changed PCImaster_abort_memops endian-nes toDEVICE_LITTLE_ENDIANChanges from v3:
- Addressed Peter Maydell comments
- Removed unnecessary changes to priority of MemoryListener
- Ensured that priority is now signed in all related places
- Added to memory docs explanation on signed priorities
- Addresses Michael S. Tsirkin comments
- Changed the name of the new Memory region tomaster_abort_mem
- Made master abort priorityINT_MINinstead of -1
- Removed handling of RECEIVED MASTER ABORT BIT; it will be taken care in a different seriesChanges from v2:
- minor: changed nr of patches in the title
- minor: modified series listChanges from v1:
- "pci-unassigned-mem" MemoryRegion resides now in PCIBus and not on various Host Bridges
- "pci-unassgined-mem" does not have a ".valid.accept" field and implements read write methodsMarcel Apfelbaum (3):
memory: Change MemoryRegion priorities from unsigned to signed docs/memory: Explictly state that MemoryRegion priority is signed hw/pci: partially handle pci master abortdocs/memory.txt | 4 ++++ hw/core/sysbus.c | 4 ++-- hw/pci/pci.c | 27 +++++++++++++++++++++++++++ include/exec/memory.h | 4 ++-- include/hw/pci/pci_bus.h | 1 + include/hw/sysbus.h | 2 +- memory.c | 4 ++-- 7 files changed, 39 insertions(+), 7 deletions(-)Signature · 1 line
1.8.3.1