pci: partially implement master abort protocol
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest3 patches 5 repliesIn review
- v43 patches 14 repliesSuperseded
- v3 RFC2 patches 6 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 RFC posting 2/2 | 2 patches | 68 replies | Superseded | |
| v2 RFC posting 1/2 | 0 of 3 patches | 0 replies | Superseded | |
| v1 RFC | 3 patches | 21 replies | Superseded |
Changes in v5 from the cover letter
- Addressed Peter Maydell comments
- Changed memory patches commit comment
- Addressed Michael S. Tsirkin comments
- Changed PCI master_abort_mem ops endian-nes to DEVICE_LITTLE_ENDIAN
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | memory: Change MemoryRegion priorities from unsigned to signedhw/ include/ include/ +1 more | +7 | 0 replies | |
| 2/3 | docs/memory: Explictly state that MemoryRegion priority is signeddocs/ | +4 | 0 replies | |
| 3/3 | hw/pci: partially handle pci master aborthw/ include/ | +27 | 4 replies |
Reviews trailers per patch
1 of 3 patches has a Reviewed-by or Acked-by.
| Patch | Peter Maydell | Michael S. Tsirkin |
|---|---|---|
| 1/3 | R-b | A-b |
| 2/3 | ||
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v5 0/3] pci: partially implement master abort protocol
PCI spec requires that a transaction that has not been claimed by any PCI bus devices will be terminated by the initiator with "master abort". For read transactions -1(FFFFFFFF) is returned and writes are silently dropped.
Implementation:
- Allowed the MemoryRegion priority to be negative so a subregion will be visible on all the addresses not covered by other container subregions.
- Added a memory region with negative priority that extends over all the pci address space. This region catches all the accesses
to the unassigned pci addresses.
- The MemoryRegion's ops emulates the master abort scenario.
I am working on implementing the following on top of this series
- Implement upstream master abort
- Handling of RECEIVED MASTER ABORT BIT in Status register
Changes from v4:
- Addressed Peter Maydell comments
- Changed memory patches commit comment
- Addressed Michael S. Tsirkin comments
- Changed PCI master_abort_mem ops endian-nes to DEVICE_LITTLE_ENDIAN
Changes from v3:
- Addressed Peter Maydell comments
- Removed unnecessary changes to priority of MemoryListener
- Ensured that priority is now signed in all related places
- Added to memory docs explanation on signed priorities
- Addresses Michael S. Tsirkin comments
- Changed the name of the new Memory region to master_abort_mem
- Made master abort priority INT_MIN instead of -1
- Removed handling of RECEIVED MASTER ABORT BIT; it will be taken care in a different series
Changes from v2:
- minor: changed nr of patches in the title
- minor: modified series list
Changes from v1:
- "pci-unassigned-mem" MemoryRegion resides now in PCIBus and not on various Host Bridges
- "pci-unassgined-mem" does not have a ".valid.accept" field and implements read write methods
Marcel Apfelbaum (3):
memory: Change MemoryRegion priorities from unsigned to signed docs/memory: Explictly state that MemoryRegion priority is signed hw/pci: partially handle pci master abort
docs/memory.txt | 4 ++++ hw/core/sysbus.c | 4 ++-- hw/pci/pci.c | 27 +++++++++++++++++++++++++++ include/exec/memory.h | 4 ++-- include/hw/pci/pci_bus.h | 1 + include/hw/sysbus.h | 2 +- memory.c | 4 ++-- 7 files changed, 39 insertions(+), 7 deletions(-)
Signature · 1 line
1.8.3.1