MIPS: SmartMIPS: Fix build
Subsystems (2)
PATCH 1/1 MIPS: SmartMIPS: Fix build
All CONFIG_CPU_HAS_SMARTMIPS #ifdefs have been removed from code, but the ACX register declaration in struct pt_regs is still protected by it, causing builds to fail. Remove the #ifdef protection and always declare the register.
--- arch/mips/include/asm/ptrace.h | 2 -- 1 file changed, 2 deletions(-)
arch/mips/include/asm/ptrace.h +0 -2
@@ -33,9 +33,7 @@ struct pt_regs {unsigned long cp0_status;unsigned long hi;unsigned long lo; -#ifdef CONFIG_CPU_HAS_SMARTMIPS unsigned long acx; -#endif unsigned long cp0_badvaddr;unsigned long cp0_cause;unsigned long cp0_epc;
Signature · 1 line
1.8.4
Quoted 16 lines · Thierry Reding
All
CONFIG_CPU_HAS_SMARTMIPS#ifdefs have been removed from code, but the ACX register declaration in structpt_regsis still protected by it, causing builds to fail. Remove the #ifdef protection and always declare the register.Signed-off-by Thierry Reding <[email protected]>--- arch/mips/include/asm/ptrace.h | 2 -- 1 file changed, 2 deletions(-)arch/mips/include/asm/ptrace.h +0
-0
arch/mips/include/asm/ptrace.h struct pt_regs { · line 39
Quoted 9 lines
arch/mips/include/asm/ptrace.h +0
-2@@ -33,9 +33,7 @@ struct pt_regs {unsigned long cp0_status;unsigned long hi;unsigned long lo; -#ifdef CONFIG_CPU_HAS_SMARTMIPS unsigned long acx; -#endif unsigned long cp0_badvaddr;unsigned long cp0_cause;unsigned long cp0_epc;
Hi Thierry,
Looks good to me. Thanks!
Quoted 29 lines · Markos Chandras
Quoted 16 lines · Thierry Reding
All
CONFIG_CPU_HAS_SMARTMIPS#ifdefs have been removed from code, but the ACX register declaration in structpt_regsis still protected by it, causing builds to fail. Remove the #ifdef protection and always declare the register.Signed-off-by Thierry Reding <[email protected]>--- arch/mips/include/asm/ptrace.h | 2 -- 1 file changed, 2 deletions(-)arch/mips/include/asm/ptrace.h +0
-0arch/mips/include/asm/ptrace.h struct pt_regs { · line 39
Quoted 9 lines
arch/mips/include/asm/ptrace.h +0
-2@@ -33,9 +33,7 @@ struct pt_regs {unsigned long cp0_status;unsigned long hi;unsigned long lo; -#ifdef CONFIG_CPU_HAS_SMARTMIPS unsigned long acx; -#endif unsigned long cp0_badvaddr;unsigned long cp0_cause;unsigned long cp0_epc;Hi Thierry,
Quoted 3 lines
Looks good to me. Thanks!
Reviewed-by Markos Chandras <[email protected]>
Looking good - but I've already pulled the offending patch. Processor specific registers in the register frame have historically been a PITA - in particular because much of what's requiring space there is also requiring space in the signal frame and that's a kernel ABI.
Ralf