Skip to contentSkip to conversation

ARM: OMAP3+: support cpufreq-cpu0 for device tree boot

PATCH Superseded Nishanth Menon 4 participants 33 messages Oct 9, 2013 – Oct 11, 2013

Subsystems (5)

v6 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

v6 cover ARM: OMAP3+: support cpufreq-cpu0 for device tree boot

Hi,

The series is based on Tero's V8 of patches[1] - enables the use of cpufreq-cpu0 generic driver for all OMAP and related derivatives.

I will stop copy pasting the series complete history and point at [2].

Main changes since V5:
- no more clock driver as part of this series[3] - instead depend on clock conversion[1].
- added DRA7/OMAP5

Notes:
- i have organized the series such that
* patches 1-6 could go to Tony/Kevin/Paul trees
* Dts series is further split up given continued uncertaininty of v8 clock dts nodes into two sets
- patches 7-10 are based on Benoit's for_13/dts branch and can apply there independently.
- patches 11-15 are dependent on 7-10 patches + clock nodes being available.
- Given the uncertainity with clock nodes, I recommend we get rid of the dependencies (1-10) and decide on clock nodes once the story is clearer.
- if we feel I should squash up clock nodes 9+14, 10+15, I can do that as well.

Series is built on top of V3.12-rc4 + the following maintainer tree merges
git://git.kernel.org/pub/scm/linux/kernel/git/bcousson/linux-omap-dt for_3.13/dts
git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap tag 'fixes-against-v3.12-rc3-take2' and omap-for-v3.13/soc branch
Available here: https://github.com/nmenon/linux-2.6-playground/commits/push/cpufreq-cpu0-omap-all-v6

Test Script: http://pastebin.pandaboard.org/index.php/view/64137893

Test-log:
BeagleBoard-XM (OMAP36xx): http://pastebin.pandaboard.org/index.php/view/64740438
PandaBoard-ES (OMAP4460): http://pastebin.pandaboard.org/index.php/view/13763478
BeagleBone-Black(AM335x): http://pastebin.pandaboard.org/index.php/view/46018613
OMAP5uEVM (OMAP5432): http://pastebin.pandaboard.org/index.php/view/54353148
DRA7-EVM (DRA7xx): http://pastebin.pandaboard.org/index.php/view/70955776

J Keerthy (5):
ARM: dts: dra7-evm: add smps123 supply for CPU
ARM: dts: OMAP5: Add CPU OPP table
ARM: dts: DRA7: Add CPU OPP table
ARM: dts: OMAP5: add clock nodes for CPU
ARM: dts: DRA7: add clock nodes for CPU

Nishanth Menon (10):
ARM: OMAP3+: do not register non-dt OPP tables for device tree boot
ARM: OMAP2+: AM33XX: add lateinit hook for calling pm late init
ARM: OMAP2+: AM43XX: add lateinit hook for calling pm late init
ARM: OMAP2+: OMAP5: add lateinit hook for calling pm late init
ARM: OMAP2+: DRA7: add lateinit hook for calling pm late init
ARM: OMAP3+: use cpu0-cpufreq driver in device tree supported boot
ARM: dts: omap5-uevm: add smps123 supply for CPU
ARM: dts: OMAP3: add clock nodes for CPU
ARM: dts: OMAP4: add clock nodes for CPU
ARM: dts: AM33XX: add clock nodes for CPU

 arch/arm/boot/dts/am33xx.dtsi       |    4 ++++
 arch/arm/boot/dts/dra7-evm.dts      |    4 ++++
 arch/arm/boot/dts/dra7.dtsi         |   13 ++++++++++++-
 arch/arm/boot/dts/omap3.dtsi        |    5 +++++
 arch/arm/boot/dts/omap4.dtsi        |    5 +++++
 arch/arm/boot/dts/omap5-uevm.dts    |    4 ++++
 arch/arm/boot/dts/omap5.dtsi        |   15 ++++++++++++++-
 arch/arm/mach-omap2/board-generic.c |    4 ++++
 arch/arm/mach-omap2/common.h        |    4 ++++
 arch/arm/mach-omap2/io.c            |   24 ++++++++++++++++++++++++
 arch/arm/mach-omap2/opp.c           |    4 ++++
 arch/arm/mach-omap2/pm.c            |   12 +++++++++---
 12 files changed, 93 insertions(+), 5 deletions(-)

[1] http://marc.info/?t=138133284200006&r=1&w=2
[2] http://marc.info/?l=linux-arm-kernel&m=136804009618594&w=2
[3] http://marc.info/?t=136804008400001&r=1&w=2

Regards,
Nishanth Menon

Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v6 1/15 ARM: OMAP3+: do not register non-dt OPP tables for device tree boot

OMAP3+ supports both device tree and non-device tree boot. Device tree bindings for OMAP3+ is supposed to be added via dts following:
Documentation/devicetree/bindings/power/opp.txt

Since we now have device tree entries for OMAP3+ cpu OPPs, The current code wrongly adds duplicate OPPs. So, dont register OPPs when booting using device tree.

---
 arch/arm/mach-omap2/opp.c |    4 ++++
 1 file changed, 4 insertions(+)
arch/arm/mach-omap2/opp.c +4 -0
index bd41d59..82fd8c7 100644
@@ -17,6 +17,7 @@
  * GNU General Public License for more details.
  */
 #include <linux/module.h>
+#include <linux/of.h>
 #include <linux/opp.h>
 #include <linux/cpu.h>
 
@@ -40,6 +41,9 @@ int __init omap_init_opp_table(struct omap_opp_def *opp_def,
 {
 	int i, r;
 
+	if (of_have_populated_dt())
+		return -EINVAL;
+
 	if (!opp_def || !opp_def_size) {
 		pr_err("%s: invalid params!\n", __func__);
 		return -EINVAL;
Signature · 1 line
1.7.9.5
#2 lore raw

PATCH v6 2/15 ARM: OMAP2+: AM33XX: add lateinit hook for calling pm late init

In reply to Nishanth Menon

Call OMAP2+ generic lateinit hook from AM specific late init hook. This allows the generic late initializations such as cpufreq hooks to be active.

Cc Benoit Cousson <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Paul Walmsley <[email protected]>
Cc Tony Lindgren <[email protected]>
---
 arch/arm/mach-omap2/board-generic.c |    1 +
 arch/arm/mach-omap2/common.h        |    1 +
 arch/arm/mach-omap2/io.c            |    6 ++++++
 3 files changed, 8 insertions(+)
arch/arm/mach-omap2/board-generic.c +1 -0
index 87162e1..b474498 100644
@@ -180,6 +180,7 @@ DT_MACHINE_START(AM33XX_DT, "Generic AM33XX (Flattened Device Tree)")
 	.init_irq	= omap_intc_of_init,
 	.handle_irq	= omap3_intc_handle_irq,
 	.init_machine	= omap_generic_init,
+	.init_late	= am33xx_init_late,
 	.init_time	= omap3_gptimer_timer_init,
 	.dt_compat	= am33xx_boards_compat,
 	.restart	= am33xx_restart,
arch/arm/mach-omap2/common.h +1 -0
index 4a5684b..049c58d 100644
@@ -109,6 +109,7 @@ void omap35xx_init_late(void);
 void omap3630_init_late(void);
 void am35xx_init_late(void);
 void ti81xx_init_late(void);
+void am33xx_init_late(void);
 int omap2_common_pm_late_init(void);
 void dra7xx_init_early(void);
 
arch/arm/mach-omap2/io.c +6 -0
index a9896ea..38678bf 100644
@@ -594,6 +594,12 @@ void __init am33xx_init_early(void)
 	omap_hwmod_init_postsetup();
 	omap_clk_init = am33xx_dt_clk_init;
 }
+
+void __init am33xx_init_late(void)
+{
+	omap2_common_pm_late_init();
+}
+
 #endif
 
 #ifdef CONFIG_SOC_AM43XX
Signature · 1 line
1.7.9.5
#3 lore raw

PATCH v6 3/15 ARM: OMAP2+: AM43XX: add lateinit hook for calling pm late init

Call OMAP2+ generic lateinit hook from AM43x specific late init hook. This allows the generic late initializations such as cpufreq hooks to be active.

Cc Benoit Cousson <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Paul Walmsley <[email protected]>
Cc Tony Lindgren <[email protected]>
---
 arch/arm/mach-omap2/board-generic.c |    1 +
 arch/arm/mach-omap2/common.h        |    1 +
 arch/arm/mach-omap2/io.c            |    6 ++++++
 3 files changed, 8 insertions(+)
arch/arm/mach-omap2/board-generic.c +1 -0
index b474498..d4371c7 100644
@@ -235,6 +235,7 @@ static const char *am43_boards_compat[] __initdata = {
 DT_MACHINE_START(AM43_DT, "Generic AM43 (Flattened Device Tree)")
 	.map_io		= am33xx_map_io,
 	.init_early	= am43xx_init_early,
+	.init_late	= am43xx_init_late,
 	.init_irq	= omap_gic_of_init,
 	.init_machine	= omap_generic_init,
 	.init_time	= omap3_sync32k_timer_init,
arch/arm/mach-omap2/common.h +1 -0
index 049c58d..09f6736 100644
@@ -98,6 +98,7 @@ void am35xx_init_early(void);
 void ti81xx_init_early(void);
 void am33xx_init_early(void);
 void am43xx_init_early(void);
+void am43xx_init_late(void);
 void omap4430_init_early(void);
 void omap5_init_early(void);
 void omap3_init_late(void);	/* Do not use this one */
arch/arm/mach-omap2/io.c +6 -0
index 38678bf..300eac0 100644
@@ -613,6 +613,12 @@ void __init am43xx_init_early(void)
 	omap2_set_globals_cm(AM33XX_L4_WK_IO_ADDRESS(AM43XX_PRCM_BASE), NULL);
 	omap3xxx_check_revision();
 }
+
+void __init am43xx_init_late(void)
+{
+	omap2_common_pm_late_init();
+}
+
 #endif
 
 #ifdef CONFIG_ARCH_OMAP4
Signature · 1 line
1.7.9.5
#4 lore raw

PATCH v6 4/15 ARM: OMAP2+: OMAP5: add lateinit hook for calling pm late init

In reply to Nishanth Menon

Call OMAP2+ generic lateinit hook from AM specific late init hook. This allows the generic late initializations such as cpufreq hooks to be active.

Cc Benoit Cousson <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Paul Walmsley <[email protected]>
Cc Tony Lindgren <[email protected]>
---
 arch/arm/mach-omap2/board-generic.c |    1 +
 arch/arm/mach-omap2/common.h        |    1 +
 arch/arm/mach-omap2/io.c            |    6 ++++++
 3 files changed, 8 insertions(+)
arch/arm/mach-omap2/board-generic.c +1 -0
index d4371c7..67dbae2 100644
@@ -220,6 +220,7 @@ DT_MACHINE_START(OMAP5_DT, "Generic OMAP5 (Flattened Device Tree)")
 	.init_early	= omap5_init_early,
 	.init_irq	= omap_gic_of_init,
 	.init_machine	= omap_generic_init,
+	.init_late	= omap5_init_late,
 	.init_time	= omap5_realtime_timer_init,
 	.dt_compat	= omap5_boards_compat,
 	.restart	= omap44xx_restart,
arch/arm/mach-omap2/common.h +1 -0
index 09f6736..ceb208b 100644
@@ -111,6 +111,7 @@ void omap3630_init_late(void);
 void am35xx_init_late(void);
 void ti81xx_init_late(void);
 void am33xx_init_late(void);
+void omap5_init_late(void);
 int omap2_common_pm_late_init(void);
 void dra7xx_init_early(void);
 
arch/arm/mach-omap2/io.c +6 -0
index 300eac0..6226e0d 100644
@@ -675,6 +675,12 @@ void __init omap5_init_early(void)
 	omap_hwmod_init_postsetup();
 	omap_clk_init = omap5xxx_dt_clk_init;
 }
+
+void __init omap5_init_late(void)
+{
+	omap2_common_pm_late_init();
+}
+
 #endif
 
 #ifdef CONFIG_SOC_DRA7XX
Signature · 1 line
1.7.9.5
#5 lore raw

PATCH v6 5/15 ARM: OMAP2+: DRA7: add lateinit hook for calling pm late init

In reply to Nishanth Menon

Call OMAP2+ generic lateinit hook from DRA7 specific late init hook. This allows the generic late initializations such as cpufreq hooks to be active.

Cc Benoit Cousson <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Paul Walmsley <[email protected]>
Cc Tony Lindgren <[email protected]>
---
 arch/arm/mach-omap2/board-generic.c |    1 +
 arch/arm/mach-omap2/common.h        |    1 +
 arch/arm/mach-omap2/io.c            |    6 ++++++
 3 files changed, 8 insertions(+)
arch/arm/mach-omap2/board-generic.c +1 -0
index 67dbae2..c0b0848 100644
@@ -255,6 +255,7 @@ DT_MACHINE_START(DRA7XX_DT, "Generic DRA7XX (Flattened Device Tree)")
 	.smp		= smp_ops(omap4_smp_ops),
 	.map_io		= omap5_map_io,
 	.init_early	= dra7xx_init_early,
+	.init_late	= dra7xx_init_late,
 	.init_irq	= omap_gic_of_init,
 	.init_machine	= omap_generic_init,
 	.init_time	= omap5_realtime_timer_init,
arch/arm/mach-omap2/common.h +1 -0
index ceb208b..352fa9d 100644
@@ -114,6 +114,7 @@ void am33xx_init_late(void);
 void omap5_init_late(void);
 int omap2_common_pm_late_init(void);
 void dra7xx_init_early(void);
+void dra7xx_init_late(void);
 
 #ifdef CONFIG_SOC_BUS
 void omap_soc_device_init(void);
arch/arm/mach-omap2/io.c +6 -0
index 6226e0d..3b7b543 100644
@@ -702,6 +702,12 @@ void __init dra7xx_init_early(void)
 	omap_hwmod_init_postsetup();
 	omap_clk_init = dra7xx_dt_clk_init;
 }
+
+void __init dra7xx_init_late(void)
+{
+	omap2_common_pm_late_init();
+}
+
 #endif
 
 
Signature · 1 line
1.7.9.5
#6 lore raw

PATCH v6 6/15 ARM: OMAP3+: use cpu0-cpufreq driver in device tree supported boot

In reply to Nishanth Menon

With OMAP3+ and AM33xx supported SoC having defined CPU device tree entries with operating-points and clock nodes defined, we can now use the SoC generic cpufreq-cpu0 driver by registering appropriate device.

Cc Benoit Cousson <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Paul Walmsley <[email protected]>
Cc Tony Lindgren <[email protected]>
---
 arch/arm/mach-omap2/pm.c |   12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
arch/arm/mach-omap2/pm.c +9 -3
index e742118..360b2da 100644
@@ -266,7 +266,12 @@ static void __init omap4_init_voltages(void)
 
 static inline void omap_init_cpufreq(void)
 {
-	struct platform_device_info devinfo = { .name = "omap-cpufreq", };
+	struct platform_device_info devinfo = { };
+
+	if (!of_have_populated_dt())
+		devinfo.name = "omap-cpufreq";
+	else
+		devinfo.name = "cpufreq-cpu0";
 	platform_device_register_full(&devinfo);
 }
 
@@ -300,10 +305,11 @@ int __init omap2_common_pm_late_init(void)
 		/* Smartreflex device init */
 		omap_devinit_smartreflex();
 
-		/* cpufreq dummy device instantiation */
-		omap_init_cpufreq();
 	}
 
+	/* cpufreq dummy device instantiation */
+	omap_init_cpufreq();
+
 #ifdef CONFIG_SUSPEND
 	suspend_set_ops(&omap_pm_ops);
 #endif
Signature · 1 line
1.7.9.5
#7 lore raw

PATCH v6 7/15 ARM: dts: omap5-uevm: add smps123 supply for CPU

In reply to Nishanth Menon

regulator smps123 supply from Palmas PMIC powers CPU0 on OMAP5uEVM.

Based on a patch by J Keerthy <[email protected]>

---
 arch/arm/boot/dts/omap5-uevm.dts |    4 ++++
 arch/arm/boot/dts/omap5.dtsi     |    2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)
arch/arm/boot/dts/omap5-uevm.dts +4 -0
index d784b3a..3188511 100644
@@ -503,3 +503,7 @@
         pinctrl-names = "default";
         pinctrl-0 = <&uart5_pins>;
 };
+
+&cpu0 {
+	cpu0-supply = <&smps123_reg>;
+};
arch/arm/boot/dts/omap5.dtsi +1 -1
index 86295d2..2e83e24 100644
@@ -33,7 +33,7 @@
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		cpu at 0 {
+		cpu0: cpu at 0 {
 			device_type = "cpu";
 			compatible = "arm,cortex-a15";
 			reg = <0x0>;
Signature · 1 line
1.7.9.5
#8 lore raw

PATCH v6 8/15 ARM: dts: dra7-evm: add smps123 supply for CPU

In reply to Nishanth Menon

From: J Keerthy <[email protected]>

regulator smps123 supply from Palmas PMIC powers CPU0 on DRA7 EVM.

[nm at ti.com: rebase to latest]
---
 arch/arm/boot/dts/dra7-evm.dts |    4 ++++
 arch/arm/boot/dts/dra7.dtsi    |    2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)
arch/arm/boot/dts/dra7-evm.dts +4 -0
index 3abf5f4..5babba0 100644
@@ -269,3 +269,7 @@
 	vmmc-supply = <&mmc2_3v3>;
 	bus-width = <8>;
 };
+
+&cpu0 {
+	cpu0-supply = <&smps123_reg>;
+};
arch/arm/boot/dts/dra7.dtsi +1 -1
index c98997b..02e430b 100644
@@ -32,7 +32,7 @@
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		cpu at 0 {
+		cpu0: cpu at 0 {
 			device_type = "cpu";
 			compatible = "arm,cortex-a15";
 			reg = <0>;
Signature · 1 line
1.7.9.5
#9 lore raw

PATCH v6 9/15 ARM: dts: OMAP5: Add CPU OPP table

In reply to Nishanth Menon

From: J Keerthy <[email protected]>

Add DT OPP table for OMAP54xx family of devices. This data is decoded by OF with of_init_opp_table() helper function.

The data is based on OMAP543x ES2.0 DM Operating Condition Addendum Version 0.6(April 2013)

NOTE: The voltage and frequency values work well only on NOM samples and are supposed to work properly only with ABB/AVS for ALL OPPs.

TODO: Add SPEED BIN OPP after ABB and AVS support so the cpufreq works on all samples seamlessly. Clock node is pending alignment for clock dts conversion

[nm at ti.com: sync to latest and fixes]
---
 arch/arm/boot/dts/omap5.dtsi |    7 +++++++
 1 file changed, 7 insertions(+)
arch/arm/boot/dts/omap5.dtsi +7 -0
index 2e83e24..4be15e0 100644
@@ -37,6 +37,13 @@
 			device_type = "cpu";
 			compatible = "arm,cortex-a15";
 			reg = <0x0>;
+
+			operating-points = <
+				/* kHz    uV */
+				500000  880000
+				1000000 1060000
+				1500000 1250000
+			>;
 		};
 		cpu at 1 {
 			device_type = "cpu";
Signature · 1 line
1.7.9.5
#10 lore raw

PATCH v6 10/15 ARM: dts: DRA7: Add CPU OPP table

In reply to Nishanth Menon

From: J Keerthy <[email protected]>

Add DT OPP table for DRA7xx family of devices. This data is decoded by OF with of_init_opp_table() helper function.

The data is based on DRA75x, DRA74x Data Manual revision F (Sept 2013).

TODO: add OPP_HIGH after AVS-Class0 is functional
NOTE: The voltage and frequency values work well only on NOM samples and it is mandatory to use ABB/AVS Class 0 support for all OPPs.

Clock nodes are pending clock node alignment.

[nm at ti.com: cleanups and rebase to latest]
---
 arch/arm/boot/dts/dra7.dtsi |    6 ++++++
 1 file changed, 6 insertions(+)
arch/arm/boot/dts/dra7.dtsi +6 -0
index 02e430b..92cbe3b 100644
@@ -36,6 +36,12 @@
 			device_type = "cpu";
 			compatible = "arm,cortex-a15";
 			reg = <0>;
+
+			operating-points = <
+				/* kHz    uV */
+				1000000	1060000
+				1176000	1160000
+				>;
 		};
 		cpu at 1 {
 			device_type = "cpu";
Signature · 1 line
1.7.9.5
#11 lore raw

Re: [PATCH V6 02/15] ARM: OMAP2+: AM33XX: add lateinit hook for calling pm late init

In reply to Nishanth Menon
Quoted 20 lines · Nishanth Menon

Call OMAP2+ generic lateinit hook from AM specific late init hook. This allows the generic late initializations such as cpufreq hooks to be active.

Cc Benoit Cousson <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Paul Walmsley <[email protected]>
Cc Tony Lindgren <[email protected]>
---
 arch/arm/mach-omap2/board-generic.c |    1 +
 arch/arm/mach-omap2/common.h        |    1 +
 arch/arm/mach-omap2/io.c            |    6 ++++++
 3 files changed, 8 insertions(+)
arch/arm/mach-omap2/board-generic.c +0 -0
index 87162e1..b474498 100644

arch/arm/mach-omap2/board-generic.c DT_MACHINE_START(AM33XX_DT, "Generic AM33XX (Flattened Device Tree)") · line 183

Quoted 4 lines
arch/arm/mach-omap2/board-generic.c +1 -0
@@ -180,6 +180,7 @@ DT_MACHINE_START(AM33XX_DT, "Generic AM33XX (Flattened Device Tree)")
 	.init_irq	= omap_intc_of_init,
 	.handle_irq	= omap3_intc_handle_irq,
 	.init_machine	= omap_generic_init,
+	.init_late	= am33xx_init_late,

Instead of adding a new a *_init_late function for every platform, perhaps better to just do:
.init_late = omap2_common_pm_late_init;

since that's the only function you're calling.

Later if more functions are added, then it can be wrapped around.

regards,

-Joel

#12 lore raw

Re: [PATCH V6 02/15] ARM: OMAP2+: AM33XX: add lateinit hook for calling pm late init

Quoted 30 lines · Joel Fernandes
Quoted 20 lines · Nishanth Menon

Call OMAP2+ generic lateinit hook from AM specific late init hook. This allows the generic late initializations such as cpufreq hooks to be active.

Cc Benoit Cousson <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Paul Walmsley <[email protected]>
Cc Tony Lindgren <[email protected]>
---
 arch/arm/mach-omap2/board-generic.c |    1 +
 arch/arm/mach-omap2/common.h        |    1 +
 arch/arm/mach-omap2/io.c            |    6 ++++++
 3 files changed, 8 insertions(+)
arch/arm/mach-omap2/board-generic.c +0 -0
index 87162e1..b474498 100644

arch/arm/mach-omap2/board-generic.c DT_MACHINE_START(AM33XX_DT, "Generic AM33XX (Flattened Device Tree)") · line 183

Quoted 4 lines
arch/arm/mach-omap2/board-generic.c +1 -0
@@ -180,6 +180,7 @@ DT_MACHINE_START(AM33XX_DT, "Generic AM33XX (Flattened Device Tree)")
 	.init_irq	= omap_intc_of_init,
 	.handle_irq	= omap3_intc_handle_irq,
 	.init_machine	= omap_generic_init,
+	.init_late	= am33xx_init_late,

Instead of adding a new a *_init_late function for every platform, perhaps better to just do:
.init_late = omap2_common_pm_late_init;

Quoted 3 lines

since that's the only function you're calling.

Later if more functions are added, then it can be wrapped around.

And what benefit would that give us? we break consistency of functions available in io.c, considering the work we have already done in out-of-tree patches on ti-forks, we *do know* that there is more incoming and has to be done anyways, I prefer having symmetric functions and a placeholder that folks can add on to.

Signature · 2 lines
Regards,
Nishanth Menon
#13 lore raw

Re: [PATCH V6 02/15] ARM: OMAP2+: AM33XX: add lateinit hook for calling pm late init

Quoted 33 lines · Nishanth Menon
Quoted 32 lines · Joel Fernandes
Quoted 20 lines · Nishanth Menon

Call OMAP2+ generic lateinit hook from AM specific late init hook. This allows the generic late initializations such as cpufreq hooks to be active.

Cc Benoit Cousson <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Paul Walmsley <[email protected]>
Cc Tony Lindgren <[email protected]>
---
 arch/arm/mach-omap2/board-generic.c |    1 +
 arch/arm/mach-omap2/common.h        |    1 +
 arch/arm/mach-omap2/io.c            |    6 ++++++
 3 files changed, 8 insertions(+)
arch/arm/mach-omap2/board-generic.c +0 -0
index 87162e1..b474498 100644

arch/arm/mach-omap2/board-generic.c DT_MACHINE_START(AM33XX_DT, "Generic AM33XX (Flattened Device Tree)") · line 183

Quoted 4 lines
arch/arm/mach-omap2/board-generic.c +1 -0
@@ -180,6 +180,7 @@ DT_MACHINE_START(AM33XX_DT, "Generic AM33XX (Flattened Device Tree)")
 	.init_irq	= omap_intc_of_init,
 	.handle_irq	= omap3_intc_handle_irq,
 	.init_machine	= omap_generic_init,
+	.init_late	= am33xx_init_late,

Instead of adding a new a *_init_late function for every platform, perhaps better to just do:
.init_late = omap2_common_pm_late_init;

since that's the only function you're calling.

Quoted 8 lines
Quoted 1 line

Later if more functions are added, then it can be wrapped around.

And what benefit would that give us? we break consistency of functions available in io.c, considering the work we have already done in out-of-tree patches on ti-forks, we *do know* that there is more incoming and has to be done anyways, I prefer having symmetric functions and a placeholder that folks can add on to.

Ok, sure if you think such placeholders are right way and there's more code later to be added to init_late callbacks.

Adding 6 lines of identical code for every platform seems redundant, I'd just define an omap_common_late_init for all platforms for now, and then fork off for the future differences. That way we save on LOC and readability in the header as well. Your call.

thanks,

-Joel

#14 lore raw

Re: [PATCH V6 02/15] ARM: OMAP2+: AM33XX: add lateinit hook for calling pm late init

Quoted 43 lines · Joel Fernandes
Quoted 33 lines · Nishanth Menon
Quoted 32 lines · Joel Fernandes
Quoted 20 lines · Nishanth Menon

Call OMAP2+ generic lateinit hook from AM specific late init hook. This allows the generic late initializations such as cpufreq hooks to be active.

Cc Benoit Cousson <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Paul Walmsley <[email protected]>
Cc Tony Lindgren <[email protected]>
---
 arch/arm/mach-omap2/board-generic.c |    1 +
 arch/arm/mach-omap2/common.h        |    1 +
 arch/arm/mach-omap2/io.c            |    6 ++++++
 3 files changed, 8 insertions(+)
arch/arm/mach-omap2/board-generic.c +0 -0
index 87162e1..b474498 100644

arch/arm/mach-omap2/board-generic.c DT_MACHINE_START(AM33XX_DT, "Generic AM33XX (Flattened Device Tree)") · line 183

Quoted 4 lines
arch/arm/mach-omap2/board-generic.c +1 -0
@@ -180,6 +180,7 @@ DT_MACHINE_START(AM33XX_DT, "Generic AM33XX (Flattened Device Tree)")
 	.init_irq	= omap_intc_of_init,
 	.handle_irq	= omap3_intc_handle_irq,
 	.init_machine	= omap_generic_init,
+	.init_late	= am33xx_init_late,

Instead of adding a new a *_init_late function for every platform, perhaps better to just do:
.init_late = omap2_common_pm_late_init;

since that's the only function you're calling.

Quoted 8 lines
Quoted 1 line

Later if more functions are added, then it can be wrapped around.

And what benefit would that give us? we break consistency of functions available in io.c, considering the work we have already done in out-of-tree patches on ti-forks, we *do know* that there is more incoming and has to be done anyways, I prefer having symmetric functions and a placeholder that folks can add on to.

Quoted 7 lines

Ok, sure if you think such placeholders are right way and there's more code later to be added to init_late callbacks.

Adding 6 lines of identical code for every platform seems redundant, I'd just define an omap_common_late_init for all platforms for now, and then fork off for the future differences. That way we save on LOC and readability in the header as well. Your call.

I see a function of that name already exists. I guess you can leave your patch as is then and not have to do this.

regards,

-Joel

#15 lore raw

Re: [PATCH V6 02/15] ARM: OMAP2+: AM33XX: add lateinit hook for calling pm late init

Quoted 2 lines · Joel Fernandes

I see a function of that name already exists. I guess you can leave your patch as is then and not have to do this.

Can I consider that as an Acked-by :) ?
Regards,
Nishanth Menon

#16 lore raw

Re: [PATCH V6 02/15] ARM: OMAP2+: AM33XX: add lateinit hook for calling pm late init

Quoted 6 lines · Nishanth Menon
Quoted 2 lines · Joel Fernandes

I see a function of that name already exists. I guess you can leave your patch as is then and not have to do this.

Can I consider that as an Acked-by :) ?

Yes, sure, for this particular patch:

thanks,

-Joel

maintainer
#17 lore raw

Re: [PATCH V6 02/15] ARM: OMAP2+: AM33XX: add lateinit hook for calling pm late init

In reply to Joel Fernandes
Quoted 9 lines · Joel Fernandes
Quoted 5 lines · Joel Fernandes

Adding 6 lines of identical code for every platform seems redundant, I'd just define an omap_common_late_init for all platforms for now, and then fork off for the future differences. That way we save on LOC and readability in the header as well. Your call.

I see a function of that name already exists. I guess you can leave your patch as is then and not have to do this.

Yeah but why not just call the common late_init function directly for the cases where we know it's never needed.

If thoses will be populated in the later patches, then it's OK to add them.

In any case, Nishant, can you please squash the late_init patches into a single patch and make sure it also applies on top of the omap-for-v3.13/quirk branch as there's been some changes to board-generic.c there.

Regards,

Tony

#18 lore raw

Re: [PATCH V6 02/15] ARM: OMAP2+: AM33XX: add lateinit hook for calling pm late init

In reply to Joel Fernandes

Hi Joel.

Quoted 30 lines · Joel Fernandes
Quoted 20 lines · Nishanth Menon

Call OMAP2+ generic lateinit hook from AM specific late init hook. This allows the generic late initializations such as cpufreq hooks to be active.

Cc Benoit Cousson <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Paul Walmsley <[email protected]>
Cc Tony Lindgren <[email protected]>
---
 arch/arm/mach-omap2/board-generic.c |    1 +
 arch/arm/mach-omap2/common.h        |    1 +
 arch/arm/mach-omap2/io.c            |    6 ++++++
 3 files changed, 8 insertions(+)
arch/arm/mach-omap2/board-generic.c +0 -0
index 87162e1..b474498 100644

arch/arm/mach-omap2/board-generic.c DT_MACHINE_START(AM33XX_DT, "Generic AM33XX (Flattened Device Tree)") · line 183

Quoted 4 lines
arch/arm/mach-omap2/board-generic.c +1 -0
@@ -180,6 +180,7 @@ DT_MACHINE_START(AM33XX_DT, "Generic AM33XX (Flattened Device Tree)")
      .init_irq       = omap_intc_of_init,
      .handle_irq     = omap3_intc_handle_irq,
      .init_machine   = omap_generic_init,
+     .init_late      = am33xx_init_late,

Instead of adding a new a *_init_late function for every platform, perhaps better to just do:
.init_late = omap2_common_pm_late_init;

Quoted 2 lines

since that's the only function you're calling.

For now...

As the PM support gets added there will be other function calls and that can and is at times soc specific.

Regards,
Vaibhav

#19 lore raw

PATCH v6 2/15 ARM: OMAP2+: AM33XX: add lateinit hook for calling pm late init

In reply to Nishanth Menon

Call OMAP2+ generic lateinit hook from AM specific late init hook. This allows the generic late initializations such as cpufreq hooks to be active.

Cc Benoit Cousson <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Paul Walmsley <[email protected]>
Cc Tony Lindgren <[email protected]>
---
 arch/arm/mach-omap2/board-generic.c |    1 +
 arch/arm/mach-omap2/common.h        |    1 +
 arch/arm/mach-omap2/io.c            |    6 ++++++
 3 files changed, 8 insertions(+)
arch/arm/mach-omap2/board-generic.c +1 -0
index 87162e1..b474498 100644
@@ -180,6 +180,7 @@ DT_MACHINE_START(AM33XX_DT, "Generic AM33XX (Flattened Device Tree)")
 	.init_irq	= omap_intc_of_init,
 	.handle_irq	= omap3_intc_handle_irq,
 	.init_machine	= omap_generic_init,
+	.init_late	= am33xx_init_late,
 	.init_time	= omap3_gptimer_timer_init,
 	.dt_compat	= am33xx_boards_compat,
 	.restart	= am33xx_restart,
arch/arm/mach-omap2/common.h +1 -0
index 4a5684b..049c58d 100644
@@ -109,6 +109,7 @@ void omap35xx_init_late(void);
 void omap3630_init_late(void);
 void am35xx_init_late(void);
 void ti81xx_init_late(void);
+void am33xx_init_late(void);
 int omap2_common_pm_late_init(void);
 void dra7xx_init_early(void);
 
arch/arm/mach-omap2/io.c +6 -0
index a9896ea..38678bf 100644
@@ -594,6 +594,12 @@ void __init am33xx_init_early(void)
 	omap_hwmod_init_postsetup();
 	omap_clk_init = am33xx_dt_clk_init;
 }
+
+void __init am33xx_init_late(void)
+{
+	omap2_common_pm_late_init();
+}
+
 #endif
 
 #ifdef CONFIG_SOC_AM43XX
Signature · 1 line
1.7.9.5
#20 lore raw

PATCH v6 3/15 ARM: OMAP2+: AM43XX: add lateinit hook for calling pm late init

Call OMAP2+ generic lateinit hook from AM43x specific late init hook. This allows the generic late initializations such as cpufreq hooks to be active.

Cc Benoit Cousson <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Paul Walmsley <[email protected]>
Cc Tony Lindgren <[email protected]>
---
 arch/arm/mach-omap2/board-generic.c |    1 +
 arch/arm/mach-omap2/common.h        |    1 +
 arch/arm/mach-omap2/io.c            |    6 ++++++
 3 files changed, 8 insertions(+)
arch/arm/mach-omap2/board-generic.c +1 -0
index b474498..d4371c7 100644
@@ -235,6 +235,7 @@ static const char *am43_boards_compat[] __initdata = {
 DT_MACHINE_START(AM43_DT, "Generic AM43 (Flattened Device Tree)")
 	.map_io		= am33xx_map_io,
 	.init_early	= am43xx_init_early,
+	.init_late	= am43xx_init_late,
 	.init_irq	= omap_gic_of_init,
 	.init_machine	= omap_generic_init,
 	.init_time	= omap3_sync32k_timer_init,
arch/arm/mach-omap2/common.h +1 -0
index 049c58d..09f6736 100644
@@ -98,6 +98,7 @@ void am35xx_init_early(void);
 void ti81xx_init_early(void);
 void am33xx_init_early(void);
 void am43xx_init_early(void);
+void am43xx_init_late(void);
 void omap4430_init_early(void);
 void omap5_init_early(void);
 void omap3_init_late(void);	/* Do not use this one */
arch/arm/mach-omap2/io.c +6 -0
index 38678bf..300eac0 100644
@@ -613,6 +613,12 @@ void __init am43xx_init_early(void)
 	omap2_set_globals_cm(AM33XX_L4_WK_IO_ADDRESS(AM43XX_PRCM_BASE), NULL);
 	omap3xxx_check_revision();
 }
+
+void __init am43xx_init_late(void)
+{
+	omap2_common_pm_late_init();
+}
+
 #endif
 
 #ifdef CONFIG_ARCH_OMAP4
Signature · 1 line
1.7.9.5
#21 lore raw

PATCH v6 4/15 ARM: OMAP2+: OMAP5: add lateinit hook for calling pm late init

In reply to Nishanth Menon

Call OMAP2+ generic lateinit hook from AM specific late init hook. This allows the generic late initializations such as cpufreq hooks to be active.

Cc Benoit Cousson <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Paul Walmsley <[email protected]>
Cc Tony Lindgren <[email protected]>
---
 arch/arm/mach-omap2/board-generic.c |    1 +
 arch/arm/mach-omap2/common.h        |    1 +
 arch/arm/mach-omap2/io.c            |    6 ++++++
 3 files changed, 8 insertions(+)
arch/arm/mach-omap2/board-generic.c +1 -0
index d4371c7..67dbae2 100644
@@ -220,6 +220,7 @@ DT_MACHINE_START(OMAP5_DT, "Generic OMAP5 (Flattened Device Tree)")
 	.init_early	= omap5_init_early,
 	.init_irq	= omap_gic_of_init,
 	.init_machine	= omap_generic_init,
+	.init_late	= omap5_init_late,
 	.init_time	= omap5_realtime_timer_init,
 	.dt_compat	= omap5_boards_compat,
 	.restart	= omap44xx_restart,
arch/arm/mach-omap2/common.h +1 -0
index 09f6736..ceb208b 100644
@@ -111,6 +111,7 @@ void omap3630_init_late(void);
 void am35xx_init_late(void);
 void ti81xx_init_late(void);
 void am33xx_init_late(void);
+void omap5_init_late(void);
 int omap2_common_pm_late_init(void);
 void dra7xx_init_early(void);
 
arch/arm/mach-omap2/io.c +6 -0
index 300eac0..6226e0d 100644
@@ -675,6 +675,12 @@ void __init omap5_init_early(void)
 	omap_hwmod_init_postsetup();
 	omap_clk_init = omap5xxx_dt_clk_init;
 }
+
+void __init omap5_init_late(void)
+{
+	omap2_common_pm_late_init();
+}
+
 #endif
 
 #ifdef CONFIG_SOC_DRA7XX
Signature · 1 line
1.7.9.5
#22 lore raw

PATCH v6 5/15 ARM: OMAP2+: DRA7: add lateinit hook for calling pm late init

In reply to Nishanth Menon

Call OMAP2+ generic lateinit hook from DRA7 specific late init hook. This allows the generic late initializations such as cpufreq hooks to be active.

Cc Benoit Cousson <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Paul Walmsley <[email protected]>
Cc Tony Lindgren <[email protected]>
---
 arch/arm/mach-omap2/board-generic.c |    1 +
 arch/arm/mach-omap2/common.h        |    1 +
 arch/arm/mach-omap2/io.c            |    6 ++++++
 3 files changed, 8 insertions(+)
arch/arm/mach-omap2/board-generic.c +1 -0
index 67dbae2..c0b0848 100644
@@ -255,6 +255,7 @@ DT_MACHINE_START(DRA7XX_DT, "Generic DRA7XX (Flattened Device Tree)")
 	.smp		= smp_ops(omap4_smp_ops),
 	.map_io		= omap5_map_io,
 	.init_early	= dra7xx_init_early,
+	.init_late	= dra7xx_init_late,
 	.init_irq	= omap_gic_of_init,
 	.init_machine	= omap_generic_init,
 	.init_time	= omap5_realtime_timer_init,
arch/arm/mach-omap2/common.h +1 -0
index ceb208b..352fa9d 100644
@@ -114,6 +114,7 @@ void am33xx_init_late(void);
 void omap5_init_late(void);
 int omap2_common_pm_late_init(void);
 void dra7xx_init_early(void);
+void dra7xx_init_late(void);
 
 #ifdef CONFIG_SOC_BUS
 void omap_soc_device_init(void);
arch/arm/mach-omap2/io.c +6 -0
index 6226e0d..3b7b543 100644
@@ -702,6 +702,12 @@ void __init dra7xx_init_early(void)
 	omap_hwmod_init_postsetup();
 	omap_clk_init = dra7xx_dt_clk_init;
 }
+
+void __init dra7xx_init_late(void)
+{
+	omap2_common_pm_late_init();
+}
+
 #endif
 
 
Signature · 1 line
1.7.9.5
#23 lore raw

PATCH v6 6/15 ARM: OMAP3+: use cpu0-cpufreq driver in device tree supported boot

In reply to Nishanth Menon

With OMAP3+ and AM33xx supported SoC having defined CPU device tree entries with operating-points and clock nodes defined, we can now use the SoC generic cpufreq-cpu0 driver by registering appropriate device.

Cc Benoit Cousson <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Paul Walmsley <[email protected]>
Cc Tony Lindgren <[email protected]>
---
 arch/arm/mach-omap2/pm.c |   12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)
arch/arm/mach-omap2/pm.c +9 -3
index e742118..360b2da 100644
@@ -266,7 +266,12 @@ static void __init omap4_init_voltages(void)
 
 static inline void omap_init_cpufreq(void)
 {
-	struct platform_device_info devinfo = { .name = "omap-cpufreq", };
+	struct platform_device_info devinfo = { };
+
+	if (!of_have_populated_dt())
+		devinfo.name = "omap-cpufreq";
+	else
+		devinfo.name = "cpufreq-cpu0";
 	platform_device_register_full(&devinfo);
 }
 
@@ -300,10 +305,11 @@ int __init omap2_common_pm_late_init(void)
 		/* Smartreflex device init */
 		omap_devinit_smartreflex();
 
-		/* cpufreq dummy device instantiation */
-		omap_init_cpufreq();
 	}
 
+	/* cpufreq dummy device instantiation */
+	omap_init_cpufreq();
+
 #ifdef CONFIG_SUSPEND
 	suspend_set_ops(&omap_pm_ops);
 #endif
Signature · 1 line
1.7.9.5
#24 lore raw

PATCH v6 7/15 ARM: dts: omap5-uevm: add smps123 supply for CPU

In reply to Nishanth Menon

regulator smps123 supply from Palmas PMIC powers CPU0 on OMAP5uEVM.

Based on a patch by J Keerthy <[email protected]>

---
 arch/arm/boot/dts/omap5-uevm.dts |    4 ++++
 arch/arm/boot/dts/omap5.dtsi     |    2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)
arch/arm/boot/dts/omap5-uevm.dts +4 -0
index d784b3a..3188511 100644
@@ -503,3 +503,7 @@
         pinctrl-names = "default";
         pinctrl-0 = <&uart5_pins>;
 };
+
+&cpu0 {
+	cpu0-supply = <&smps123_reg>;
+};
arch/arm/boot/dts/omap5.dtsi +1 -1
index 86295d2..2e83e24 100644
@@ -33,7 +33,7 @@
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		cpu at 0 {
+		cpu0: cpu at 0 {
 			device_type = "cpu";
 			compatible = "arm,cortex-a15";
 			reg = <0x0>;
Signature · 1 line
1.7.9.5
#25 lore raw

PATCH v6 8/15 ARM: dts: dra7-evm: add smps123 supply for CPU

In reply to Nishanth Menon

From: J Keerthy <[email protected]>

regulator smps123 supply from Palmas PMIC powers CPU0 on DRA7 EVM.

[nm at ti.com: rebase to latest]
---
 arch/arm/boot/dts/dra7-evm.dts |    4 ++++
 arch/arm/boot/dts/dra7.dtsi    |    2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)
arch/arm/boot/dts/dra7-evm.dts +4 -0
index 3abf5f4..5babba0 100644
@@ -269,3 +269,7 @@
 	vmmc-supply = <&mmc2_3v3>;
 	bus-width = <8>;
 };
+
+&cpu0 {
+	cpu0-supply = <&smps123_reg>;
+};
arch/arm/boot/dts/dra7.dtsi +1 -1
index c98997b..02e430b 100644
@@ -32,7 +32,7 @@
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		cpu at 0 {
+		cpu0: cpu at 0 {
 			device_type = "cpu";
 			compatible = "arm,cortex-a15";
 			reg = <0>;
Signature · 1 line
1.7.9.5
#26 lore raw

PATCH v6 9/15 ARM: dts: OMAP5: Add CPU OPP table

In reply to Nishanth Menon

From: J Keerthy <[email protected]>

Add DT OPP table for OMAP54xx family of devices. This data is decoded by OF with of_init_opp_table() helper function.

The data is based on OMAP543x ES2.0 DM Operating Condition Addendum Version 0.6(April 2013)

NOTE: The voltage and frequency values work well only on NOM samples and are supposed to work properly only with ABB/AVS for ALL OPPs.

TODO: Add SPEED BIN OPP after ABB and AVS support so the cpufreq works on all samples seamlessly. Clock node is pending alignment for clock dts conversion

[nm at ti.com: sync to latest and fixes]
---
 arch/arm/boot/dts/omap5.dtsi |    7 +++++++
 1 file changed, 7 insertions(+)
arch/arm/boot/dts/omap5.dtsi +7 -0
index 2e83e24..4be15e0 100644
@@ -37,6 +37,13 @@
 			device_type = "cpu";
 			compatible = "arm,cortex-a15";
 			reg = <0x0>;
+
+			operating-points = <
+				/* kHz    uV */
+				500000  880000
+				1000000 1060000
+				1500000 1250000
+			>;
 		};
 		cpu at 1 {
 			device_type = "cpu";
Signature · 1 line
1.7.9.5
#27 lore raw

PATCH v6 11/15 ARM: dts: OMAP3: add clock nodes for CPU

In reply to Nishanth Menon

OMAP34xx and OMAP36xx platforms use dpll1 clock. Add same to common definition.

---
 arch/arm/boot/dts/omap3.dtsi |    5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/omap3.dtsi +5 -0
index 15370e9..942d607 100644
@@ -32,6 +32,11 @@
 			compatible = "arm,cortex-a8";
 			device_type = "cpu";
 			reg = <0x0>;
+
+			clocks = <&dpll1_ck>;
+			clock-names = "cpu";
+
+			clock-latency = <300000>; /* From omap-cpufreq driver */
 		};
 	};
 
Signature · 1 line
1.7.9.5
#28 lore raw

PATCH v6 12/15 ARM: dts: OMAP4: add clock nodes for CPU

In reply to Nishanth Menon

OMAP443x, OMAP446x and OMAP447x platforms use dpll_mpu clock. Add same to common definition.

---
 arch/arm/boot/dts/omap4.dtsi |    5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/omap4.dtsi +5 -0
index 6be1f56..27f1f3a 100644
@@ -32,6 +32,11 @@
 			device_type = "cpu";
 			next-level-cache = <&L2>;
 			reg = <0x0>;
+
+			clocks = <&dpll_mpu_ck>;
+			clock-names = "cpu";
+
+			clock-latency = <300000>; /* From omap-cpufreq driver */
 		};
 		cpu at 1 {
 			compatible = "arm,cortex-a9";
Signature · 1 line
1.7.9.5
#29 lore raw

PATCH v6 13/15 ARM: dts: AM33XX: add clock nodes for CPU

In reply to Nishanth Menon

AM33XX based platforms use dpll_mpu clock. Add same to common dtsi and remove the dummy clock node entry as AM33XX platform supports only device tree based boot.

Cc Benoit Cousson <[email protected]>
Cc Kevin Hilman <[email protected]>
Cc Paul Walmsley <[email protected]>
Cc Tony Lindgren <[email protected]>
---
 arch/arm/boot/dts/am33xx.dtsi |    4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/am33xx.dtsi +4 -0
index 2a994d6..09f16a0 100644
@@ -55,6 +55,10 @@
 				275000  1125000
 			>;
 			voltage-tolerance = <2>; /* 2 percentage */
+
+			clocks = <&dpll_mpu_ck>;
+			clock-names = "cpu";
+
 			clock-latency = <300000>; /* From omap-cpufreq driver */
 		};
 	};
Signature · 1 line
1.7.9.5
#30 lore raw

PATCH v6 14/15 ARM: dts: OMAP5: add clock nodes for CPU

In reply to Nishanth Menon

From: J Keerthy <[email protected]>

OMAP5 platforms use dpll_mpu_ck clock for CPU. Add same to common definition.

Cc Benoit Cousson <[email protected]>
[nm at ti.com: keep in sync with clock node changes]
---
 arch/arm/boot/dts/omap5.dtsi |    6 ++++++
 1 file changed, 6 insertions(+)
arch/arm/boot/dts/omap5.dtsi +6 -0
index 4be15e0..04a8fe3 100644
@@ -44,6 +44,12 @@
 				1000000 1060000
 				1500000 1250000
 			>;
+
+			clocks = <&dpll_mpu_ck>;
+			clock-names = "cpu";
+
+			clock-latency = <300000>; /* From omap-cpufreq driver */
+
 		};
 		cpu at 1 {
 			device_type = "cpu";
Signature · 1 line
1.7.9.5
#31 lore raw

PATCH v6 15/15 ARM: dts: DRA7: add clock nodes for CPU

In reply to Nishanth Menon

From: J Keerthy <[email protected]>

DRA7 platforms use dpll_mpu_ck clock for CPU. Add same to common definition.

Cc Benoit Cousson <[email protected]>
[nm at ti.com: keep in sync with clock node changes]
---
 arch/arm/boot/dts/dra7.dtsi |    5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/dra7.dtsi +5 -0
index 92cbe3b..e723b52 100644
@@ -42,6 +42,11 @@
 				1000000	1060000
 				1176000	1160000
 				>;
+
+			clocks = <&dpll_mpu_ck>;
+			clock-names = "cpu";
+
+			clock-latency = <300000>; /* From omap-cpufreq driver */
 		};
 		cpu at 1 {
 			device_type = "cpu";
Signature · 1 line
1.7.9.5
#32 lore raw
In reply to Nishanth Menon
Quoted 5 lines · Nishanth Menon

Hi,

The series is based on Tero's V8 of patches[1] - enables the use of cpufreq-cpu0 generic driver for all OMAP and related derivatives.

Quoted 7 lines

I will stop copy pasting the series complete history and point at [2].

Main changes since V5:
- no more clock driver as part of this series[3] - instead depend on clock conversion[1].
- added DRA7/OMAP5

I am having all kind of problems with my git mail setup atm - apologies if any patches have arrived twice/in weird sequence :(

Signature · 2 lines
Regards,
Nishanth Menon