serial: mxs_auart: Staticize local functions
PATCH 1/1 serial: mxs_auart: Staticize local functions
Staticize local functions in mxs_auart driver.
Signed-off-by Axel Lin <[email protected]>
--- drivers/serial/mxs_auart.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/serial/mxs_auart.c +5 -5
@@ -40,7 +40,7 @@ static struct mxs_uartapp_regs *get_uartapp_registers(void)* Sets the baud rate and settings. * The settings are: 8 data bits, no parit and 1 stop bit. */ -void mxs_auart_setbrg (void ) +static void mxs_auart_setbrg (void ) {u32 div;u32 linectrl =0 ;
@@ -77,7 +77,7 @@ void mxs_auart_setbrg(void)writel (linectrl, ®s->hw_uartapp_linectrl); } -int mxs_auart_init (void ) +static int mxs_auart_init (void ) {struct mxs_uartapp_regs *regs =get_uartapp_registers ();/* Reset everything */
@@ -99,7 +99,7 @@ int mxs_auart_init(void)return 0 ; } -void mxs_auart_putc (const char c) +static void mxs_auart_putc (const char c) {struct mxs_uartapp_regs *regs =get_uartapp_registers ();/* Wait in loop while the transmit FIFO is full */
@@ -112,14 +112,14 @@ void mxs_auart_putc(const char c)mxs_auart_putc ('\r' ); } -int mxs_auart_tstc (void ) +static int mxs_auart_tstc (void ) {struct mxs_uartapp_regs *regs =get_uartapp_registers ();/* Checks if receive FIFO is empty */ return !(readl (®s->hw_uartapp_stat) &UARTAPP_STAT_RXFE_MASK ); } -int mxs_auart_getc (void ) +static int mxs_auart_getc (void ) {struct mxs_uartapp_regs *regs =get_uartapp_registers ();/* Wait until a character is available to read */
Signature · 1 line
1.8.1.2
PATCH 1/1 serial: mxs_auart: Staticize local functions
Dear Axel Lin,
Quoted 3 lines
Staticize local functions in
mxs_auartdriver.Signed-off-by Axel Lin <[email protected]>
Acked-by Marek Vasut <[email protected]>
Just curious, how did you find this? Did you lint the files with some tool?
Quoted 42 lines
--- drivers/serial/mxs_auart.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)drivers/serial/mxs_auart.c +4
-4@@ -40,7 +40,7 @@ static struct mxs_uartapp_regs*get_uartapp_registers(void) * Sets the baud rate and settings. * The settings are: 8 data bits, no parit and 1 stop bit. */ -void mxs_auart_setbrg (void ) +static void mxs_auart_setbrg (void ) {u32 div;u32 linectrl =0 ;@@ -77,7 +77,7 @@ void mxs_auart_setbrg(void)writel (linectrl, ®s->hw_uartapp_linectrl); } -int mxs_auart_init (void ) +static int mxs_auart_init (void ) {struct mxs_uartapp_regs *regs =get_uartapp_registers ();/* Reset everything */ @@ -99,7 +99,7 @@ int mxs_auart_init(void)return 0 ; } -void mxs_auart_putc (const char c) +static void mxs_auart_putc (const char c) {struct mxs_uartapp_regs *regs =get_uartapp_registers ();/* Wait in loop while the transmit FIFO is full */ @@ -112,14 +112,14 @@ void mxs_auart_putc(const char c)mxs_auart_putc ('\r' ); } -int mxs_auart_tstc (void ) +static int mxs_auart_tstc (void ) {
drivers/serial/mxs_auart.c void mxs_auart_putc(const char c) · line 125
Quoted 10 lines
drivers/serial/mxs_auart.c +1
-1struct mxs_uartapp_regs *regs =get_uartapp_registers ();/* Checks if receive FIFO is empty */ return !(readl (®s->hw_uartapp_stat) &UARTAPP_STAT_RXFE_MASK ); } -int mxs_auart_getc (void ) +static int mxs_auart_getc (void ) {struct mxs_uartapp_regs *regs =get_uartapp_registers ();/* Wait until a character is available to read */
Best regards,
Marek Vasut
PATCH 1/1 serial: mxs_auart: Staticize local functions
2013/10/15 Marek Vasut <[email protected]>:
Quoted 9 lines
Dear Axel Lin,
Quoted 3 lines
Staticize local functions in
mxs_auartdriver.Signed-off-by Axel Lin <[email protected]>Acked-by Marek Vasut <[email protected]>Just curious, how did you find this? Did you lint the files with some tool?
I just read the code.
Regards,
Axel
Quoted 4 lines · Axel Lin
Staticize local functions in
mxs_auartdriver.Signed-off-by Axel Lin <[email protected]>Acked-by Marek Vasut <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131108/ba94798c/attachment.pgp>