Skip to contentSkip to conversation

serial: mxs_auart: Staticize local functions

PATCH In review Axel Lin 3 participants 4 messages Oct 15, 2013 – Nov 8, 2013 Arm i.MX and Layerscape

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 serial: mxs_auart: Staticize local functions

Staticize local functions in mxs_auart driver.

---
 drivers/serial/mxs_auart.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/serial/mxs_auart.c +5 -5
index 7cfe5bc..fc0fa96 100644
@@ -40,7 +40,7 @@ static struct mxs_uartapp_regs *get_uartapp_registers(void)
  * Sets the baud rate and settings.
  * The settings are: 8 data bits, no parit and 1 stop bit.
  */
-void mxs_auart_setbrg(void)
+static void mxs_auart_setbrg(void)
 {
 	u32 div;
 	u32 linectrl = 0;
@@ -77,7 +77,7 @@ void mxs_auart_setbrg(void)
 	writel(linectrl, &regs->hw_uartapp_linectrl);
 }
 
-int mxs_auart_init(void)
+static int mxs_auart_init(void)
 {
 	struct mxs_uartapp_regs *regs = get_uartapp_registers();
 	/* Reset everything */
@@ -99,7 +99,7 @@ int mxs_auart_init(void)
 	return 0;
 }
 
-void mxs_auart_putc(const char c)
+static void mxs_auart_putc(const char c)
 {
 	struct mxs_uartapp_regs *regs = get_uartapp_registers();
 	/* Wait in loop while the transmit FIFO is full */
@@ -112,14 +112,14 @@ void mxs_auart_putc(const char c)
 		mxs_auart_putc('\r');
 }
 
-int mxs_auart_tstc(void)
+static int mxs_auart_tstc(void)
 {
 	struct mxs_uartapp_regs *regs = get_uartapp_registers();
 	/* Checks if receive FIFO is empty */
 	return !(readl(&regs->hw_uartapp_stat) & UARTAPP_STAT_RXFE_MASK);
 }
 
-int mxs_auart_getc(void)
+static int mxs_auart_getc(void)
 {
 	struct mxs_uartapp_regs *regs = get_uartapp_registers();
 	/* Wait until a character is available to read */
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH 1/1 serial: mxs_auart: Staticize local functions

Dear Axel Lin,

Quoted 3 lines

Staticize local functions in mxs_auart driver.

Just curious, how did you find this? Did you lint the files with some tool?

Quoted 42 lines
---
 drivers/serial/mxs_auart.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/serial/mxs_auart.c +4 -4
index 7cfe5bc..fc0fa96 100644
@@ -40,7 +40,7 @@ static struct mxs_uartapp_regs
 *get_uartapp_registers(void) * Sets the baud rate and settings.
  * The settings are: 8 data bits, no parit and 1 stop bit.
  */
-void mxs_auart_setbrg(void)
+static void mxs_auart_setbrg(void)
 {
 	u32 div;
 	u32 linectrl = 0;
@@ -77,7 +77,7 @@ void mxs_auart_setbrg(void)
 	writel(linectrl, &regs->hw_uartapp_linectrl);
 }
 
-int mxs_auart_init(void)
+static int mxs_auart_init(void)
 {
 	struct mxs_uartapp_regs *regs = get_uartapp_registers();
 	/* Reset everything */
@@ -99,7 +99,7 @@ int mxs_auart_init(void)
 	return 0;
 }
 
-void mxs_auart_putc(const char c)
+static void mxs_auart_putc(const char c)
 {
 	struct mxs_uartapp_regs *regs = get_uartapp_registers();
 	/* Wait in loop while the transmit FIFO is full */
@@ -112,14 +112,14 @@ void mxs_auart_putc(const char c)
 		mxs_auart_putc('\r');
 }
 
-int mxs_auart_tstc(void)
+static int mxs_auart_tstc(void)
 {

drivers/serial/mxs_auart.c void mxs_auart_putc(const char c) · line 125

Quoted 10 lines
drivers/serial/mxs_auart.c +1 -1
 	struct mxs_uartapp_regs *regs = get_uartapp_registers();
 	/* Checks if receive FIFO is empty */
 	return !(readl(&regs->hw_uartapp_stat) & UARTAPP_STAT_RXFE_MASK);
 }
 
-int mxs_auart_getc(void)
+static int mxs_auart_getc(void)
 {
 	struct mxs_uartapp_regs *regs = get_uartapp_registers();
 	/* Wait until a character is available to read */

Best regards,
Marek Vasut

#3 lore raw
In reply to Axel Lin
Quoted 4 lines · Axel Lin

Staticize local functions in mxs_auart driver.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131108/ba94798c/attachment.pgp>