ARM: dts: omap5-uevm: remove always_on, boot_on from smps10_out1
Subsystems (2)
PATCH 1/2 ARM: dts: omap5-uevm: remove always_on, boot_on from smps10_out1
smps10 should be enabled only in the case of host mode. So stop doing always_on, boot_on from smps10_out1. The driver will enable it in host mode.
--- arch/arm/boot/dts/omap5-uevm.dts | 2 -- 1 file changed, 2 deletions(-)
arch/arm/boot/dts/omap5-uevm.dts +0 -2
@@ -334,8 +334,6 @@ regulator-name = "smps10_out1"; regulator-min-microvolt = <5000000>; regulator-max-microvolt = <5000000>; - regulator-always-on; - regulator-boot-on; }; ldo1_reg: ldo1 {
Signature · 1 line
1.7.10.4
PATCH 2/2 ARM: dts: omap5: Add dr_mode for dwc3
From: George Cherian <[email protected]>
Added dr_mode property in dwc3 and set its default mode to device.
--- arch/arm/boot/dts/omap5.dtsi | 1 + 1 file changed, 1 insertion(+)
arch/arm/boot/dts/omap5.dtsi +1 -0
@@ -652,6 +652,7 @@ reg = <0x4a030000 0x10000>; interrupts = <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>; usb-phy = <&usb2_phy>, <&usb3_phy>; + dr_mode = "peripheral"; tx-fifo-resize; }; };
Signature · 1 line
1.7.10.4
Re: [PATCH 2/2] ARM: dts: omap5: Add dr_mode for dwc3
Hi,
Quoted 3 lines · Kishon Vijay Abraham I
From: George Cherian <[email protected]>
Added
dr_modeproperty in dwc3 and set its default mode to device.
If there is a specific reason why this is not set to "otg", we need to explain it here.
AFAIK the port is meant to be used as OTG port.
Quoted 13 lines
Signed-off-by George Cherian <[email protected]>Signed-off-by Kishon Vijay Abraham I <[email protected]>--- arch/arm/boot/dts/omap5.dtsi | 1 + 1 file changed, 1 insertion(+)arch/arm/boot/dts/omap5.dtsi +0
-0
arch/arm/boot/dts/omap5.dtsi line 658
Quoted 7 lines
arch/arm/boot/dts/omap5.dtsi +1
-0@@ -652,6 +652,7 @@ reg = <0x4a030000 0x10000>; interrupts = <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>; usb-phy = <&usb2_phy>, <&usb3_phy>; + dr_mode = "peripheral"; tx-fifo-resize; }; };
cheers,
-roger
PATCH v2 2/2 ARM: dts: omap5: Add dr_mode for dwc3
From: George Cherian <[email protected]>
Added dr_mode property in dwc3 and set its default mode to device. Currently dwc3 driver doesn't have support for OTG mode. So explicitly setting to peripheral even dwc3 is a OTG controller since OMAP5 has already got an EHCI host.
---
Changes from v1:
Changed the commit log to explain why dr_mode was not set to OTG.
arch/arm/boot/dts/omap5.dtsi | 1 + 1 file changed, 1 insertion(+)
arch/arm/boot/dts/omap5.dtsi +1 -0
@@ -652,6 +652,7 @@ reg = <0x4a030000 0x10000>; interrupts = <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>; usb-phy = <&usb2_phy>, <&usb3_phy>; + dr_mode = "peripheral"; tx-fifo-resize; }; };
Signature · 1 line
1.7.10.4
Re: [PATCH v2 2/2] ARM: dts: omap5: Add dr_mode for dwc3
Benoit,
Quoted 9 lines · Kishon Vijay Abraham I
From: George Cherian <[email protected]>
Added
dr_modeproperty in dwc3 and set its default mode to device. Currently dwc3 driver doesn't have support for OTG mode. So explicitly setting to peripheral even dwc3 is a OTG controller since OMAP5 has already got an EHCI host.Signed-off-by George Cherian <[email protected]>Signed-off-by Kishon Vijay Abraham I <[email protected]>
Can you take this patch for 3.13?
Thanks
Kishon
Quoted 19 lines
---
Changes from v1:
Changed the commit log to explain whydr_modewas not set to OTG.arch/arm/boot/dts/omap5.dtsi | 1 + 1 file changed, 1 insertion(+)arch/arm/boot/dts/omap5.dtsi +1
-0@@ -652,6 +652,7 @@ reg = <0x4a030000 0x10000>; interrupts = <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>; usb-phy = <&usb2_phy>, <&usb3_phy>; + dr_mode = "peripheral"; tx-fifo-resize; }; };
Re: [PATCH v2 2/2] ARM: dts: omap5: Add dr_mode for dwc3
Hi Kishon,
Quoted 10 lines · Kishon Vijay Abraham I
Benoit,
Quoted 7 lines · Kishon Vijay Abraham I
From: George Cherian <[email protected]>
Added
dr_modeproperty in dwc3 and set its default mode to device. Currently dwc3 driver doesn't have support for OTG mode. So explicitly setting to peripheral even dwc3 is a OTG controller since OMAP5 has already got an EHCI host.
Quoted 4 lines
Quoted 2 lines
Signed-off-by George Cherian <[email protected]>Signed-off-by Kishon Vijay Abraham I <[email protected]>Can you take this patch for 3.13?
I've just applied it.
Thanks,
Benoit
Signature · 4 lines
Beno?t Cousson BayLibre Embedded Linux Technology Lab www.baylibre.com
Re: [PATCH v2 2/2] ARM: dts: omap5: Add dr_mode for dwc3
Quoted 13 lines · Benoit Cousson
Hi Kishon,
Quoted 10 lines · Kishon Vijay Abraham I
Benoit,
Quoted 7 lines · Kishon Vijay Abraham I
From: George Cherian <[email protected]>
Added
dr_modeproperty in dwc3 and set its default mode to device. Currently dwc3 driver doesn't have support for OTG mode. So explicitly setting to peripheral even dwc3 is a OTG controller since OMAP5 has already got an EHCI host.
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Signed-off-by George Cherian <[email protected]>Signed-off-by Kishon Vijay Abraham I <[email protected]>Can you take this patch for 3.13?
I've just applied it.
Thanks :-)
-Kishon
Quoted 5 lines
Thanks,
Benoit
Re: [PATCH 2/2] ARM: dts: omap5: Add dr_mode for dwc3
In reply to Roger QuadrosQuoted 11 lines · Roger Quadros
Hi,
Quoted 3 lines · Kishon Vijay Abraham I
From: George Cherian <[email protected]>
Added
dr_modeproperty in dwc3 and set its default mode to device.If there is a specific reason why this is not set to "otg", we need to explain it here.
AFAIK the port is meant to be used as OTG port.
we still don't have the workaround for dual role ports, I've been working on it but still need to retest and make sure it's working fine before merging upstream.
Signature · 8 lines
balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140416/043d5888/attachment.sig>
Re: [PATCH 2/2] ARM: dts: omap5: Add dr_mode for dwc3
Quoted 8 lines · Felipe Balbi
Quoted 7 lines · Roger Quadros
Hi,
Quoted 3 lines · Kishon Vijay Abraham I
From: George Cherian <[email protected]>
Added
dr_modeproperty in dwc3 and set its default mode to device.
Quoted 8 lines
Quoted 4 lines
If there is a specific reason why this is not set to "otg", we need to explain it here.
AFAIK the port is meant to be used as OTG port.
we still don't have the workaround for dual role ports, I've been working on it but still need to retest and make sure it's working fine before merging upstream.
man, I went back in time. Nevermind :-)
Signature · 8 lines
balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140416/eea76e95/attachment.sig>
Re: [PATCH 2/2] ARM: dts: omap5: Add dr_mode for dwc3
In reply to Felipe BalbiHi Felipe, Roger
Quoted 8 lines · Felipe Balbi
Quoted 7 lines · Roger Quadros
Hi,
Quoted 3 lines · Kishon Vijay Abraham I
From: George Cherian <[email protected]>
Added
dr_modeproperty in dwc3 and set its default mode to device.
Quoted 9 lines
Quoted 4 lines
If there is a specific reason why this is not set to "otg", we need to explain it here.
AFAIK the port is meant to be used as OTG port.
we still don't have the workaround for dual role ports, I've been working on it but still need to retest and make sure it's working fine before merging upstream.
Does the OTG port suppose to work with OMAP5? I mean role switching mechanism?
I'm testing kernel v3.16 with OMAP5 based board (CM-T54).
If I set CONFIG_USB_DWC3_DUAL_ROLE, than nothing is going on when I plug some device/host cable into micro USB3.0 port (VBUS/ID detection with extcon events works fine).
CONFIG_USB_DWC3_HOST/CONFIG_USB_DWC3_GADGET bring port to appropriate mode and it works.
What is the purpose of setting dr_mode = "peripheral" in omap5.dtsi, since it is overridden by config options in dwc3_probe()?
Thank you in advance for the assistance,
Dmitry
Re: [PATCH 2/2] ARM: dts: omap5: Add dr_mode for dwc3
Quoted 24 lines · Dmitry Lifshitz
Hi Felipe, Roger
Quoted 8 lines · Felipe Balbi
Quoted 7 lines · Roger Quadros
Hi,
Quoted 3 lines · Kishon Vijay Abraham I
From: George Cherian <[email protected]>
Added
dr_modeproperty in dwc3 and set its default mode to device.Quoted 9 lines
Quoted 4 lines
If there is a specific reason why this is not set to "otg", we need to explain it here.
AFAIK the port is meant to be used as OTG port.
we still don't have the workaround for dual role ports, I've been working on it but still need to retest and make sure it's working fine before merging upstream.
Does the OTG port suppose to work with OMAP5? I mean role switching mechanism?
Quoted 7 lines
I'm testing kernel v3.16 with OMAP5 based board (CM-T54).
If I set
CONFIG_USB_DWC3_DUAL_ROLE, than nothing is going on when I plug some device/host cable into micro USB3.0 port (VBUS/ID detection with extcon events works fine).CONFIG_USB_DWC3_HOST/CONFIG_USB_DWC3_GADGET bring port to appropriate mode and it works.
What is the purpose of setting
dr_mode= "peripheral" inomap5.dtsi, since it is overridden by config options indwc3_probe()?
If dual role works it should be "otg" then. I'm not sure why it was set to peripheral. Maybe the role switching mechanism was not in place earlier.
George any objections for "otg"?
cheers,
-roger
Re: [PATCH 2/2] ARM: dts: omap5: Add dr_mode for dwc3
Hi Roger,
Thank you for a quick reply. See, my reply below.
Quoted 27 lines · Roger Quadros
Quoted 26 lines · Dmitry Lifshitz
Hi Felipe, Roger
Quoted 8 lines · Felipe Balbi
Quoted 7 lines · Roger Quadros
Hi,
Quoted 3 lines · Kishon Vijay Abraham I
From: George Cherian <[email protected]>
Added
dr_modeproperty in dwc3 and set its default mode to device.Quoted 9 lines
Quoted 4 lines
If there is a specific reason why this is not set to "otg", we need to explain it here.
AFAIK the port is meant to be used as OTG port.
we still don't have the workaround for dual role ports, I've been working on it but still need to retest and make sure it's working fine before merging upstream.
Does the OTG port suppose to work with OMAP5? I mean role switching mechanism?
I'm testing kernel v3.16 with OMAP5 based board (CM-T54).
Quoted 8 lines
Quoted 5 lines
If I set
CONFIG_USB_DWC3_DUAL_ROLE, than nothing is going on when I plug some device/host cable into micro USB3.0 port (VBUS/ID detection with extcon events works fine).CONFIG_USB_DWC3_HOST/CONFIG_USB_DWC3_GADGET bring port to appropriate mode and it works.
What is the purpose of setting
dr_mode= "peripheral" inomap5.dtsi, since it is overridden by config options indwc3_probe()?If dual role works it should be "otg" then. I'm not sure why it was set to peripheral. Maybe the role switching mechanism was not in place earlier.
This is what I have when setting dr_mode = "otg" (and compiling with CONFIG_USB_DWC3_DUAL_ROLE):
when load gadget driver and plugging host PC cable:
root at cm-debian:~# modprobe g_ether
using random self ethernet address
using random host ethernet address
usb0: HOST MAC fa:db:52:7f:95:c5
usb0: MAC be:75:8d:71:6d:02
using random self ethernet address
using random host ethernet addressg_ether gadget: Ethernet Gadget, version: Memorial Day 2008 g_ether gadget: g_ether ready
root at cm-debian:~# ------------[ cut here ]------------
WARNING: CPU: 0 PID: 65 at
/home/lifshitz/workroot/git-repo/OMAP5/omap5-kernel/drivers/bus/omap_l3_noc.c:147 l3_handle_target.isra.2+0x230/0x27c()
44000000.ocp:L3 Standard Error: MASTER UN IDENTIFIED TARGET OCMRAM (Read): At Address: 0x00000000 : Data Access in User mode during Functional access
Modules linked in: usb_f_eem g_ether usb_f_rndis libcomposite u_ether
configfs rfcomm ecb btmrvl_sdio btmrvl bluetooth mwifiex_sdio mwifiex dwc3 ahci_platform libahci_platform libahci libata snd_soc_cm_t54 ads7846 dwc3_omap extcon_palmas rtc_palmas extcon_class at24 snd_soc_wm8731 snd_soc_omap_mcbsp
CPU: 0 PID: 65 Comm: irq/39-palmas Tainted: G W
3.16.0-cm-t54+ #99
[<c00156d0>] (unwind_backtrace) from [<c00124ac>] (show_stack+0x10/0x14) [<c00124ac>] (show_stack) from [<c05e29dc>] (dump_stack+0x74/0x8c) [<c05e29dc>] (dump_stack) from [<c0037dbc>] (warn_slowpath_common+0x70/0x88) [<c0037dbc>] (warn_slowpath_common) from [<c0037e68>] (warn_slowpath_fmt+0x30/0x40)
[<c0037e68>] (warn_slowpath_fmt) from [<c02d88b8>] (l3_handle_target.isra.2+0x230/0x27c)
[<c02d88b8>] (l3_handle_target.isra.2) from [<c02d89b0>] (l3_interrupt_handler+0xac/0x13c)
[<c02d89b0>] (l3_interrupt_handler) from [<c007ea00>] (handle_irq_event_percpu+0x7c/0x230)
[<c007ea00>] (handle_irq_event_percpu) from [<c007ebf8>] (handle_irq_event+0x44/0x64)
[<c007ebf8>] (handle_irq_event) from [<c0081b78>] (handle_fasteoi_irq+0xa8/0x134)
[<c0081b78>] (handle_fasteoi_irq) from [<c007e398>] (generic_handle_irq+0x20/0x30)
[<c007e398>] (generic_handle_irq) from [<c000f4ac>] (handle_IRQ+0x40/0x90) [<c000f4ac>] (handle_IRQ) from [<c0008620>] (gic_handle_irq+0x2c/0x60) [<c0008620>] (gic_handle_irq) from [<c05eacc0>] (__irq_svc+0x40/0x50)
Exception stack(0xec939d80 to 0xec939dc8)
9d80: ecb729b0 20000013 00000000 00000001 ecb72800 eca1e000 00000000 ec939e44
9da0: ec939ed0 20000013 ecb72818 ed005e14 ec939ec8 ec939dc8 bf015f54 c05ea548
9dc0: 80000013 ffffffff
[<c05eacc0>] (__irq_svc) from [<c05ea548>] (_raw_spin_unlock_irqrestore+0x1c/0x20)
[<c05ea548>] (_raw_spin_unlock_irqrestore) from [<bf015f54>] (extcon_update_state+0x144/0x1c4 [extcon_class])
[<bf015f54>] (extcon_update_state [extcon_class]) from [<bf023288>] (palmas_vbus_irq_handler+0x64/0xa0 [extcon_palmas])
[<bf023288>] (palmas_vbus_irq_handler [extcon_palmas]) from [<c00815a8>] (handle_nested_irq+0xa0/0x10c)
[<c00815a8>] (handle_nested_irq) from [<c03ab85c>] (regmap_irq_thread+0x184/0x300)
[<c03ab85c>] (regmap_irq_thread) from [<c007f8b8>] (irq_thread_fn+0x1c/0x40) [<c007f8b8>] (irq_thread_fn) from [<c007f6a4>] (irq_thread+0x120/0x15c) [<c007f6a4>] (irq_thread) from [<c0056434>] (kthread+0xdc/0xf0) [<c0056434>] (kthread) from [<c000eb98>] (ret_from_fork+0x14/0x3c)
---[ end trace 3b365a734f7f3202 ]---
palmas-usb 48070000.i2c:palmas at 48:palmas_usb: USB cable is attached
when plugging storage device:
root at cm-debian:~# dmesg | tail -n20
...
omap-dwc3 4a020000.omap_dwc3: ID GND
palmas-usb 48070000.i2c:palmas at 48:palmas_usb: USB-HOST cable is attached palmas-usb 48070000.i2c:palmas at 48:palmas_usb: USB cable is attached
and nothing is going on.
Once again, when compiling with predefined role (CONFIG_USB_DWC3_HOST/CONFIG_USB_DWC3_GADGET) the port is functional in both modes.
I'm wondering, if dwc3_probe() callsdwc3_core_init_mode() -> dwc3_set_mode() than why it is not required in dwc3_omap_set_mailbox()?
Quoted 11 lines
George any objections for "otg"?
cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks,
Dmitry
Re: [PATCH 2/2] ARM: dts: omap5: Add dr_mode for dwc3
Hi,
Quoted 122 lines · Dmitry Lifshitz
Hi Roger,
Thank you for a quick reply. See, my reply below.
Quoted 27 lines · Roger Quadros
Quoted 26 lines · Dmitry Lifshitz
Hi Felipe, Roger
Quoted 8 lines · Felipe Balbi
Quoted 7 lines · Roger Quadros
Hi,
Quoted 3 lines · Kishon Vijay Abraham I
From: George Cherian <[email protected]>
Added
dr_modeproperty in dwc3 and set its default mode to device.Quoted 9 lines
Quoted 4 lines
If there is a specific reason why this is not set to "otg", we need to explain it here.
AFAIK the port is meant to be used as OTG port.
we still don't have the workaround for dual role ports, I've been working on it but still need to retest and make sure it's working fine before merging upstream.
Does the OTG port suppose to work with OMAP5? I mean role switching mechanism?
I'm testing kernel v3.16 with OMAP5 based board (CM-T54).
Quoted 8 lines
Quoted 5 lines
If I set
CONFIG_USB_DWC3_DUAL_ROLE, than nothing is going on when I plug some device/host cable into micro USB3.0 port (VBUS/ID detection with extcon events works fine).CONFIG_USB_DWC3_HOST/CONFIG_USB_DWC3_GADGET bring port to appropriate mode and it works.
What is the purpose of setting
dr_mode= "peripheral" inomap5.dtsi, since it is overridden by config options indwc3_probe()?If dual role works it should be "otg" then. I'm not sure why it was set to peripheral. Maybe the role switching mechanism was not in place earlier.
This is what I have when setting
dr_mode= "otg" (and compiling withCONFIG_USB_DWC3_DUAL_ROLE):when load gadget driver and plugging host PC cable:
root at cm-debian:~# modprobe
g_ether
using random self ethernet address
using random host ethernet address
usb0: HOST MAC fa:db:52:7f:95:c5
usb0: MAC be:75:8d:71:6d:02
using random self ethernet address
using random host ethernet addressg_ethergadget: Ethernet Gadget, version: Memorial Day 2008g_ethergadget:g_etherready
root at cm-debian:~# ------------[ cut here ]------------WARNING: CPU: 0 PID: 65 at /home/lifshitz/workroot/git-repo/OMAP5/omap5-kernel/drivers/bus/omap_l3_noc.c:147 l3_handle_target.isra.2+0x230/0x27c() 44000000.ocp:L3 Standard Error: MASTER UN IDENTIFIED TARGET OCMRAM (Read): At Address: 0x00000000 : Data Access in User mode during Functional access Modules linked in: usb_f_eem g_ether usb_f_rndis libcomposite u_etherconfigfs rfcomm ecb
btmrvl_sdiobtmrvl bluetoothmwifiex_sdiomwifiex dwc3ahci_platformlibahci_platformlibahci libatasnd_soc_cm_t54ads7846dwc3_omapextcon_palmasrtc_palmasextcon_classat24snd_soc_wm8731snd_soc_omap_mcbspCPU: 0 PID: 65 Comm: irq/39-palmas Tainted: G W 3.16.0-cm-t54+ #99 [<c00156d0>] (unwind_backtrace) from [<c00124ac>] (show_stack+0x10/0x14) [<c00124ac>] (show_stack) from [<c05e29dc>] (dump_stack+0x74/0x8c) [<c05e29dc>] (dump_stack) from [<c0037dbc>] (warn_slowpath_common+0x70/0x88)[<
c0037dbc>] (warn_slowpath_common) from [<c0037e68>] (warn_slowpath_fmt+0x30/0x40)
[<c0037e68>] (warn_slowpath_fmt) from [<c02d88b8>] (l3_handle_target.isra.2+0x230/0x27c)
[<c02d88b8>] (l3_handle_target.isra.2) from [<c02d89b0>] (l3_interrupt_handler+0xac/0x13c)
[<c02d89b0>] (l3_interrupt_handler) from [<c007ea00>] (handle_irq_event_percpu+0x7c/0x230)
[<c007ea00>] (handle_irq_event_percpu) from [<c007ebf8>] (handle_irq_event+0x44/0x64)
[<c007ebf8>] (handle_irq_event) from [<c0081b78>] (handle_fasteoi_irq+0xa8/0x134)
[<c0081b78>] (handle_fasteoi_irq) from [<c007e398>] (generic_handle_irq+0x20/0x30)
[<c007e398>] (generic_handle_irq) from [<c000f4ac>] (handle_IRQ+0x40/0x90) [<c000f4ac>] (handle_IRQ) from [<c0008620>] (gic_handle_irq+0x2c/0x60) [<c0008620>] (gic_handle_irq) from [<c05eacc0>] (__irq_svc+0x40/0x50)Exception stack(0xec939d80 to 0xec939dc8)9d80:
ecb729b020000013 00000000 00000001ecb72800eca1e00000000000ec939e44
9da0:ec939ed020000013ecb72818ed005e14ec939ec8ec939dc8bf015f54c05ea548
9dc0: 80000013 ffffffff
[<c05eacc0>] (__irq_svc) from [<c05ea548>] (_raw_spin_unlock_irqrestore+0x1c/0x20)
[<c05ea548>] (_raw_spin_unlock_irqrestore) from [<bf015f54>] (extcon_update_state+0x144/0x1c4[extcon_class])
[<bf015f54>] (extcon_update_state[extcon_class]) from [<bf023288>] (palmas_vbus_irq_handler+0x64/0xa0[extcon_palmas])
[<bf023288>] (palmas_vbus_irq_handler[extcon_palmas]) from [<c00815a8>] (handle_nested_irq+0xa0/0x10c)
[<c00815a8>] (handle_nested_irq) from [<c03ab85c>] (regmap_irq_thread+0x184/0x300)
[<c03ab85c>] (regmap_irq_thread) from [<c007f8b8>] (irq_thread_fn+0x1c/0x40) [<c007f8b8>] (irq_thread_fn) from [<c007f6a4>] (irq_thread+0x120/0x15c) [<c007f6a4>] (irq_thread) from [<c0056434>] (kthread+0xdc/0xf0) [<c0056434>] (kthread) from [<c000eb98>] (ret_from_fork+0x14/0x3c)---[ end trace 3b365a734f7f3202 ]---palmas-usb 48070000.i2c:palmas at 48:palmas_usb: USB cable is attached
when plugging storage device:
root at cm-debian:~# dmesg | tail -n20
...
omap-dwc3 4a020000.omap_dwc3: ID GND
palmas-usb 48070000.i2c:palmas at 48:palmas_usb: USB-HOST cable is attached palmas-usb 48070000.i2c:palmas at 48:palmas_usb: USB cable is attachedand nothing is going on.
Quoted 7 lines
Once again, when compiling with predefined role (CONFIG_USB_DWC3_HOST/CONFIG_USB_DWC3_GADGET) the port is functional in both modes.
I'm wondering, if
dwc3_probe()callsdwc3_core_init_mode()->dwc3_set_mode()than why it is not required indwc3_omap_set_mailbox()?
no, it's not required there. that mailbox is basically just telling the IP about VBUS levels and ID state. Nothing more.
Signature · 8 lines
balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140908/90bb298f/attachment-0001.sig>
Re: [PATCH 2/2] ARM: dts: omap5: Add dr_mode for dwc3
In reply to Dmitry LifshitzHi,
Quoted 22 lines · Dmitry Lifshitz
Hi Felipe, Roger
Quoted 8 lines · Felipe Balbi
Quoted 7 lines · Roger Quadros
Hi,
Quoted 3 lines · Kishon Vijay Abraham I
From: George Cherian <[email protected]>
Added
dr_modeproperty in dwc3 and set its default mode to device.Quoted 9 lines
Quoted 4 lines
If there is a specific reason why this is not set to "otg", we need to explain it here.
AFAIK the port is meant to be used as OTG port.
we still don't have the workaround for dual role ports, I've been working on it but still need to retest and make sure it's working fine before merging upstream.
Quoted 8 lines
Does the OTG port suppose to work with OMAP5? I mean role switching mechanism?
I'm testing kernel v3.16 with OMAP5 based board (CM-T54).
If I set
CONFIG_USB_DWC3_DUAL_ROLE, than nothing is going on when I plug some device/host cable into micro USB3.0 port (VBUS/ID detection with extcon events works fine).
Dual role does not work. We allow the driver to the built with both Host and Peripheral support because some platforms have more than one port and building the driver with dual role allows us to make one port host and one peripheral.
Signature · 8 lines
balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140908/5ab8a951/attachment.sig>
Re: [PATCH 2/2] ARM: dts: omap5: Add dr_mode for dwc3
Hi,
Quoted 30 lines · Felipe Balbi
Hi,
Quoted 27 lines · Dmitry Lifshitz
Hi Felipe, Roger
Quoted 8 lines · Felipe Balbi
Quoted 7 lines · Roger Quadros
Hi,
Quoted 3 lines · Kishon Vijay Abraham I
From: George Cherian <[email protected]>
Added
dr_modeproperty in dwc3 and set its default mode to device.Quoted 9 lines
Quoted 4 lines
If there is a specific reason why this is not set to "otg", we need to explain it here.
AFAIK the port is meant to be used as OTG port.
we still don't have the workaround for dual role ports, I've been working on it but still need to retest and make sure it's working fine before merging upstream.
Does the OTG port suppose to work with OMAP5? I mean role switching mechanism?
I'm testing kernel v3.16 with OMAP5 based board (CM-T54).
Quoted 9 lines
Quoted 3 lines
If I set
CONFIG_USB_DWC3_DUAL_ROLE, than nothing is going on when I plug some device/host cable into micro USB3.0 port (VBUS/ID detection with extcon events works fine).Dual role does not work. We allow the driver to the built with both Host and Peripheral support because some platforms have more than one port and building the driver with dual role allows us to make one port host and one peripheral.
Please, can you provide some detail about platforms with several ports. How do that ports are connected to DWC3?
Thanks,
Dmitry
Re: [PATCH 2/2] ARM: dts: omap5: Add dr_mode for dwc3
Quoted 37 lines · Dmitry Lifshitz
Hi,
Quoted 34 lines · Felipe Balbi
Hi,
Quoted 30 lines · Dmitry Lifshitz
Hi Felipe, Roger
Quoted 8 lines · Felipe Balbi
Quoted 7 lines · Roger Quadros
Hi,
Quoted 3 lines · Kishon Vijay Abraham I
From: George Cherian <[email protected]>
Added
dr_modeproperty in dwc3 and set its default mode to device.Quoted 9 lines
Quoted 4 lines
If there is a specific reason why this is not set to "otg", we need to explain it here.
AFAIK the port is meant to be used as OTG port.
we still don't have the workaround for dual role ports, I've been working on it but still need to retest and make sure it's working fine before merging upstream.
Does the OTG port suppose to work with OMAP5? I mean role switching mechanism?
I'm testing kernel v3.16 with OMAP5 based board (CM-T54).
If I set
CONFIG_USB_DWC3_DUAL_ROLE, than nothing is going on when I plug some device/host cable into micro USB3.0 port (VBUS/ID detection with extcon events works fine).
Quoted 8 lines
Quoted 5 lines
Dual role does not work. We allow the driver to the built with both Host and Peripheral support because some platforms have more than one port and building the driver with dual role allows us to make one port host and one peripheral.
Please, can you provide some detail about platforms with several ports. How do that ports are connected to DWC3?
you have several dwc3 instances.
Signature · 8 lines
balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140911/68eeddf3/attachment.sig>
Quoted 15 lines · Kishon Vijay Abraham I
smps10 should be enabled only in the case of host mode. So stop doing
always_on,boot_onfromsmps10_out1. The driver will enable it in host mode.Signed-off-by Kishon Vijay Abraham I <[email protected]>--- arch/arm/boot/dts/omap5-uevm.dts | 2 -- 1 file changed, 2 deletions(-)arch/arm/boot/dts/omap5-uevm.dts +0
-0
arch/arm/boot/dts/omap5-uevm.dts line 339
Quoted 8 lines
arch/arm/boot/dts/omap5-uevm.dts +0
-2@@ -334,8 +334,6 @@ regulator-name = "smps10_out1"; regulator-min-microvolt = <5000000>; regulator-max-microvolt = <5000000>; - regulator-always-on; - regulator-boot-on; }; ldo1_reg: ldo1 {
Always good to get rid of regulator-always-on. Thanks for it.
regulator-boot-on indicates that PMIC enables it by default as part of OTP or some internal behavior -> Looking at the measurements done on uEVM and OTP information -> regulator-boot-on should be kept here.
Hence Nak.
Signature · 2 lines
Regards, Nishanth Menon
Quoted 22 lines · Nishanth Menon
Quoted 21 lines · Kishon Vijay Abraham I
smps10 should be enabled only in the case of host mode. So stop doing
always_on,boot_onfromsmps10_out1. The driver will enable it in host mode.Signed-off-by Kishon Vijay Abraham I <[email protected]>--- arch/arm/boot/dts/omap5-uevm.dts | 2 -- 1 file changed, 2 deletions(-)arch/arm/boot/dts/omap5-uevm.dts +0
-2@@ -334,8 +334,6 @@ regulator-name = "smps10_out1"; regulator-min-microvolt = <5000000>; regulator-max-microvolt = <5000000>; - regulator-always-on; - regulator-boot-on; };
Quoted 7 lines
arch/arm/boot/dts/omap5-uevm.dts line 339
Quoted 2 lines
arch/arm/boot/dts/omap5-uevm.dts +0
-0ldo1_reg: ldo1 {Always good to get rid of regulator-always-on. Thanks for it.
regulator-boot-on indicates that PMIC enables it by default as part of OTP or some internal behavior -> Looking at the measurements done on uEVM and OTP information -> regulator-boot-on should be kept here.
No. Actually I don?t want PMIC to enable it by default. I want the palmas-usb driver to handle it.
Enabling it by default makes palmas-usb to detect VBUS interrupt. This should ideally be detected only when you connect a host cable.
Btw I didn't exactly get why you want regulator-boot-on should be kept here.
Thanks
Kishon
Quoted 10 lines · Kishon Vijay Abraham I
Quoted 4 lines
regulator-boot-on indicates that PMIC enables it by default as part of OTP or some internal behavior -> Looking at the measurements done on uEVM and OTP information -> regulator-boot-on should be kept here.
No. Actually I don?t want PMIC to enable it by default. I want the palmas-usb driver to handle it.
Enabling it by default makes palmas-usb to detect VBUS interrupt. This should ideally be detected only when you connect a host cable.
Btw I didn't exactly get why you want regulator-boot-on should be kept here.
binding description states:
- regulator-boot-on: bootloader/firmware enabled regulator Further info: include/linux/regulator/machine.h
* @boot_on: Set if the regulator is enabled when the system is initially
* started. If the regulator is not enabled by the hardware or * bootloader then it will be enabled when the constraints are * applied.
What that means is that it is enabled by firmware/bootloader (in our case One Time Program {OTP} inside Palmas) when the system switches on even before the kernel starts. and we know SMPS10 is autoenabled by Palmas OTP configuration even before first instruction in A15 executes.
I think you misunderstand this to mean that you'd like the regulator to be *switched on* automatically at kernel boot by regulator framework - there is no reasoning why we'd want such a binding since we'd expect drivers to do their job of requesting and enabling regulators on need..
Hope this helps. Let me know if I misunderstood something here.
Regards,
Nishanth Menon
Hi,
Quoted 20 lines · Nishanth Menon
Quoted 10 lines · Kishon Vijay Abraham I
Quoted 4 lines
regulator-boot-on indicates that PMIC enables it by default as part of OTP or some internal behavior -> Looking at the measurements done on uEVM and OTP information -> regulator-boot-on should be kept here.
No. Actually I don?t want PMIC to enable it by default. I want the palmas-usb driver to handle it.
Enabling it by default makes palmas-usb to detect VBUS interrupt. This should ideally be detected only when you connect a host cable.
Btw I didn't exactly get why you want regulator-boot-on should be kept here.binding description states:
- regulator-boot-on: bootloader/firmware enabled regulator Further info:include/linux/regulator/machine.h
* @boot_on: Set if the regulator is enabled when the system is initially* started. If the regulator is not enabled by the hardware or * bootloader then it will be enabled when the constraints are * applied.
Quoted 5 lines
What that means is that it is enabled by
firmware/bootloader(in our case One Time Program {OTP} inside Palmas) when the system switches on even before the kernel starts. and we know SMPS10 is autoenabled by Palmas OTP configuration even before first instruction in A15 executes.
Not sure about that. Please note SMPS10 has two outputs OUT1 and OUT2 and I tend to think that it might be OUT2 that's getting enabled by the OTP.
Quoted 6 lines
I think you misunderstand this to mean that you'd like the regulator to be *switched on* automatically at kernel boot by regulator framework - there is no reasoning why we'd want such a binding since we'd expect drivers to do their job of requesting and enabling regulators on need..
The comment you just quoted tells it enables the regulator if its not enabled by hardware. "If the regulator is not enabled by the hardware or bootloader then it will be enabled when the constraints are applied." At-least that's what I understood from that comment.
Also from our experiments it doesn't look like SMPS10_OUT1 is enabled by the OTP and it gets enabled when we have *regulator-boot-on* constraints.
Thanks
Kishon
Quoted 38 lines · Kishon Vijay Abraham I
Hi,
Quoted 20 lines · Nishanth Menon
Quoted 10 lines · Kishon Vijay Abraham I
Quoted 4 lines
regulator-boot-on indicates that PMIC enables it by default as part of OTP or some internal behavior -> Looking at the measurements done on uEVM and OTP information -> regulator-boot-on should be kept here.
No. Actually I don?t want PMIC to enable it by default. I want the palmas-usb driver to handle it.
Enabling it by default makes palmas-usb to detect VBUS interrupt. This should ideally be detected only when you connect a host cable.
Btw I didn't exactly get why you want regulator-boot-on should be kept here.binding description states:
- regulator-boot-on: bootloader/firmware enabled regulator Further info:include/linux/regulator/machine.h
* @boot_on: Set if the regulator is enabled when the system is initially* started. If the regulator is not enabled by the hardware or * bootloader then it will be enabled when the constraints are * applied.Quoted 5 lines
What that means is that it is enabled by
firmware/bootloader(in our case One Time Program {OTP} inside Palmas) when the system switches on even before the kernel starts. and we know SMPS10 is autoenabled by Palmas OTP configuration even before first instruction in A15 executes.Not sure about that. Please note SMPS10 has two outputs OUT1 and OUT2 and I tend to think that it might be OUT2 that's getting enabled by the OTP.
Quoted 6 lines
I think you misunderstand this to mean that you'd like the regulator to be *switched on* automatically at kernel boot by regulator framework - there is no reasoning why we'd want such a binding since we'd expect drivers to do their job of requesting and enabling regulators on need..
Quoted 7 lines
The comment you just quoted tells it enables the regulator if its not enabled by hardware. "If the regulator is not enabled by the hardware or bootloader then it will be enabled when the constraints are applied." At-least that's what I understood from that comment.
Also from our experiments it doesn't look like
SMPS10_OUT1is enabled by the OTP and it gets enabled when we have *regulator-boot-on* constraints.
btw.. I think this is the code in regulator fw that's responsible for enabling..
/* If the constraints say the regulator should be on at this point
* and we have control then make sure it is enabled.
*/
if ((rdev->constraints->always_on || rdev->constraints->boot_on) &&
ops->enable) {
ret = ops->enable(rdev);
if (ret < 0) {
rdev_err(rdev, "failed to enable\n");
goto out;
}
}Thanks
Kishon
Quoted 49 lines · Kishon Vijay Abraham I
Quoted 38 lines · Kishon Vijay Abraham I
Hi,
Quoted 20 lines · Nishanth Menon
Quoted 10 lines · Kishon Vijay Abraham I
Quoted 4 lines
regulator-boot-on indicates that PMIC enables it by default as part of OTP or some internal behavior -> Looking at the measurements done on uEVM and OTP information -> regulator-boot-on should be kept here.
No. Actually I don?t want PMIC to enable it by default. I want the palmas-usb driver to handle it.
Enabling it by default makes palmas-usb to detect VBUS interrupt. This should ideally be detected only when you connect a host cable.
Btw I didn't exactly get why you want regulator-boot-on should be kept here.binding description states:
- regulator-boot-on: bootloader/firmware enabled regulator Further info:include/linux/regulator/machine.h
* @boot_on: Set if the regulator is enabled when the system is initially* started. If the regulator is not enabled by the hardware or * bootloader then it will be enabled when the constraints are * applied.Quoted 5 lines
What that means is that it is enabled by
firmware/bootloader(in our case One Time Program {OTP} inside Palmas) when the system switches on even before the kernel starts. and we know SMPS10 is autoenabled by Palmas OTP configuration even before first instruction in A15 executes.Not sure about that. Please note SMPS10 has two outputs OUT1 and OUT2 and I tend to think that it might be OUT2 that's getting enabled by the OTP.
Quoted 6 lines
I think you misunderstand this to mean that you'd like the regulator to be *switched on* automatically at kernel boot by regulator framework - there is no reasoning why we'd want such a binding since we'd expect drivers to do their job of requesting and enabling regulators on need..
Quoted 7 lines
The comment you just quoted tells it enables the regulator if its not enabled by hardware. "If the regulator is not enabled by the hardware or bootloader then it will be enabled when the constraints are applied." At-least that's what I understood from that comment.
Also from our experiments it doesn't look like
SMPS10_OUT1is enabled by the OTP and it gets enabled when we have *regulator-boot-on* constraints.btw.. I think this is the code in regulator fw that's responsible for enabling..
Quoted 11 lines
/* If the constraints say the regulator should be on at this point
* and we have control then make sure it is enabled.
*/
if ((rdev->constraints->always_on || rdev->constraints->boot_on) &&
ops->enable) {
ret = ops->enable(rdev);
if (ret < 0) {
rdev_err(rdev, "failed to enable\n");
goto out;
}
}Drat, you are right, I did not really dig deep. thanks for correcting my understanding here.
I propose the following change in binding as it seems completely misleading to me.
(quoted diff) +0 -0
b/Documentation/devicetree/bindings/regulator/regulator.txt index 2bd8f09..d999f096 100644
Documentation/devicetree/bindings/regulator/regulator.txt +3 -1
@@ -8,7 +8,9 @@ Optional properties: - regulator-min-microamp: smallest current consumers may set - regulator-max-microamp: largest current consumers may set - regulator-always-on: boolean, regulator should never be disabled -- regulator-boot-on: bootloader/firmware enabled regulator +- regulator-boot-on: regulator is enabled when the system is initially started. + If the regulator is not enabled by the hardware or bootloader then it will be + enabled when the constraints are applied. - regulator-allow-bypass: allow the regulator to go into bypass mode - <name>-supply: phandle to the parent supply/regulator node - regulator-ramp-delay: ramp delay for regulator(in uV/uS)
Benoit,
Quoted 3 lines · Kishon Vijay Abraham I
smps10 should be enabled only in the case of host mode. So stop doing
always_on,boot_onfromsmps10_out1. The driver will enable it in host mode.
Can you take this patch too?
Thanks
Kishon
Quoted 20 lines
Signed-off-by Kishon Vijay Abraham I <[email protected]>--- arch/arm/boot/dts/omap5-uevm.dts | 2 -- 1 file changed, 2 deletions(-)arch/arm/boot/dts/omap5-uevm.dts +0
-2@@ -334,8 +334,6 @@ regulator-name = "smps10_out1"; regulator-min-microvolt = <5000000>; regulator-max-microvolt = <5000000>; - regulator-always-on; - regulator-boot-on; }; ldo1_reg: ldo1 {
Nishanth Menon
Acked-byQuoted 8 lines · Kishon Vijay Abraham I
Benoit,
Quoted 3 lines · Kishon Vijay Abraham I
smps10 should be enabled only in the case of host mode. So stop doing
always_on,boot_onfromsmps10_out1. The driver will enable it in host mode.Can you take this patch too?
Quoted 30 lines
Thanks
KishonQuoted 12 lines
Signed-off-by Kishon Vijay Abraham I <[email protected]>--- arch/arm/boot/dts/omap5-uevm.dts | 2 -- 1 file changed, 2 deletions(-)arch/arm/boot/dts/omap5-uevm.dts +0
-0arch/arm/boot/dts/omap5-uevm.dts line 339
Quoted 8 lines
arch/arm/boot/dts/omap5-uevm.dts +0
-2@@ -334,8 +334,6 @@ regulator-name = "smps10_out1"; regulator-min-microvolt = <5000000>; regulator-max-microvolt = <5000000>; - regulator-always-on; - regulator-boot-on; }; ldo1_reg: ldo1 {_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 2 lines
Regards, Nishanth Menon
Hi Kishon,
Quoted 11 lines · Nishanth Menon
Quoted 8 lines · Kishon Vijay Abraham I
Benoit,
Quoted 3 lines · Kishon Vijay Abraham I
smps10 should be enabled only in the case of host mode. So stop doing
always_on,boot_onfromsmps10_out1. The driver will enable it in host mode.Can you take this patch too?
Acked-by Nishanth Menon <[email protected]>
I've just applied it.
Thanks,
Benoit
Signature · 4 lines
Beno?t Cousson BayLibre Embedded Linux Technology Lab www.baylibre.com
Quoted 11 lines · Benoit Cousson
Hi Kishon,
Quoted 8 lines · Nishanth Menon
Quoted 7 lines · Kishon Vijay Abraham I
Benoit,
Quoted 3 lines · Kishon Vijay Abraham I
smps10 should be enabled only in the case of host mode. So stop doing
always_on,boot_onfromsmps10_out1. The driver will enable it in host mode.
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Can you take this patch too?
Acked-by Nishanth Menon <[email protected]>I've just applied it.
Thanks :-)
-Kishon
Quoted 5 lines
Thanks,
Benoit