ARM: dts: omap4: Fix pin muxing for wl12xx
cover ARM: dts: omap4: Fix pin muxing for wl12xx
Balaji T K (2):
ARM: dts: omap4-panda-common: Fix pin muxing for wl12xx
ARM: dts: omap4-sdp: Fix pin muxing for wl12xx
arch/arm/boot/dts/omap4-panda-common.dtsi | 20 ++++++++++---------- arch/arm/boot/dts/omap4-sdp.dts | 12 ++++++------ 2 files changed, 16 insertions(+), 16 deletions(-)
Signature · 1 line
1.7.5.4
PATCH 1/2 ARM: dts: omap4-panda-common: Fix pin muxing for wl12xx
pin mux wl12xx_gpio and wl12xx_pins should be part of omap4_pmx_core and not omap4_pmx_wkup. So, move wl12xx_* to omap4_pmx_core.
Fix the following error message:
pinctrl-single 4a31e040.pinmux: mux offset out of range: 0x38 (0x38) pinctrl-single 4a31e040.pinmux: could not add functions for pinmux_wl12xx_pins 56x
SDIO card is not detected after moving pin mux to omap4_pmx_core since sdmmc5_clk pull is disabled. Enable Pull up on sdmmc5_clk to detect SDIO card.
--- arch/arm/boot/dts/omap4-panda-common.dtsi | 20 ++++++++++---------- 1 files changed, 10 insertions(+), 10 deletions(-)
arch/arm/boot/dts/omap4-panda-common.dtsi +10 -10
@@ -246,15 +246,6 @@ 0xf0 (PIN_INPUT_PULLUP | MUX_MODE0) /* i2c4_sda */ >; }; -}; - -&omap4_pmx_wkup { - led_wkgpio_pins: pinmux_leds_wkpins { - pinctrl-single,pins = < - 0x1a (PIN_OUTPUT | MUX_MODE3) /* gpio_wk7 */ - 0x1c (PIN_OUTPUT | MUX_MODE3) /* gpio_wk8 */ - >; - }; /* * wl12xx GPIO outputs for WLAN_EN, BT_EN, FM_EN, BT_WAKEUP
@@ -274,7 +265,7 @@ pinctrl-single,pins = < 0x38 (PIN_INPUT | MUX_MODE3) /* gpmc_ncs2.gpio_52 */ 0x3a (PIN_INPUT | MUX_MODE3) /* gpmc_ncs3.gpio_53 */ - 0x108 (PIN_OUTPUT | MUX_MODE0) /* sdmmc5_clk.sdmmc5_clk */ + 0x108 (PIN_INPUT_PULLUP | MUX_MODE0) /* sdmmc5_clk.sdmmc5_clk */ 0x10a (PIN_INPUT_PULLUP | MUX_MODE0) /* sdmmc5_cmd.sdmmc5_cmd */ 0x10c (PIN_INPUT_PULLUP | MUX_MODE0) /* sdmmc5_dat0.sdmmc5_dat0 */ 0x10e (PIN_INPUT_PULLUP | MUX_MODE0) /* sdmmc5_dat1.sdmmc5_dat1 */
@@ -284,6 +275,15 @@ }; }; +&omap4_pmx_wkup { + led_wkgpio_pins: pinmux_leds_wkpins { + pinctrl-single,pins = < + 0x1a (PIN_OUTPUT | MUX_MODE3) /* gpio_wk7 */ + 0x1c (PIN_OUTPUT | MUX_MODE3) /* gpio_wk8 */ + >; + }; +}; + &i2c1 { pinctrl-names = "default"; pinctrl-0 = <&i2c1_pins>;
Signature · 1 line
1.7.5.4
PATCH 1/2 ARM: dts: omap4-panda-common: Fix pin muxing for wl12xx
Quoted 9 lines · Balaji T K
pin mux
wl12xx_gpioandwl12xx_pinsshould be part ofomap4_pmx_coreand notomap4_pmx_wkup. So, move wl12xx_* toomap4_pmx_core.Fix the following error message:
pinctrl-single 4a31e040.pinmux: mux offset out of range:0x38(0x38) pinctrl-single 4a31e040.pinmux: could not add functions forpinmux_wl12xx_pins56xSDIO card is not detected after moving pin mux to
omap4_pmx_coresincesdmmc5_clkpull is disabled. Enable Pull up onsdmmc5_clkto detect SDIO card.
Cool, does this fix the issue with the WLAN not coming up after a warm reset on panda?
Regards,
Tony
PATCH 1/2 ARM: dts: omap4-panda-common: Fix pin muxing for wl12xx
Quoted 7 lines · Tony Lindgren
Quoted 6 lines · Balaji T K
pin mux
wl12xx_gpioandwl12xx_pinsshould be part ofomap4_pmx_coreand notomap4_pmx_wkup. So, move wl12xx_* toomap4_pmx_core.Fix the following error message:
pinctrl-single 4a31e040.pinmux: mux offset out of range:0x38(0x38) pinctrl-single 4a31e040.pinmux: could not add functions forpinmux_wl12xx_pins56x
Why is the led pins moved then?
Quoted 12 lines
Quoted 2 lines
SDIO card is not detected after moving pin mux to
omap4_pmx_coresincesdmmc5_clkpull is disabled. Enable Pull up onsdmmc5_clkto detect SDIO card.Cool, does this fix the issue with the WLAN not coming up after a warm reset on panda?
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 2 lines
------------------ Dan Murphy
PATCH 1/2 ARM: dts: omap4-panda-common: Fix pin muxing for wl12xx
Quoted 10 lines · Dan Murphy
Quoted 7 lines · Tony Lindgren
Quoted 6 lines · Balaji T K
pin mux
wl12xx_gpioandwl12xx_pinsshould be part ofomap4_pmx_coreand notomap4_pmx_wkup. So, move wl12xx_* toomap4_pmx_core.Fix the following error message:
pinctrl-single 4a31e040.pinmux: mux offset out of range:0x38(0x38) pinctrl-single 4a31e040.pinmux: could not add functions forpinmux_wl12xx_pins56xWhy is the led pins moved then?
Heh the patch just looks that way, looking at the curly brackets thing do get moved properly.
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
SDIO card is not detected after moving pin mux to
omap4_pmx_coresincesdmmc5_clkpull is disabled. Enable Pull up onsdmmc5_clkto detect SDIO card.Cool, does this fix the issue with the WLAN not coming up after a warm reset on panda?
Also commit f446043f1aa7 (regulator: fixed: fix regulator_list_voltage() for regression) is needed that recently got merged. But with v3.13-rc1 + f446043f1aa7 + this patch no luck whatsoever bringing up the wl12xx so there must be also some regression somewhere from v3.12 on that?
Regards,
Tony
PATCH 1/2 ARM: dts: omap4-panda-common: Fix pin muxing for wl12xx
Quoted 17 lines · Tony Lindgren
Quoted 10 lines · Dan Murphy
Quoted 7 lines · Tony Lindgren
Quoted 6 lines · Balaji T K
pin mux
wl12xx_gpioandwl12xx_pinsshould be part ofomap4_pmx_coreand notomap4_pmx_wkup. So, move wl12xx_* toomap4_pmx_core.Fix the following error message:
pinctrl-single 4a31e040.pinmux: mux offset out of range:0x38(0x38) pinctrl-single 4a31e040.pinmux: could not add functions forpinmux_wl12xx_pins56xWhy is the led pins moved then?
Heh the patch just looks that way, looking at the curly brackets thing do get moved properly.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
SDIO card is not detected after moving pin mux to
omap4_pmx_coresincesdmmc5_clkpull is disabled. Enable Pull up onsdmmc5_clkto detect SDIO card.
Quoted 8 lines
Quoted 2 lines
Quoted 2 lines
Cool, does this fix the issue with the WLAN not coming up after a warm reset on panda?
Also commit
f446043f1aa7(regulator: fixed: fixregulator_list_voltage()for regression) is needed that recently got merged. But with v3.13-rc1 +f446043f1aa7+ this patch no luck whatsoever bringing up the wl12xx so there must be also some regression somewhere from v3.12 on that?
Hi Tony,
I tried loading wl12xx as modules on latest base as yours with ti-connectivity/wl127x-fw-5-sr.bin firmware in place and I could connect and run iperf.
Quoted 4 lines
Regards,
Tony
PATCH 1/2 ARM: dts: omap4-panda-common: Fix pin muxing for wl12xx
Quoted 26 lines · Balaji T K
Quoted 17 lines · Tony Lindgren
Quoted 10 lines · Dan Murphy
Quoted 7 lines · Tony Lindgren
Quoted 6 lines · Balaji T K
pin mux
wl12xx_gpioandwl12xx_pinsshould be part ofomap4_pmx_coreand notomap4_pmx_wkup. So, move wl12xx_* toomap4_pmx_core.Fix the following error message:
pinctrl-single 4a31e040.pinmux: mux offset out of range:0x38(0x38) pinctrl-single 4a31e040.pinmux: could not add functions forpinmux_wl12xx_pins56xWhy is the led pins moved then?
Heh the patch just looks that way, looking at the curly brackets thing do get moved properly.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
SDIO card is not detected after moving pin mux to
omap4_pmx_coresincesdmmc5_clkpull is disabled. Enable Pull up onsdmmc5_clkto detect SDIO card.Quoted 8 lines
Quoted 2 lines
Quoted 2 lines
Cool, does this fix the issue with the WLAN not coming up after a warm reset on panda?
Also commit
f446043f1aa7(regulator: fixed: fixregulator_list_voltage()for regression) is needed that recently got merged. But with v3.13-rc1 +f446043f1aa7+ this patch no luck whatsoever bringing up the wl12xx so there must be also some regression somewhere from v3.12 on that?
Quoted 5 lines
Hi Tony,
I tried loading wl12xx as modules on latest base as yours with ti-connectivity/wl127x-fw-5-sr.bin firmware in place and I could connect and run iperf.
Oh OK I must have missed something then.
Does it now work after a warm reboot too? And after bringing the interface down with "ifconfig wlan0 down" followed by "ifconfig wlan0 up"?
Regards,
Tony
PATCH 1/2 ARM: dts: omap4-panda-common: Fix pin muxing for wl12xx
Quoted 29 lines · Tony Lindgren
Quoted 28 lines · Balaji T K
Quoted 17 lines · Tony Lindgren
Quoted 10 lines · Dan Murphy
Quoted 7 lines · Tony Lindgren
Quoted 6 lines · Balaji T K
pin mux
wl12xx_gpioandwl12xx_pinsshould be part ofomap4_pmx_coreand notomap4_pmx_wkup. So, move wl12xx_* toomap4_pmx_core.Fix the following error message:
pinctrl-single 4a31e040.pinmux: mux offset out of range:0x38(0x38) pinctrl-single 4a31e040.pinmux: could not add functions forpinmux_wl12xx_pins56xWhy is the led pins moved then?
Heh the patch just looks that way, looking at the curly brackets thing do get moved properly.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
SDIO card is not detected after moving pin mux to
omap4_pmx_coresincesdmmc5_clkpull is disabled. Enable Pull up onsdmmc5_clkto detect SDIO card.Quoted 8 lines
Quoted 2 lines
Quoted 2 lines
Cool, does this fix the issue with the WLAN not coming up after a warm reset on panda?
Also commit
f446043f1aa7(regulator: fixed: fixregulator_list_voltage()for regression) is needed that recently got merged. But with v3.13-rc1 +f446043f1aa7+ this patch no luck whatsoever bringing up the wl12xx so there must be also some regression somewhere from v3.12 on that?Hi Tony,
Quoted 8 lines
Quoted 3 lines
I tried loading wl12xx as modules on latest base as yours with ti-connectivity/wl127x-fw-5-sr.bin firmware in place and I could connect and run iperf.
Oh OK I must have missed something then.
Does it now work after a warm reboot too? And after bringing the interface down with "ifconfig wlan0 down" followed by "ifconfig wlan0 up"?
Yes great, I can confirm that v3.13-rc1 + f446043f1aa7 (regulator: fixed: fix regulator_list_voltage() for regression) + this patch works even after a warm reset :) Will apply both to omap-for-v3.13/fixes-take4 with Cc stable.
Regards,
Tony
PATCH 1/2 ARM: dts: omap4-panda-common: Fix pin muxing for wl12xx
In reply to Dan MurphyQuoted 10 lines · Dan Murphy
Quoted 7 lines · Tony Lindgren
Quoted 6 lines · Balaji T K
pin mux
wl12xx_gpioandwl12xx_pinsshould be part ofomap4_pmx_coreand notomap4_pmx_wkup. So, move wl12xx_* toomap4_pmx_core.Fix the following error message:
pinctrl-single 4a31e040.pinmux: mux offset out of range:0x38(0x38) pinctrl-single 4a31e040.pinmux: could not add functions forpinmux_wl12xx_pins56xWhy is the led pins moved then?
Hi Dan,
I just moved 27 lines (wl12xx_pins, wl12xx_gpio) up, git diff generated smaller diff stat by moving 10 line of code (led_wkgpio_pins) further down :-)
Quoted 15 lines
Quoted 13 lines
Quoted 3 lines
SDIO card is not detected after moving pin mux to
omap4_pmx_coresincesdmmc5_clkpull is disabled. Enable Pull up onsdmmc5_clkto detect SDIO card.Cool, does this fix the issue with the WLAN not coming up after a warm reset on panda?
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 2/2 ARM: dts: omap4-sdp: Fix pin muxing for wl12xx
In reply to Balaji T KMux mode for wlan/sdmmc5 should be MODE0 in pinmux_wl12xx_pins and Enable Pull up on sdmmc5_clk to detect SDIO card.
--- arch/arm/boot/dts/omap4-sdp.dts | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-)
arch/arm/boot/dts/omap4-sdp.dts +6 -6
@@ -300,12 +300,12 @@ wl12xx_pins: pinmux_wl12xx_pins { pinctrl-single,pins = < 0x3a (PIN_INPUT | MUX_MODE3) /* gpmc_ncs3.gpio_53 */ - 0x108 (PIN_OUTPUT | MUX_MODE3) /* sdmmc5_clk.sdmmc5_clk */ - 0x10a (PIN_INPUT_PULLUP | MUX_MODE3) /* sdmmc5_cmd.sdmmc5_cmd */ - 0x10c (PIN_INPUT_PULLUP | MUX_MODE3) /* sdmmc5_dat0.sdmmc5_dat0 */ - 0x10e (PIN_INPUT_PULLUP | MUX_MODE3) /* sdmmc5_dat1.sdmmc5_dat1 */ - 0x110 (PIN_INPUT_PULLUP | MUX_MODE3) /* sdmmc5_dat2.sdmmc5_dat2 */ - 0x112 (PIN_INPUT_PULLUP | MUX_MODE3) /* sdmmc5_dat3.sdmmc5_dat3 */ + 0x108 (PIN_INPUT_PULLUP | MUX_MODE0) /* sdmmc5_clk.sdmmc5_clk */ + 0x10a (PIN_INPUT_PULLUP | MUX_MODE0) /* sdmmc5_cmd.sdmmc5_cmd */ + 0x10c (PIN_INPUT_PULLUP | MUX_MODE0) /* sdmmc5_dat0.sdmmc5_dat0 */ + 0x10e (PIN_INPUT_PULLUP | MUX_MODE0) /* sdmmc5_dat1.sdmmc5_dat1 */ + 0x110 (PIN_INPUT_PULLUP | MUX_MODE0) /* sdmmc5_dat2.sdmmc5_dat2 */ + 0x112 (PIN_INPUT_PULLUP | MUX_MODE0) /* sdmmc5_dat3.sdmmc5_dat3 */ >; }; };
Signature · 1 line
1.7.5.4