Skip to contentSkip to conversation

module-base: Fix misleading comment

PATCH In review Richard Purdie 3 participants 3 messages Nov 27, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 module-base: Fix misleading comment

The comment was originally written for module.bbclass and is now slightly misleading. This updates it to match the current code.

---

meta/classes/module-base.bbclass +2 -5
index 9dbb4b4..1589a90 100644
@@ -11,11 +11,8 @@ KERNEL_OBJECT_SUFFIX = ".ko"
 # kernel modules are generally machine specific
 PACKAGE_ARCH = "${MACHINE_ARCH}"
 
-#
-# Ensure the hostprogs are available for module compilation. Modules that
-# inherit this recipe and override do_compile() should be sure to call
-# do_make_scripts() or ensure the scripts are built independently.
-#
+# Function to ensure the kernel scripts are created. Expected to
+# be called before do_compile. See module.bbclass for an exmaple.
 do_make_scripts() {
 	unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS 
 	make CC="${KERNEL_CC}" LD="${KERNEL_LD}" AR="${KERNEL_AR}" \
Acked-by on v1 1/1
#1 lore raw
Quoted 2 lines · Richard Purdie

The comment was originally written for module.bbclass and is now slightly misleading. This updates it to match the current code.

Quoted 23 lines

---

meta/classes/module-base.bbclass +2 -5
index 9dbb4b4..1589a90 100644
@@ -11,11 +11,8 @@ KERNEL_OBJECT_SUFFIX = ".ko"
  # kernel modules are generally machine specific
  PACKAGE_ARCH = "${MACHINE_ARCH}"
 
-#
-# Ensure the hostprogs are available for module compilation. Modules that
-# inherit this recipe and override do_compile() should be sure to call
-# do_make_scripts() or ensure the scripts are built independently.
-#
+# Function to ensure the kernel scripts are created. Expected to
+# be called before do_compile. See module.bbclass for an exmaple.
  do_make_scripts() {
  	unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS
  	make CC="${KERNEL_CC}" LD="${KERNEL_LD}" AR="${KERNEL_AR}" \
#2 lore raw
Quoted 7 lines · Bruce Ashfield
Quoted 3 lines · Richard Purdie

The comment was originally written for module.bbclass and is now slightly misleading. This updates it to match the current code.

Looks ok

Quoted 27 lines
Quoted 26 lines

---

meta/classes/module-base. renamed from meta/classes/module-base.bbclass +0 -0

bbclass
index 9dbb4b4..1589a90 100644

meta/classes/module-base.bbclass +2 -5
@@ -11,11 +11,8 @@ KERNEL_OBJECT_SUFFIX = ".ko"
  # kernel modules are generally machine specific
  PACKAGE_ARCH = "${MACHINE_ARCH}"
 
-#
-# Ensure the hostprogs are available for module compilation. Modules that
-# inherit this recipe and override do_compile() should be sure to call
-# do_make_scripts() or ensure the scripts are built independently.
-#
+# Function to ensure the kernel scripts are created. Expected to
+# be called before do_compile. See module.bbclass for an exmaple.
  do_make_scripts() {
        unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS
        make CC="${KERNEL_CC}" LD="${KERNEL_LD}" AR="${KERNEL_AR}" \