module-base: Fix misleading comment
PATCH 1/1 module-base: Fix misleading comment
The comment was originally written for module.bbclass and is now slightly misleading. This updates it to match the current code.
Signed-off-by Richard Purdie <[email protected]>
---
meta/classes/module-base.bbclass +2 -5
@@ -11,11 +11,8 @@ KERNEL_OBJECT_SUFFIX = ".ko" # kernel modules are generally machine specific PACKAGE_ARCH = "${MACHINE_ARCH}" -# -# Ensure the hostprogs are available for module compilation. Modules that -# inherit this recipe and override do_compile() should be sure to call -# do_make_scripts() or ensure the scripts are built independently. -# +# Function to ensure the kernel scripts are created. Expected to +# be called before do_compile. See module.bbclass for an exmaple. do_make_scripts() { unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS make CC="${KERNEL_CC}" LD="${KERNEL_LD}" AR="${KERNEL_AR}" \
Quoted 2 lines · Richard Purdie
The comment was originally written for module.bbclass and is now slightly misleading. This updates it to match the current code.
Acked-by Bruce Ashfield <[email protected]>
Quoted 23 lines
Signed-off-by Richard Purdie <[email protected]>---
meta/classes/module-base.bbclass +2
-5@@ -11,11 +11,8 @@ KERNEL_OBJECT_SUFFIX = ".ko" # kernel modules are generally machine specific PACKAGE_ARCH = "${MACHINE_ARCH}" -# -# Ensure the hostprogs are available for module compilation. Modules that -# inherit this recipe and override do_compile() should be sure to call -# do_make_scripts() or ensure the scripts are built independently. -# +# Function to ensure the kernel scripts are created. Expected to +# be called before do_compile. See module.bbclass for an exmaple. do_make_scripts() { unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS make CC="${KERNEL_CC}" LD="${KERNEL_LD}" AR="${KERNEL_AR}" \
Quoted 7 lines · Bruce Ashfield
Quoted 3 lines · Richard Purdie
The comment was originally written for module.bbclass and is now slightly misleading. This updates it to match the current code.
Acked-by Bruce Ashfield <[email protected]>
Looks ok
Quoted 27 lines
Quoted 26 lines
Signed-off-by Richard Purdie <[email protected]>---
meta/classes/module-base. renamed from meta/classes/module-base.bbclass +0
-0bbclass
index 9dbb4b4..1589a90 100644meta/classes/module-base.bbclass +2
-5@@ -11,11 +11,8 @@ KERNEL_OBJECT_SUFFIX = ".ko" # kernel modules are generally machine specific PACKAGE_ARCH = "${MACHINE_ARCH}" -# -# Ensure the hostprogs are available for module compilation. Modules that -# inherit this recipe and override do_compile() should be sure to call -# do_make_scripts() or ensure the scripts are built independently. -# +# Function to ensure the kernel scripts are created. Expected to +# be called before do_compile. See module.bbclass for an exmaple. do_make_scripts() { unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS make CC="${KERNEL_CC}" LD="${KERNEL_LD}" AR="${KERNEL_AR}" \