drm/i915/vlv: correct promotion timer value for RC6 Timeout method.
Subsystems (2)
PATCH 1/2 drm/i915/vlv: correct promotion timer value for RC6 Timeout method.
From: Deepak S <[email protected]>
For RC6 Timeout method, we need to set promotion timer to 1750 us ( 1367
* 1.28 us)
--- drivers/gpu/drm/i915/intel_pm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_pm.c +2 -1
@@ -4102,7 +4102,8 @@ static void valleyview_enable_rps(struct drm_device *dev)for_each_ring (ring, dev_priv, i)I915_WRITE (RING_MAX_IDLE (ring->mmio_base),10 ); -I915_WRITE (GEN6_RC6_THRESHOLD ,0xc350 ); +/* Timer for RC6 Timeout Mode set to 1750 us ( 1367 * 1.28 us) */ +I915_WRITE (GEN6_RC6_THRESHOLD ,0x557 );/* allows RC6 residency counter to work */ I915_WRITE(VLV_COUNTER_CONTROL,
Signature · 1 line
1.8.4.2
Quoted 15 lines · On Wed, 27 Nov 2013 21:14:03 +0530 [email protected] wrote:
From: Deepak S <[email protected]>
For RC6 Timeout method, we need to set promotion timer to 1750 us ( 1367
* 1.28 us)Signed-off-by Deepak S <[email protected]>--- drivers/gpu/drm/i915/intel_pm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/intel_pm.c +0
-0
drivers/gpu/drm/i915/intel_pm.c static void valleyview_enable_rps(struct drm_device *dev) · line 4109
Quoted 9 lines
drivers/gpu/drm/i915/intel_pm.c +2
-1@@ -4102,7 +4102,8 @@ static void valleyview_enable_rps(struct drm_device *dev)for_each_ring (ring, dev_priv, i)I915_WRITE (RING_MAX_IDLE (ring->mmio_base),10 ); -I915_WRITE (GEN6_RC6_THRESHOLD ,0xc350 ); +/* Timer for RC6 Timeout Mode set to 1750 us ( 1367 * 1.28 us) */ +I915_WRITE (GEN6_RC6_THRESHOLD ,0x557 );/* allows RC6 residency counter to work */ I915_WRITE(VLV_COUNTER_CONTROL,
Yeah I just sent this one too. I'm fine with either one getting in. I also submitted one to do parallel restore of ring state, which we also want.
Care to review my earlier ones?
http://lists.freedesktop.org/archives/intel-gfx/2013-November/036112.html
http://lists.freedesktop.org/archives/intel-gfx/2013-November/036111.html
Thanks,
Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center
Hi Jesse,
Your patches looks fine to me. I think lets go with your patches and we can abandon mine.
Thanks
Deepak
-----Original Message-----
From: Jesse Barnes [mailto:[email protected]]
Sent: Wednesday, November 27, 2013 10:50 PM
To: S, Deepak
Cc: [email protected]
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/vlv: correct promotion timer value for RC6 Timeout method.
Quoted 16 lines · On Wed, 27 Nov 2013 21:14:03 +0530 [email protected] wrote:
From: Deepak S <[email protected]>
For RC6 Timeout method, we need to set promotion timer to 1750 us ( 1367
* 1.28 us)Signed-off-by Deepak S <[email protected]>--- drivers/gpu/drm/i915/intel_pm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/gpu/drm/i915/intel_pm.cindex 04e9863..cf3d54d 100644
drivers/gpu/drm/i915/intel_pm.c static void valleyview_enable_rps(struct drm_device *dev) · line 4109
Quoted 9 lines
drivers/gpu/drm/i915/intel_pm.c +2
-1@@ -4102,7 +4102,8 @@ static void valleyview_enable_rps(struct drm_device *dev)for_each_ring (ring, dev_priv, i)I915_WRITE (RING_MAX_IDLE (ring->mmio_base),10 ); -I915_WRITE (GEN6_RC6_THRESHOLD ,0xc350 ); +/* Timer for RC6 Timeout Mode set to 1750 us ( 1367 * 1.28 us) */ +I915_WRITE (GEN6_RC6_THRESHOLD ,0x557 );/* allows RC6 residency counter to work */ I915_WRITE(VLV_COUNTER_CONTROL,
Yeah I just sent this one too. I'm fine with either one getting in. I also submitted one to do parallel restore of ring state, which we also want.
Care to review my earlier ones?
http://lists.freedesktop.org/archives/intel-gfx/2013-November/036112.html
http://lists.freedesktop.org/archives/intel-gfx/2013-November/036111.html
Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
Quoted 3 lines · Deepak
Hi Jesse,
Your patches looks fine to me. I think lets go with your patches and we can abandon mine.
Does that count as a full Reviewed-by? If so please reply to the patches with it.
Thanks, Daniel
Quoted 54 lines
Thanks
Deepak-----Original Message-----
From: Jesse Barnes [mailto:[email protected]]
Sent: Wednesday, November 27, 2013 10:50 PM
To: S, Deepak
Cc: [email protected]
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/vlv: correct promotion timer value for RC6 Timeout method.Quoted 16 lines · On Wed, 27 Nov 2013 21:14:03 +0530 [email protected] wrote:
From: Deepak S <[email protected]>
For RC6 Timeout method, we need to set promotion timer to 1750 us ( 1367
* 1.28 us)Signed-off-by Deepak S <[email protected]>--- drivers/gpu/drm/i915/intel_pm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/gpu/drm/i915/intel_pm.cindex 04e9863..cf3d54d 100644drivers/gpu/drm/i915/intel_pm.c static void valleyview_enable_rps(struct drm_device *dev) · line 4109
Quoted 9 lines
drivers/gpu/drm/i915/intel_pm.c +2
-1@@ -4102,7 +4102,8 @@ static void valleyview_enable_rps(struct drm_device *dev)for_each_ring (ring, dev_priv, i)I915_WRITE (RING_MAX_IDLE (ring->mmio_base),10 ); -I915_WRITE (GEN6_RC6_THRESHOLD ,0xc350 ); +/* Timer for RC6 Timeout Mode set to 1750 us ( 1367 * 1.28 us) */ +I915_WRITE (GEN6_RC6_THRESHOLD ,0x557 );/* allows RC6 residency counter to work */ I915_WRITE(VLV_COUNTER_CONTROL,Yeah I just sent this one too. I'm fine with either one getting in. I also submitted one to do parallel restore of ring state, which we also want.
Care to review my earlier ones?
http://lists.freedesktop.org/archives/intel-gfx/2013-November/036112.html
http://lists.freedesktop.org/archives/intel-gfx/2013-November/036111.htmlThanks,
--
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
Yes I have reviewed both the patches.
Thanks
Deepak
-----Original Message-----
From: Daniel Vetter [mailto:[email protected]] On Behalf Of Daniel Vetter
Sent: Thursday, November 28, 2013 1:03 PM
To: S, Deepak
Cc: Jesse Barnes; [email protected]
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/vlv: correct promotion timer value for RC6 Timeout method.
Quoted 3 lines · Deepak
Hi Jesse,
Your patches looks fine to me. I think lets go with your patches and we can abandon mine.
Does that count as a full Reviewed-by? If so please reply to the patches with it.
Thanks, Daniel
Quoted 49 lines
Thanks
Deepak-----Original Message-----
From: Jesse Barnes [mailto:[email protected]]
Sent: Wednesday, November 27, 2013 10:50 PM
To: S, Deepak
Cc: [email protected]
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/vlv: correct promotion timer value for RC6 Timeout method.Quoted 16 lines · On Wed, 27 Nov 2013 21:14:03 +0530 [email protected] wrote:
From: Deepak S <[email protected]>
For RC6 Timeout method, we need to set promotion timer to 1750 us ( 1367
* 1.28 us)Signed-off-by Deepak S <[email protected]>--- drivers/gpu/drm/i915/intel_pm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/gpu/drm/i915/intel_pm.cindex 04e9863..cf3d54d 100644drivers/gpu/drm/i915/intel_pm.c static void valleyview_enable_rps(struct drm_device *dev) · line 4109
Quoted 9 lines
drivers/gpu/drm/i915/intel_pm.c +2
-1@@ -4102,7 +4102,8 @@ static void valleyview_enable_rps(struct drm_device *dev)for_each_ring (ring, dev_priv, i)I915_WRITE (RING_MAX_IDLE (ring->mmio_base),10 ); -I915_WRITE (GEN6_RC6_THRESHOLD ,0xc350 ); +/* Timer for RC6 Timeout Mode set to 1750 us ( 1367 * 1.28 us) */ +I915_WRITE (GEN6_RC6_THRESHOLD ,0x557 );/* allows RC6 residency counter to work */ I915_WRITE(VLV_COUNTER_CONTROL,Yeah I just sent this one too. I'm fine with either one getting in. I also submitted one to do parallel restore of ring state, which we also want.
Care to review my earlier ones?
http://lists.freedesktop.org/archives/intel-gfx/2013-November/036112.h
tml
http://lists.freedesktop.org/archives/intel-gfx/2013-November/036111.h
tml
Quoted 7 lines
Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch