ARM: mach-moxart: add MOXA ART SoC support
Subsystems (6)
v6 cover ARM: mach-moxart: add MOXA ART SoC support
Thanks for the replies!
This should tick the boxes on feedback except for one detail on the fixed rate clock:
Moving fixed-clock "ref12" from .dtsi to .dts proved problematic for other clocks, this is why ref12 is still in SoC.
My assertion is that "fixed-clock" clocks are probed later when placed in .dts (see diff and boot log below). of_clk_get() from clk_pll in .dtsi fails, i.e. fixed-clock ref12 is not added as a provider in time before clk_pll loads.
drivers/clk/clk-fixed-rate.c +3 -1
@@ -98,8 +98,10 @@ void of_fixed_clk_setup(struct device_node *node)of_property_read_string (node,"clock-output-names" , &clk_name); clk =clk_register_fixed_rate (NULL , clk_name,NULL ,CLK_IS_ROOT , rate); -if (!IS_ERR (clk)) +if (!IS_ERR (clk)) { +pr_info ("%s: of_clk_add_provider node=%p\n" , __func__, node);of_clk_add_provider (node, of_clk_src_simple_get, clk); + } }EXPORT_SYMBOL_GPL (of_fixed_clk_setup);CLK_OF_DECLARE (fixed_clk,"fixed-clock" , of_fixed_clk_setup);
drivers/clk/clk.c +9 -1
@@ -2192,13 +2192,21 @@ struct clk *of_clk_get_from_provider(struct of_phandle_args *clkspec)/* Check if we have such a provider in our array */ mutex_lock (&of_clk_lock);list_for_each_entry (provider, &of_clk_providers, link) { +pr_info ("%s: provider->node=%p clkspec->np=%p\n" , __func__, provider->node, clkspec->np);if (provider->node == clkspec->np) clk = provider->get (clkspec, provider->data); -if (!IS_ERR (clk)) +if (!IS_ERR (clk)) {break ; + }else { +pr_info ("%s: provider->get() failed\n" , __func__); + } }mutex_unlock (&of_clk_lock); +if (IS_ERR (clk)) { +pr_info ("%s: no providers\n" , __func__); + } +return clk; }
drivers/clk/clkdev.c +3 -1
@@ -36,8 +36,10 @@ struct clk *of_clk_get(struct device_node *np, int index) rc =of_parse_phandle_with_args (np,"clocks" ,"#clock-cells" , index, &clkspec); -if (rc) +if (rc) { +pr_info ("%s: of_parse_phandle_with_args() failed\n" , __func__);return ERR_PTR (rc); + } clk =of_clk_get_from_provider (&clkspec);of_node_put (clkspec.np);
Uncompressing Linux... done, booting the kernel.
[ 0.000000] Booting Linux on physical CPU 0x0 [ 0.000000] Linux version 3.13.0-rc4-next-20131218+ (i at Ildjarn) (gcc version 4.6.3 (crosstool-NG 1.16.0) ) #1387 PREEMPT Wed Dec 18 12:20:50 CET 2013 [ 0.000000] CPU: FA526 [66015261] revision 1 (ARMv4), cr=0000397f [ 0.000000] CPU: VIVT data cache, VIVT instruction cache [ 0.000000] Machine model: MOXA UC-7112-LX [ 0.000000] bootconsole [earlycon0] enabled [ 0.000000] Memory policy: Data cache writeback [ 0.000000] Built 1 zonelists in Zone order, mobility grouping on. Total pages: 8128 [ 0.000000] Kernel command line: console=ttyS0,115200n8 earlyprintk root=/dev/mmcblk0p1 rw rootwait [ 0.000000] PID hash table entries: 128 (order: -3, 512 bytes) [ 0.000000] Dentry cache hash table entries: 4096 (order: 2, 16384 bytes) [ 0.000000] Inode-cache hash table entries: 2048 (order: 1, 8192 bytes) [ 0.000000] Memory: 29616K/32768K available (2266K kernel code, 71K rwdata, 216K rodata, 103K init, 111K bss, 3152K reserved) [ 0.000000] Virtual kernel memory layout: [ 0.000000] vector : 0xffff0000 - 0xffff1000 ( 4 kB) [ 0.000000] fixmap : 0xfff00000 - 0xfffe0000 ( 896 kB) [ 0.000000] vmalloc : 0xc2800000 - 0xff000000 ( 968 MB) [ 0.000000] lowmem : 0xc0000000 - 0xc2000000 ( 32 MB) [ 0.000000] .text : 0xc0008000 - 0xc0274c44 (2484 kB) [ 0.000000] .init : 0xc0275000 - 0xc028ed50 ( 104 kB) [ 0.000000] .data : 0xc0290000 - 0xc02a1ee0 ( 72 kB) [ 0.000000] .bss : 0xc02a1eec - 0xc02bdb64 ( 112 kB) [ 0.000000] SLUB: HWalign=32, Order=0-3, MinObjects=0, CPUs=1, Nodes=1 [ 0.000000] Preemptible hierarchical RCU implementation. [ 0.000000] NR_IRQS:16 nr_irqs:16 16 [ 0.000000] of_clk_get_from_provider: no providers [ 0.000000] /soc/clk_pll at 98100000: of_clk_get failed [ 0.000000] of_clk_get_from_provider: no providers [ 0.000000] /soc/clk_apb at 98100000: of_clk_get failed [ 0.000000] of_fixed_clk_setup: of_clk_add_provider node=c02ff5bc [ 0.000000] of_clk_get_from_provider: provider->node=c02ff5bc clkspec->np=c02fe7dc [ 0.000000] of_clk_get_from_provider: provider->get() failed [ 0.000000] of_clk_get_from_provider: no providers [ 0.000000] Kernel panic - not syncing: /soc/timer at 98400000: of_clk_get failed
Changes since v5:
1. change Makefile objects list order, sort alphabetically
2. add "clocks = <&ref12>" to clk_pll node in board file, remove it from SoC
3. move PHY nodes from SoC to board
Applies to next-20131218
Jonas Jensen (2):
ARM: mach-moxart: add MOXA ART SoC platform files
ARM: mach-moxart: add MOXA ART SoC device tree files
Documentation/devicetree/bindings/arm/moxart.txt | 12 ++ arch/arm/Kconfig | 2 + arch/arm/Makefile | 1 + arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/moxart-uc7112lx.dts | 109 ++++++++++++++++ arch/arm/boot/dts/moxart.dtsi | 154 +++++++++++++++++++++++ arch/arm/configs/moxart_defconfig | 149 ++++++++++++++++++++++ arch/arm/mach-moxart/Kconfig | 31 +++++ arch/arm/mach-moxart/Makefile | 3 + arch/arm/mach-moxart/moxart.c | 15 +++ 10 files changed, 477 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/moxart.txt create mode 100644 arch/arm/boot/dts/moxart-uc7112lx.dts create mode 100644 arch/arm/boot/dts/moxart.dtsi create mode 100644 arch/arm/configs/moxart_defconfig create mode 100644 arch/arm/mach-moxart/Kconfig create mode 100644 arch/arm/mach-moxart/Makefile create mode 100644 arch/arm/mach-moxart/moxart.c
Signature · 1 line
1.8.2.1
PATCH v6 1/2 ARM: mach-moxart: add MOXA ART SoC platform files
The MOXA ART SoC is based on Faraday's FA526. This is a ARMv4 32-bit 192 MHz CPU with MMU and 16KB/8KB D/I-cache.
Add platform support for this SoC.
Also add UC-7112-LX as a machine.
--- arch/arm/Kconfig | 2 + arch/arm/Makefile | 1 + arch/arm/configs/moxart_defconfig | 149 ++++++++++++++++++++++++++++++++++++++ arch/arm/mach-moxart/Kconfig | 31 ++++++++ arch/arm/mach-moxart/Makefile | 3 + arch/arm/mach-moxart/moxart.c | 15 ++++ 6 files changed, 201 insertions(+) create mode 100644 arch/arm/configs/moxart_defconfig create mode 100644 arch/arm/mach-moxart/Kconfig create mode 100644 arch/arm/mach-moxart/Makefile create mode 100644 arch/arm/mach-moxart/moxart.c
arch/arm/Kconfig +2 -0
@@ -948,6 +948,8 @@ source "arch/arm/mach-ks8695/Kconfig" source "arch/arm/mach-msm/Kconfig" +source "arch/arm/mach-moxart/Kconfig" + source "arch/arm/mach-mv78xx0/Kconfig" source "arch/arm/mach-imx/Kconfig"
arch/arm/Makefile +1 -0
@@ -167,6 +167,7 @@ machine-$(CONFIG_ARCH_KIRKWOOD) += kirkwood machine-$(CONFIG_ARCH_KS8695) += ks8695 machine-$(CONFIG_ARCH_LPC32XX) += lpc32xx machine-$(CONFIG_ARCH_MMP) += mmp +machine-$(CONFIG_ARCH_MOXART) += moxart machine-$(CONFIG_ARCH_MSM) += msm machine-$(CONFIG_ARCH_MV78XX0) += mv78xx0 machine-$(CONFIG_ARCH_MVEBU) += mvebu
arch/arm/configs/moxart_defconfig new file +149 -0
149 lines not on this page · raw message
arch/arm/mach-moxart/Kconfig new file +31 -0
@@ -0,0 +1,31 @@ +config ARCH_MOXART + bool "MOXA ART SoC" if ARCH_MULTI_V4T + select CPU_FA526 + select ARM_DMA_MEM_BUFFERABLE + select DMA_OF + select USE_OF + select CLKSRC_OF + select CLKSRC_MMIO + select HAVE_CLK + select COMMON_CLK + select GENERIC_IRQ_CHIP + select ARCH_REQUIRE_GPIOLIB + select GENERIC_CLOCKEVENTS + select PHYLIB if NETDEVICES + help + Say Y here if you want to run your kernel on hardware with a + MOXA ART SoC. + The MOXA ART SoC is based on a Faraday FA526 ARMv4 32-bit + 192 MHz CPU with MMU and 16KB/8KB D/I-cache (UC-7112-LX). + Used on models UC-7101, UC-7112/UC-7110, IA240/IA241, IA3341. + +if ARCH_MOXART + +config MACH_UC7112LX + bool "MOXA UC-7112-LX" + depends on ARCH_MOXART + help + Say Y here if you intend to run this kernel on a MOXA + UC-7112-LX embedded computer. + +endif
arch/arm/mach-moxart/Makefile new file +3 -0
@@ -0,0 +1,3 @@ +# Object file lists. + +obj-$(CONFIG_MACH_UC7112LX) += moxart.o
arch/arm/mach-moxart/moxart.c new file +15 -0
@@ -0,0 +1,15 @@ +/* +* arch/arm/mach-moxart/moxart.c +* +* (C) Copyright 2013, Jonas Jensen <[email protected]> +* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License as published by +* the Free Software Foundation; either version 2 of the License, or +* (at your option) any later version. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +*/
Signature · 1 line
1.8.2.1
PATCH v6 2/2 ARM: mach-moxart: add MOXA ART SoC device tree files
In reply to Jonas JensenAdd a generic (dtsi) include file for MOXA ART SoCs.
Also add a file for UC-7112-LX.
--- Documentation/devicetree/bindings/arm/moxart.txt | 12 ++ arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/moxart-uc7112lx.dts | 109 ++++++++++++++++ arch/arm/boot/dts/moxart.dtsi | 154 +++++++++++++++++++++++ 4 files changed, 276 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/moxart.txt create mode 100644 arch/arm/boot/dts/moxart-uc7112lx.dts create mode 100644 arch/arm/boot/dts/moxart.dtsi
Documentation/devicetree/bindings/arm/moxart.txt new file +12 -0
@@ -0,0 +1,12 @@ +MOXA ART device tree bindings + +Boards with the MOXA ART SoC shall have the following properties: + +Required root node property: + +compatible = "moxa,moxart"; + +Boards: + +- UC-7112-LX: embedded computer + compatible = "moxa,moxart-uc-7112-lx", "moxa,moxart"
arch/arm/boot/dts/Makefile +1 -0
@@ -110,6 +110,7 @@ dtb-$(CONFIG_ARCH_KIRKWOOD) += kirkwood-cloudbox.dtb \ kirkwood-ts219-6281.dtb \ kirkwood-ts219-6282.dtb dtb-$(CONFIG_ARCH_MARCO) += marco-evb.dtb +dtb-$(CONFIG_ARCH_MOXART) += moxart-uc7112lx.dtb dtb-$(CONFIG_ARCH_MSM) += qcom-msm8660-surf.dtb \ qcom-msm8960-cdp.dtb dtb-$(CONFIG_ARCH_MVEBU) += armada-370-db.dtb \
arch/arm/boot/dts/moxart-uc7112lx.dts new file +109 -0
109 lines not on this page · raw message
arch/arm/boot/dts/moxart.dtsi new file +154 -0
154 lines not on this page · raw message
Signature · 1 line
1.8.2.1
Re: [PATCH v6 2/2] ARM: mach-moxart: add MOXA ART SoC device tree files
Quoted 137 lines · Jonas Jensen
Add a generic (dtsi) include file for MOXA ART SoCs.
Also add a file for UC-7112-LX.
Signed-off-by Jonas Jensen <[email protected]>--- Documentation/devicetree/bindings/arm/moxart.txt | 12 ++ arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/moxart-uc7112lx.dts | 109 ++++++++++++++++ arch/arm/boot/dts/moxart.dtsi | 154 +++++++++++++++++++++++ 4 files changed, 276 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/moxart.txt create mode 100644 arch/arm/boot/dts/moxart-uc7112lx.dts create mode 100644 arch/arm/boot/dts/moxart.dtsiDocumentation/devicetree/bindings/arm/moxart.txt new file +12
-0@@ -0,0 +1,12 @@ +MOXA ART device tree bindings + +Boards with the MOXA ART SoC shall have the following properties: + +Required root node property: + +compatible = "moxa,moxart"; + +Boards: + +- UC-7112-LX: embedded computer + compatible = "moxa,moxart-uc-7112-lx", "moxa,moxart"arch/arm/boot/dts/Makefile +1
-0@@ -110,6 +110,7 @@ dtb-$(CONFIG_ARCH_KIRKWOOD) += kirkwood-cloudbox.dtb \ kirkwood-ts219-6281.dtb \ kirkwood-ts219-6282.dtb dtb-$(CONFIG_ARCH_MARCO) += marco-evb.dtb +dtb-$(CONFIG_ARCH_MOXART) += moxart-uc7112lx.dtb dtb-$(CONFIG_ARCH_MSM) += qcom-msm8660-surf.dtb \ qcom-msm8960-cdp.dtb dtb-$(CONFIG_ARCH_MVEBU) += armada-370-db.dtb \arch/arm/boot/dts/moxart-uc7112lx.dts new file +86
-0@@ -0,0 +1,109 @@ +/* moxart-uc7112lx.dts - Device Tree file for MOXA UC-7112-LX + * + * Copyright (C) 2013 Jonas Jensen <[email protected]> + * + * Licensed under GPLv2 or later. + */ + +/dts-v1/; +/include/ "moxart.dtsi" + +/ { + model = "MOXA UC-7112-LX"; + compatible = "moxa,moxart-uc-7112-lx", "moxa,moxart"; + + memory { + device_type = "memory"; + reg = <0x0 0x2000000>; + }; + + flash at 80000000,0 { + compatible = "numonyx,js28f128", "cfi-flash"; + reg = <0x80000000 0x1000000>; + bank-width = <2>; + #address-cells = <1>; + #size-cells = <1>; + partition at 0 { + label = "bootloader"; + reg = <0x0 0x40000>; + }; + partition at 40000 { + label = "linux kernel"; + reg = <0x40000 0x1C0000>; + }; + partition at 200000 { + label = "root filesystem"; + reg = <0x200000 0x800000>; + }; + partition at a00000 { + label = "user filesystem"; + reg = <0xa00000 0x600000>; + }; + }; + + leds { + compatible = "gpio-leds"; + user-led { + label = "ready-led"; + gpios = <&gpio 27 0x1>; + default-state = "on"; + linux,default-trigger = "default-on"; + }; + }; + + gpio_keys_polled { + compatible = "gpio-keys-polled"; + #address-cells = <1>; + #size-cells = <0>; + poll-interval = <500>; + button at 25 { + label = "GPIO Reset"; + linux,code = <116>; + gpios = <&gpio 25 1>; + }; + }; + + chosen { + bootargs = "console=ttyS0,115200n8 earlyprintk root=/dev/mmcblk0p1 rw rootwait"; + }; +}; + +&clk_pll { + clocks = <&ref12>; +}; + +&sdhci { + status = "okay"; +}; + +&mdio0 { + status = "okay"; + + ethphy0: ethernet-phy at 1 { + device_type = "ethernet-phy"; + compatible = "moxa,moxart-rtl8201cp", "ethernet-phy-ieee802.3-c22"; + reg = <1>; + };
arch/arm/boot/dts/moxart-uc7112lx.dts line 96
Quoted 10 lines
arch/arm/boot/dts/moxart-uc7112lx.dts new file +10
-0+}; + +&mdio1 { + status = "okay"; + + ethphy1: ethernet-phy at 1 { + device_type = "ethernet-phy"; + compatible = "moxa,moxart-rtl8201cp", "ethernet-phy-ieee802.3-c22"; + reg = <1>; + };
You phy stuff looks good to me, thanks for the changes.
Quoted 40 lines
arch/arm/boot/dts/moxart-uc7112lx.dts new file +13
-0+}; + +&mac0 { + status = "okay"; +}; + +&mac1 { + status = "okay"; +}; + +&uart0 { + status = "okay"; +};arch/arm/boot/dts/moxart.dtsi new file +21
-0@@ -0,0 +1,154 @@ +/* moxart.dtsi - Device Tree Include file for MOXA ART family SoC + * + * Copyright (C) 2013 Jonas Jensen <[email protected]> + * + * Licensed under GPLv2 or later. + */ + +/include/ "skeleton.dtsi" + +/ { + compatible = "moxa,moxart"; + model = "MOXART"; + interrupt-parent = <&intc>; + + cpus { + #address-cells = <1>; + #size-cells = <0>; + + cpu at 0 { + device_type = "cpu"; + compatible = "faraday,fa526";
arch/arm/boot/dts/moxart.dtsi line 31
Quoted 10 lines
arch/arm/boot/dts/moxart.dtsi new file +10
-0+ reg = <0>; + }; + }; + + clocks { + #address-cells = <1>; + #size-cells = <0>; + + ref12: ref12M { + compatible = "fixed-clock";
Is the correct split to perhaps have the fixed-clock node in dtsi as you have here but ...
arch/arm/boot/dts/moxart.dtsi line 33
Quoted 2 lines
arch/arm/boot/dts/moxart.dtsi new file +2
-0+ #clock-cells = <0>; + clock-frequency = <12000000>;
The board is responsible for the frequency?
I guess in this schema,
1. the "fixed-clock" node corresponds to the existence of clock input pins on the SoC level - hence the node is DTSI.
2. setting the clock-frequency corresponds to populatation of those input pins with a soldered crystal - hence done in DTS
Then again, I'm not entirely sure, and I think I might be splitting hairs here, So.
Quoted 129 lines
arch/arm/boot/dts/moxart.dtsi new file +121
-1+ }; + }; + + soc { + compatible = "simple-bus"; + #address-cells = <1>; + #size-cells = <1>; + reg = <0x90000000 0x10000000>; + ranges; + + intc: interrupt-controller at 98800000 { + compatible = "moxa,moxart-ic"; + reg = <0x98800000 0x38>; + interrupt-controller; + #interrupt-cells = <2>; + interrupt-mask = <0x00080000>; + }; + + clk_pll: clk_pll at 98100000 { + compatible = "moxa,moxart-pll-clock"; + #clock-cells = <0>; + reg = <0x98100000 0x34>; + }; + + clk_apb: clk_apb at 98100000 { + compatible = "moxa,moxart-apb-clock"; + #clock-cells = <0>; + reg = <0x98100000 0x34>; + clocks = <&clk_pll>; + }; + + timer: timer at 98400000 { + compatible = "moxa,moxart-timer"; + reg = <0x98400000 0x42>; + interrupts = <19 1>; + clocks = <&clk_apb>; + }; + + gpio: gpio at 98700000 { + gpio-controller; + #gpio-cells = <2>; + compatible = "moxa,moxart-gpio"; + reg = <0x98700000 0xC>; + }; + + rtc: rtc { + compatible = "moxa,moxart-rtc"; + gpio-rtc-sclk = <&gpio 5 0>; + gpio-rtc-data = <&gpio 6 0>; + gpio-rtc-reset = <&gpio 7 0>; + }; + + dma: dma at 90500000 { + compatible = "moxa,moxart-dma"; + reg = <0x90500080 0x40>; + interrupts = <24 0>; + #dma-cells = <1>; + }; + + watchdog: watchdog at 98500000 { + compatible = "moxa,moxart-watchdog"; + reg = <0x98500000 0x10>; + clocks = <&clk_apb>; + }; + + sdhci: sdhci at 98e00000 { + compatible = "moxa,moxart-sdhci"; + reg = <0x98e00000 0x5C>; + interrupts = <5 0>; + clocks = <&clk_apb>; + dmas = <&dma 5>, + <&dma 5>; + dma-names = "tx", "rx"; + status = "disabled"; + }; + + mdio0: mdio at 90900090 { + compatible = "moxa,moxart-mdio"; + reg = <0x90900090 0x8>; + #address-cells = <1>; + #size-cells = <0>; + status = "disabled"; + }; + + mdio1: mdio at 92000090 { + compatible = "moxa,moxart-mdio"; + reg = <0x92000090 0x8>; + #address-cells = <1>; + #size-cells = <0>; + status = "disabled"; + }; + + mac0: mac at 90900000 { + compatible = "moxa,moxart-mac"; + reg = <0x90900000 0x90>; + interrupts = <25 0>; + phy-handle = <ðphy0>; + phy-mode = "mii"; + status = "disabled"; + }; + + mac1: mac at 92000000 { + compatible = "moxa,moxart-mac"; + reg = <0x92000000 0x90>; + interrupts = <27 0>; + phy-handle = <ðphy1>; + phy-mode = "mii"; + status = "disabled"; + }; + + uart0: uart at 98200000 { + compatible = "ns16550a"; + reg = <0x98200000 0x20>; + interrupts = <31 8>; + reg-shift = <2>; + reg-io-width = <4>; + clock-frequency = <14745600>; + status = "disabled"; + }; + }; +}; --1.8.2.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v6 2/2] ARM: mach-moxart: add MOXA ART SoC device tree files
Quoted 13 lines · Peter Crosthwaite
arch/arm/boot/dts/moxart.dtsi line 31
Quoted 6 lines
arch/arm/boot/dts/moxart.dtsi new file +6
-0+ clocks { + #address-cells = <1>; + #size-cells = <0>; + + ref12: ref12M { + compatible = "fixed-clock";Is the correct split to perhaps have the fixed-clock node in dtsi as you have here but ...
arch/arm/boot/dts/moxart.dtsi line 33
Quoted 2 lines
arch/arm/boot/dts/moxart.dtsi new file +2
-0+ #clock-cells = <0>; + clock-frequency = <12000000>;
Quoted 8 lines
The board is responsible for the frequency?
I guess in this schema,
1. the "fixed-clock" node corresponds to the existence of clock input pins on the SoC level - hence the node is DTSI.
2. setting the clock-frequency corresponds to populatation of those input pins with a soldered crystal - hence done in DTS
Yes, the soldered crystal belongs to board. Changes in v7 should reflect that.
I tried to doing what you said above, it didn't quite work, I got the same error from of_clk_get() / of_clk_get_by_name(), but came up with another solution please have a look at v7.
Thanks,
Jonas
Hi Jonas,
Quoted 5 lines · Jonas Jensen
Thanks for the replies!
This should tick the boxes on feedback except for one detail on the fixed rate clock:
Quoted 7 lines
Moving fixed-clock "ref12" from .dtsi to .dts proved problematic for other clocks, this is why ref12 is still in SoC.
My assertion is that "fixed-clock" clocks are probed later when placed in .dts (see diff and boot log below).
of_clk_get()fromclk_pllin .dtsi fails, i.e. fixed-clock ref12 is not added as a provider in time beforeclk_pllloads.
I haven't looked into the details, but is of_clk_get_parent_name() an alternative? That function does purely rely on DT data to obtain a name of a clock which may enable to register your PLL? Then probing oder wouldn't matter anymore.
S?ren
Quoted 5 lines · Jonas Jensen
Thanks for the replies!
This should tick the boxes on feedback except for one detail on the fixed rate clock:
Quoted 7 lines
Moving fixed-clock "ref12" from .dtsi to .dts proved problematic for other clocks, this is why ref12 is still in SoC.
My assertion is that "fixed-clock" clocks are probed later when placed in .dts (see diff and boot log below).
of_clk_get()fromclk_pllin .dtsi fails, i.e. fixed-clock ref12 is not added as a provider in time beforeclk_pllloads.
Argh, I didn't see this version before I applied v5. So I dropped v5 and replaced with v6.
-Olof