video: backlight: gpio-backlight: Add DT support.
Subsystems (6)
PATCH v9 1/2 video: backlight: gpio-backlight: Add DT support.
---
ChangeLog v8->v9:
- Added Shawn Guo in the Cc list.
- The default-brightness-level is now a boolean default-on property, the gpio is only touched if the gpio-backlight driver instance probes.
- The code and documentation was updated accordingly.
ChangeLog v7->v8:
- The default-state was renamed to default-brightness-level.
- default-brightness-level is now mandatory, like for backlight-pwm, That way we avoid having to handle the case where it's not set, which means that we would need not to set the gpio, but still report a brightness value for sysfs, when not all gpio controllers are able to read the gpio value.
- switched the default-brightness-level to boolean values (0 or 1) instead of using strings ("on", "off", "keep").
- The documentation was updated accordingly.
- The example in the documentation now uses the dts gpio defines.
- The "backlight: gpio_backlight: Use a default state enum." patch was then dropped, becuase it is not necessary anymore.
ChangeLog v6->v7:
- removed a compilation warning with the removal of the useless ret declaration.
ChangeLog v5->v6:
- The default state handling was reworked:
- it's now called default-state, and looks like the gpio-leds default-state.
- it now has a "keep" option, like for the gpio-leds.
- that "keep" option is the default when the default-state property is not set.
- The documentation was updated accordingly.
ChangeLog v4->v5:
- The default-brightness property now defaults to 0 in the driver.
- def_value int becomes a bool.
- The check for the gpio validity has been reworked.
--- .../bindings/video/backlight/gpio-backlight.txt | 19 +++++++ drivers/video/backlight/gpio_backlight.c | 60 +++++++++++++++++--- 2 files changed, 72 insertions(+), 7 deletions(-) create mode 100644 Documentation/devicetree/bindings/video/backlight/gpio-backlight.txt
Documentation/devicetree/bindings/video/backlight/gpio-backlight.txt new file +19 -0
@@ -0,0 +1,19 @@ +gpio-backlight bindings + +Required properties: + - compatible: "gpio-backlight" + - gpios: describes the gpio that is used for enabling/disabling the backlight + (see GPIO binding[0] for more details). + +Optional properties: + - default-on: enable the backlight at boot. + +[0]: Documentation/devicetree/bindings/gpio/gpio.txt + +Example: + + backlight { + compatible = "gpio-backlight"; + gpios = <&gpio3 4 GPIO_ACTIVE_HIGH>; + default-on; + };
drivers/video/backlight/gpio_backlight.c +53 -7
112 lines not on this page · raw message
Signature · 1 line
1.7.9.5
PATCH v9 2/2 ARM: imx_v6_v7_defconfig: Enable backlight gpio support.
The eukrea mbimxsd51 has a gpio backlight for its
LCD display, so we turn that driver on.
---
Changelog:
- This patch has been splitted out of my imx-drm v5 patchset:
http://lists.freedesktop.org/archives/dri-devel/2013-December/050124.html
which will be resubmitted later without that patch.
- This patch is unchanged since the imx-drm v5 patchset, where it was first introduced.
--- arch/arm/configs/imx_v6_v7_defconfig | 1 + 1 file changed, 1 insertion(+)
arch/arm/configs/imx_v6_v7_defconfig +1 -0
@@ -188,6 +188,7 @@ CONFIG_LCD_L4F00242T03=y CONFIG_LCD_PLATFORM=y CONFIG_BACKLIGHT_CLASS_DEVICE=y CONFIG_BACKLIGHT_PWM=y +CONFIG_BACKLIGHT_GPIO=y CONFIG_FRAMEBUFFER_CONSOLE=y CONFIG_LOGO=y CONFIG_SOUND=y
Signature · 1 line
1.7.9.5
Shawn Guo
AppliedPATCH v9 2/2 ARM: imx_v6_v7_defconfig: Enable backlight gpio support.
Quoted 9 lines · Denis Carikli
The eukrea mbimxsd51 has a gpio backlight for its
LCD display, so we turn that driver on.Cc Sascha Hauer <[email protected]>Cc Fabio Estevam <[email protected]>Cc Shawn Guo <[email protected]>Cc Eric Bénard <[email protected]>Signed-off-by Denis Carikli <[email protected]>
Applied this one, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH v9 1/2 video: backlight: gpio-backlight: Add DT support.
In reply to Denis CarikliHi,
Quoted 58 lines · Denis Carikli
Cc Richard Purdie <[email protected]>Cc Jingoo Han <[email protected]>Cc Laurent Pinchart <[email protected]>Cc Rob Herring <[email protected]>Cc Pawel Moll <[email protected]>Cc Mark Rutland <[email protected]>Cc Stephen Warren <[email protected]>Cc Ian Campbell <[email protected]>Cc devicetree at vger.kernel.orgCc Sascha Hauer <[email protected]>Cc Shawn Guo <[email protected]>Cc linux-arm-kernel at lists.infradead.orgCc Lothar Wa?mann <[email protected]>Cc Jean-Christophe Plagniol-Villard <[email protected]>Cc Thierry Reding <[email protected]>Cc Eric B?nard <[email protected]>Signed-off-by Denis Carikli <[email protected]>---
ChangeLogv8->v9:
- Added Shawn Guo in the Cc list.
- The default-brightness-level is now a boolean default-on property, the gpio is only touched if the gpio-backlight driver instance probes.
- The code and documentation was updated accordingly.ChangeLog
v7->v8:
- The default-state was renamed to default-brightness-level.
- default-brightness-level is now mandatory, like for backlight-pwm, That way we avoid having to handle the case where it's not set, which means that we would need not to set the gpio, but still report a brightness value for sysfs, when not all gpio controllers are able to read the gpio value.
- switched the default-brightness-level to boolean values (0 or 1) instead of using strings ("on", "off", "keep").
- The documentation was updated accordingly.
- The example in the documentation now uses the dts gpio defines.
- The "backlight:gpio_backlight: Use a default state enum." patch was then dropped, becuase it is not necessary anymore.ChangeLog
v6->v7:
- removed a compilation warning with the removal of the useless ret declaration.ChangeLog
v5->v6:
- The default state handling was reworked:
- it's now called default-state, and looks like the gpio-leds default-state.
- it now has a "keep" option, like for the gpio-leds.
- that "keep" option is the default when the default-state property is not set.
- The documentation was updated accordingly.ChangeLog
v4->v5:
- The default-brightness property now defaults to 0 in the driver.
-def_valueint becomes a bool.
- The check for the gpio validity has been reworked.--- .../bindings/video/backlight/gpio-backlight.txt | 19 +++++++ drivers/video/backlight/gpio_backlight.c | 60 +++++++++++++++++--- 2 files changed, 72 insertions(+), 7 deletions(-) create mode 100644 Documentation/devicetree/bindings/video/backlight/gpio-backlight.txt
[...]
drivers/video/backlight/gpio_backlight.c static int gpio_backlight_probe(struct platform_device *pdev) · line 162
Quoted 11 lines
drivers/video/backlight/gpio_backlight.c +6
-0+static struct of_device_id gpio_backlight_of_match[] = { + { .compatible ="gpio-backlight" }, + {/* sentinel */ } +}; +static struct platform_driver gpio_backlight_driver = { .driver = { .name ="gpio-backlight" , .owner =THIS_MODULE , + .of_match_table =of_match_ptr (gpio_backlight_of_match),
useless use of of_match_ptr().
This would make sense, if the gpio_backlight_of_match struct was conditionally compiled in depending on CONFIG_OF. Since you unconditionally provide it you can use &gpio_backlight_of_match directly.
Lothar Wa?mann
Signature · 9 lines
___________________________________________________________ Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Gesch?ftsf?hrer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info at karo-electronics.de ___________________________________________________________