Skip to contentSkip to conversation

i915: send D1 opregion notification

PATCH Superseded Kristen Carlson Accardi 3 participants 5 messages Jan 13, 2014 – Jan 14, 2014

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i915: send D1 opregion notification

The opregion notification for runtime suspend should be D1, not D3. This is to maintain compatibility with firmware.

---
 drivers/gpu/drm/i915/i915_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_drv.c +1 -1
index 61fb9fc..a6c370a 100644
@@ -925,7 +925,7 @@ static int i915_runtime_suspend(struct device *device)
 
 	del_timer_sync(&dev_priv->gpu_error.hangcheck_timer);
 	dev_priv->pm.suspended = true;
-	intel_opregion_notify_adapter(dev, PCI_D3cold);
+	intel_opregion_notify_adapter(dev, PCI_D1);
 
 	return 0;
 }
Signature · 1 line
1.8.3.2
#1 lore raw
Quoted 13 lines · Kristen Carlson Accardi

The opregion notification for runtime suspend should be D1, not D3. This is to maintain compatibility with firmware.

---
 drivers/gpu/drm/i915/i915_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_drv.c +0 -0
index 61fb9fc..a6c370a 100644

drivers/gpu/drm/i915/i915_drv.c static int i915_runtime_suspend(struct device *device) · line 928

Quoted 5 lines
drivers/gpu/drm/i915/i915_drv.c +1 -1
@@ -925,7 +925,7 @@ static int i915_runtime_suspend(struct device *device)
 
 	del_timer_sync(&dev_priv->gpu_error.hangcheck_timer);
 	dev_priv->pm.suspended = true;
-	intel_opregion_notify_adapter(dev, PCI_D3cold);
+	intel_opregion_notify_adapter(dev, PCI_D1);

This needs a bigger comment and some mention on which platforms we exactly need this ... Or do the bios people plan to stick to this for bdw/vlv and all the further stuff?
-Daniel

Quoted 10 lines
drivers/gpu/drm/i915/i915_drv.c +0 -0
 	return 0;
 }
Signature · 6 lines
1.8.3.2

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
#2 lore raw
Quoted 15 lines · On Tue, 14 Jan 2014 10:26:02 +0100 Daniel Vetter <[email protected]> wrote:
Quoted 14 lines · Kristen Carlson Accardi

The opregion notification for runtime suspend should be D1, not D3. This is to maintain compatibility with firmware.

---
 drivers/gpu/drm/i915/i915_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_drv.c +0 -0
index 61fb9fc..a6c370a 100644
@@ -925,7 +925,7 @@ static int i915_runtime_suspend(struct device *device)
 
Quoted 8 lines

drivers/gpu/drm/i915/i915_drv.c static int i915_runtime_suspend(struct device *device) · line 928

Quoted 4 lines
drivers/gpu/drm/i915/i915_drv.c +1 -1
 	del_timer_sync(&dev_priv->gpu_error.hangcheck_timer);
 	dev_priv->pm.suspended = true;
-	intel_opregion_notify_adapter(dev, PCI_D3cold);
+	intel_opregion_notify_adapter(dev, PCI_D1);

This needs a bigger comment and some mention on which platforms we exactly need this ... Or do the bios people plan to stick to this for bdw/vlv and all the further stuff?

Doc # would help too, even if it's CDI or internal only... I don't know where to find this info, or if I did I've forgotten.

Thanks,

Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center
#3 lore raw
Quoted 27 lines · On Tue, 14 Jan 2014 11:19:44 -0800 Jesse Barnes <[email protected]>…
Quoted 15 lines · On Tue, 14 Jan 2014 10:26:02 +0100 Daniel Vetter <[email protected]> wrote:
Quoted 14 lines · Kristen Carlson Accardi

The opregion notification for runtime suspend should be D1, not D3. This is to maintain compatibility with firmware.

---
 drivers/gpu/drm/i915/i915_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_drv.c +0 -0
index 61fb9fc..a6c370a 100644
@@ -925,7 +925,7 @@ static int i915_runtime_suspend(struct device *device)
 
Quoted 8 lines

drivers/gpu/drm/i915/i915_drv.c static int i915_runtime_suspend(struct device *device) · line 928

Quoted 4 lines
drivers/gpu/drm/i915/i915_drv.c +1 -1
 	del_timer_sync(&dev_priv->gpu_error.hangcheck_timer);
 	dev_priv->pm.suspended = true;
-	intel_opregion_notify_adapter(dev, PCI_D3cold);
+	intel_opregion_notify_adapter(dev, PCI_D1);

This needs a bigger comment and some mention on which platforms we exactly need this ... Or do the bios people plan to stick to this for bdw/vlv and all the further stuff?

Quoted 4 lines

Doc # would help too, even if it's CDI or internal only... I don't know where to find this info, or if I did I've forgotten.

Thanks,

hahhah, you crack me up with all this "doc" stuff. There is no doc.

#4 lore raw
Quoted 30 lines · On Tue, 14 Jan 2014 15:06:46 -0800 Kristen Carlson Accardi…
Quoted 27 lines · On Tue, 14 Jan 2014 11:19:44 -0800 Jesse Barnes <[email protected]>…
Quoted 23 lines · On Tue, 14 Jan 2014 10:26:02 +0100 Daniel Vetter <[email protected]> wrote:
Quoted 13 lines · Kristen Carlson Accardi

The opregion notification for runtime suspend should be D1, not D3. This is to maintain compatibility with firmware.

---
 drivers/gpu/drm/i915/i915_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_drv.c +0 -0
index 61fb9fc..a6c370a 100644

drivers/gpu/drm/i915/i915_drv.c static int i915_runtime_suspend(struct device *device) · line 928

Quoted 5 lines
drivers/gpu/drm/i915/i915_drv.c +1 -1
@@ -925,7 +925,7 @@ static int i915_runtime_suspend(struct device *device)
 
 	del_timer_sync(&dev_priv->gpu_error.hangcheck_timer);
 	dev_priv->pm.suspended = true;
-	intel_opregion_notify_adapter(dev, PCI_D3cold);
+	intel_opregion_notify_adapter(dev, PCI_D1);

This needs a bigger comment and some mention on which platforms we exactly need this ... Or do the bios people plan to stick to this for bdw/vlv and all the further stuff?

Quoted 6 lines
Quoted 4 lines

Doc # would help too, even if it's CDI or internal only... I don't know where to find this info, or if I did I've forgotten.

Thanks,

hahhah, you crack me up with all this "doc" stuff. There is no doc.

Can you file an HSD or something on that internally? Seems like it should at least be part of the OpRegion spec or something...

Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center