Skip to contentSkip to conversation

Initial support for the silica pengwyn board

PATCH Superseded Lothar Felten 3 participants 7 messages Jan 29, 2014 Arm (32-bit)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v3 cover Initial support for the silica pengwyn board

This patch add support for the Silica Pengwyn board [1] The board is basen on a TI AM3354 CPU [2]
All jumpers removed it will boot from the SDcard, the console is on UART1 accessible via the FDTI -> USB. The on board NAND chip is supported and can act as boot medium, depending on jumper settings. USB Host, USB Device and Ethernet are also provided but untested.

[1]
http://www.silica.com/product/silica-pengwyn-board.html
[2]
http://www.ti.com/product/am3354

Lothar Felten (2):
initial support for pengwyn board
cosmetics: braces, comment and whitespace formatting

 arch/arm/include/asm/arch-am33xx/ddr_defs.h |   16 ++
 board/silica/pengwyn/Makefile               |   13 ++
 board/silica/pengwyn/board.c                |  216 +++++++++++++++++++++
 board/silica/pengwyn/board.h                |   15 ++
 board/silica/pengwyn/mux.c                  |  107 +++++++++++
 boards.cfg                                  |    1 +
 include/configs/pengwyn.h                   |  272 +++++++++++++++++++++++++++
 7 files changed, 640 insertions(+)
 create mode 100644 board/silica/pengwyn/Makefile
 create mode 100644 board/silica/pengwyn/board.c
 create mode 100644 board/silica/pengwyn/board.h
 create mode 100644 board/silica/pengwyn/mux.c
 create mode 100644 include/configs/pengwyn.h
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v3 1/2 initial support for pengwyn board

---
 arch/arm/include/asm/arch-am33xx/ddr_defs.h |   16 ++
 board/silica/pengwyn/Makefile               |   13 ++
 board/silica/pengwyn/board.c                |  216 +++++++++++++++++++++
 board/silica/pengwyn/board.h                |   15 ++
 board/silica/pengwyn/mux.c                  |  107 +++++++++++
 boards.cfg                                  |    1 +
 include/configs/pengwyn.h                   |  274 +++++++++++++++++++++++++++
 7 files changed, 642 insertions(+)
 create mode 100644 board/silica/pengwyn/Makefile
 create mode 100644 board/silica/pengwyn/board.c
 create mode 100644 board/silica/pengwyn/board.h
 create mode 100644 board/silica/pengwyn/mux.c
 create mode 100644 include/configs/pengwyn.h
arch/arm/include/asm/arch-am33xx/ddr_defs.h +16 -0
index c1777df..60cb098 100644
@@ -58,6 +58,22 @@
 #define MT41J128MJT125_PHY_FIFO_WE		0x100
 #define MT41J128MJT125_IOCTRL_VALUE		0x18B
 
+/* Micron MT41K128M16JT-187E */
+#define MT41K128MJT187E_EMIF_READ_LATENCY	0x06
+#define MT41K128MJT187E_EMIF_TIM1		0x0888B3DB
+#define MT41K128MJT187E_EMIF_TIM2		0x36337FDA
+#define MT41K128MJT187E_EMIF_TIM3		0x501F830F
+#define MT41K128MJT187E_EMIF_SDCFG		0x61C04AB2
+#define MT41K128MJT187E_EMIF_SDREF		0x0000093B
+#define MT41K128MJT187E_ZQ_CFG			0x50074BE4
+#define MT41K128MJT187E_RATIO			0x40
+#define MT41K128MJT187E_INVERT_CLKOUT		0x1
+#define MT41K128MJT187E_RD_DQS			0x3B
+#define MT41K128MJT187E_WR_DQS			0x85
+#define MT41K128MJT187E_PHY_WR_DATA		0xC1
+#define MT41K128MJT187E_PHY_FIFO_WE		0x100
+#define MT41K128MJT187E_IOCTRL_VALUE		0x18B
+
 /* Micron MT41J64M16JT-125 */
 #define MT41J64MJT125_EMIF_SDCFG		0x61C04A32
 
board/silica/pengwyn/Makefile new file +13 -0
new file mode 100644
index 0000000..c8b4f9a
@@ -0,0 +1,13 @@
+#
+# Makefile
+#
+# Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
+#
+# SPDX-License-Identifier:	GPL-2.0+
+#
+
+ifeq ($(CONFIG_SPL_BUILD)$(CONFIG_NOR_BOOT),y)
+obj-y	:= mux.o
+endif
+
+obj-y	+= board.o
board/silica/pengwyn/board.c new file +216 -0

216 lines not on this page · raw message

board/silica/pengwyn/board.h new file +15 -0
new file mode 100644
index 0000000..05addf6
@@ -0,0 +1,15 @@
+/*
+ * board.h
+ *
+ * Copyright (C) 2013 Lothar Felten <[email protected]>
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+
+#ifndef _BOARD_H_
+#define _BOARD_H_
+
+void enable_uart0_pin_mux(void);
+void enable_board_pin_mux(void);
+
+#endif
board/silica/pengwyn/mux.c new file +107 -0

107 lines not on this page · raw message

boards.cfg +1 -0
index 2dfd2b4..808bfa9 100644
@@ -255,6 +255,7 @@ Active  arm         armv7          am33xx      phytec          pcm051
 Active  arm         armv7          am33xx      siemens         dxr2                dxr2                                 -                                                                                                                                 Roger Meier <[email protected]>
 Active  arm         armv7          am33xx      siemens         pxm2                pxm2                                 -                                                                                                                                 Roger Meier <[email protected]>
 Active  arm         armv7          am33xx      siemens         rut                 rut                                  -                                                                                                                                 Roger Meier <[email protected]>
+Active  arm         armv7          am33xx      silica          pengwyn             pengwyn                              -                                                                                                                                 Lothar Felten <[email protected]>
 Active  arm         armv7          am33xx      ti              am335x              am335x_boneblack                     am335x_evm:SERIAL1,CONS_INDEX=1,EMMC_BOOT                                                                                         Tom Rini <[email protected]>
 Active  arm         armv7          am33xx      ti              am335x              am335x_evm                           am335x_evm:SERIAL1,CONS_INDEX=1,NAND                                                                                              Tom Rini <[email protected]>
 Active  arm         armv7          am33xx      ti              am335x              am335x_evm_nor                       am335x_evm:SERIAL1,CONS_INDEX=1,NAND,NOR                                                                                          Tom Rini <[email protected]>
include/configs/pengwyn.h new file +274 -0

274 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#2 lore raw

PATCH v3 1/2 initial support for pengwyn board

On Wed, Jan 29, 2014 at 04:39:02PM +0100, Lothar Felten wrote:

[snip]

board/silica/pengwyn/Makefile line 11

Quoted 3 lines
board/silica/pengwyn/Makefile new file +3 -0
+ifeq ($(CONFIG_SPL_BUILD)$(CONFIG_NOR_BOOT),y)
+obj-y	:= mux.o
+endif

Here and elsewhere, correct these tests as you don't support CONFIG_NOR_BOOT on this platform.

board/silica/pengwyn/board.c line 81

Quoted 2 lines
board/silica/pengwyn/board.c new file +2 -0
+	/* the pengwyn board uses the TPS650250 PMIC  without I2C */
+	/* interface and will output the following fixed voltages: */

/*
* Like this
* please.
*/

board/silica/pengwyn/board.c line 216

Quoted 6 lines
board/silica/pengwyn/board.c new file +6 -0
+#ifdef CONFIG_BOARD_LATE_INIT
+int board_late_init(void)
+{
+	return 0;
+}
+#endif

Please do a pre-patch that moves CONFIG_BOARD_LATE_INIT from <configs/ti_am335x_common.h> to the board ports, and then you can drop this hunk.

include/configs/pengwyn.h line 41

Quoted 5 lines
include/configs/pengwyn.h new file +5 -0
+	"nandsrcaddr=0x280000\0" \
+		"nandboot=echo Booting from nand ...; " \
+		"run nandargs; " \
+		"nand read ${loadaddr} ${nandsrcaddr} ${nandimgsize}; " \
+		"bootz ${loadaddr}\0" \

(a) indentation is wrong (and a copy/pasted problem) and (b) you don't handle the device tree here.

include/configs/pengwyn.h line 133

Quoted 5 lines
include/configs/pengwyn.h new file +5 -0
+	"spiboot=echo Booting from spi ...; " \
+		"run spiargs; " \
+		"sf probe ${spibusno}:0; " \
+		"sf read ${loadaddr} ${spisrcaddr} ${spiimgsize}; " \
+		"bootz ${loadaddr}\0" \

Same and unused?

include/configs/pengwyn.h line 154

Quoted 11 lines
include/configs/pengwyn.h new file +11 -0
+	"findfdt="\
+		"if test $board_name = A335BONE; then " \
+			"setenv fdtfile am335x-bone.dtb; fi; " \
+		"if test $board_name = A335BNLT; then " \
+			"setenv fdtfile am335x-boneblack.dtb; fi; " \
+		"if test $board_name = A33515BB; then " \
+			"setenv fdtfile am335x-evm.dtb; fi; " \
+		"if test $board_name = A335X_SK; then " \
+			"setenv fdtfile am335x-evmsk.dtb; fi; " \
+		"if test $fdtfile = undefined; then " \
+			"echo WARNING: no device tree found; fi; \0" \

Nonsense for this board.

Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140129/cd84ab7e/attachment.pgp>
#3 lore raw

PATCH v3 1/2 initial support for pengwyn board

In reply to Lothar Felten

Dear Lothar Felten,

Quoted 1 line · In message <[email protected]> you wrote:

You still fail to provide a comit message here.

The comments in the cover letter may be helpful, but they will not show up in the git log, i. e. they are lost. We need this information here.

Quoted 1 line

---

This is patch version 3, and even though I explicitly pointed you at the documentation, you fail to tell us here (below this little "---" line) what exactly has been changed since version 2. We don;t have time and resources to compare your patch versions ourself to fuind out which of the review commetns you might have addressed, or not.

Sorry, but my review stops here with a NAK (see the other message).

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Programmer's Lament: (Shakespeare, Macbeth, Act I, Scene vii)
        "That we but teach bloody instructions,
        which, being taught, return to plague the inventor..."
#4 lore raw

PATCH v3 2/2 cosmetics: braces, comment and whitespace formatting Signed-off-by: Lothar Felten <[email protected]>

In reply to Lothar Felten
---
 board/silica/pengwyn/board.c |   10 +++++-----
 include/configs/pengwyn.h    |    6 ++----
 2 files changed, 7 insertions(+), 9 deletions(-)
board/silica/pengwyn/board.c +5 -5
index d5dbd3b..97d7de4 100644
@@ -77,11 +77,11 @@ const struct dpll_params dpll_ddr_400 = {
 
 void am33xx_spl_board_init(void)
 {
-	/* the pengwyn board uses the TPS650250 PMIC  without I2C */
-	/* interface and will output the following fixed voltages: */
-	/* DCDC1=3V3 (IO) DCDC2=1V5 (DDR) DCDC3=1V26 (Vmpu) */
-	/* VLDO1=1V8 (IO) VLDO2=1V8(IO) */
-	/* Vcore=1V1 is fixed, generated by TPS62231 */
+	/* The pengwyn board uses the TPS650250 PMIC  without I2C
+	 * interface and will output the following fixed voltages:
+	 * DCDC1=3V3 (IO) DCDC2=1V5 (DDR) DCDC3=1V26 (Vmpu)
+	 * VLDO1=1V8 (IO) VLDO2=1V8(IO)
+	 * Vcore=1V1 is fixed, generated by TPS62231 */
 
 	/* Get the frequency */
 	dpll_mpu_opp100.m = am335x_get_efuse_mpu_max_freq(cdev);
include/configs/pengwyn.h +2 -4
index 7a41151..f35cee6 100644
@@ -19,10 +19,10 @@
 
 /* Clock Defines */
 #define V_OSCK				24000000
-#define V_SCLK				(V_OSCK)
+#define V_SCLK				V_OSCK
 
 /* set env size */
-#define CONFIG_ENV_SIZE			(0x4000)
+#define CONFIG_ENV_SIZE			0x4000
 
 #ifdef CONFIG_NAND
 #define NANDARGS \
@@ -179,8 +179,6 @@
 #define CONFIG_SPL_POWER_SUPPORT
 #define CONFIG_SPL_YMODEM_SUPPORT
 
-
-
 /* General network SPL, both CPSW and USB gadget RNDIS */
 #define CONFIG_SPL_NET_SUPPORT
 #define CONFIG_SPL_ENV_SUPPORT
Signature · 1 line
1.7.9.5
#5 lore raw

PATCH v3 2/2 cosmetics: braces, comment and whitespace formatting Signed-off-by: Lothar Felten <[email protected]>

Quoted 14 lines · Lothar Felten
---
 board/silica/pengwyn/board.c |   10 +++++-----
 include/configs/pengwyn.h    |    6 ++----
 2 files changed, 7 insertions(+), 9 deletions(-)
board/silica/pengwyn/board.c +0 -0
index d5dbd3b..97d7de4 100644
@@ -77,11 +77,11 @@ const struct dpll_params dpll_ddr_400 = {
 
 void am33xx_spl_board_init(void)
 {

board/silica/pengwyn/board.c const struct dpll_params dpll_ddr_400 = { · line 84

Quoted 10 lines
board/silica/pengwyn/board.c +5 -5
-	/* the pengwyn board uses the TPS650250 PMIC  without I2C */
-	/* interface and will output the following fixed voltages: */
-	/* DCDC1=3V3 (IO) DCDC2=1V5 (DDR) DCDC3=1V26 (Vmpu) */
-	/* VLDO1=1V8 (IO) VLDO2=1V8(IO) */
-	/* Vcore=1V1 is fixed, generated by TPS62231 */
+	/* The pengwyn board uses the TPS650250 PMIC  without I2C
+	 * interface and will output the following fixed voltages:
+	 * DCDC1=3V3 (IO) DCDC2=1V5 (DDR) DCDC3=1V26 (Vmpu)
+	 * VLDO1=1V8 (IO) VLDO2=1V8(IO)
+	 * Vcore=1V1 is fixed, generated by TPS62231 */

Not quite right, and please squash this patch into the first one, in the next posting. Thanks.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140129/bfccb8c0/attachment.pgp>
#6 lore raw

PATCH v3 2/2 cosmetics: braces, comment and whitespace formatting Signed-off-by: Lothar Felten <[email protected]>

In reply to Lothar Felten

Dear Lothar Felten,

Quoted 14 lines · In message <[email protected]> you wrote:
---
 board/silica/pengwyn/board.c |   10 +++++-----
 include/configs/pengwyn.h    |    6 ++----
 2 files changed, 7 insertions(+), 9 deletions(-)
board/silica/pengwyn/board.c +0 -0
index d5dbd3b..97d7de4 100644
@@ -77,11 +77,11 @@ const struct dpll_params dpll_ddr_400 = {
 
 void am33xx_spl_board_init(void)
 {

board/silica/pengwyn/board.c const struct dpll_params dpll_ddr_400 = { · line 84

Quoted 10 lines
board/silica/pengwyn/board.c +5 -5
-	/* the pengwyn board uses the TPS650250 PMIC  without I2C */
-	/* interface and will output the following fixed voltages: */
-	/* DCDC1=3V3 (IO) DCDC2=1V5 (DDR) DCDC3=1V26 (Vmpu) */
-	/* VLDO1=1V8 (IO) VLDO2=1V8(IO) */
-	/* Vcore=1V1 is fixed, generated by TPS62231 */
+	/* The pengwyn board uses the TPS650250 PMIC  without I2C
+	 * interface and will output the following fixed voltages:
+	 * DCDC1=3V3 (IO) DCDC2=1V5 (DDR) DCDC3=1V26 (Vmpu)
+	 * VLDO1=1V8 (IO) VLDO2=1V8(IO)
+	 * Vcore=1V1 is fixed, generated by TPS62231 */

This is still wrong. Please see the example I gave in my previous message, and/or read the Linux CodingStyle document.

Also, it does not make sense to first knowingly add bad code and then fix it in a later patch of the same seirs - please squash your patches.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You see things; and you say ``Why?'' But I dream  things  that  never
were; and I say ``Why not?''
       - George Bernard Shaw _Back to Methuselah_ (1921) pt. 1, act 1