Skip to contentSkip to conversation

hwmon: (pmbus/ltc2978) Add new chip ID for LTC2974

PATCH In review Guenter Roeck 2 participants 4 messages Mar 6, 2014 – Mar 7, 2014 Hardware monitoring

lore
Share & tools
lore

Guenter Roeck

author maintainer
#0 lore raw

PATCH v2 1/1 hwmon: (pmbus/ltc2978) Add new chip ID for LTC2974

LTC2974 datasheet revision C lists the chip ID for LTC2974 as 0x0213.

Signed-off-by Guenter Roeck <[email protected]>

---
v2: Mark old revision ID as _REV1.

 drivers/hwmon/pmbus/ltc2978.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/hwmon/pmbus/ltc2978.c +3 -2
index de3c152..629bfe0 100644
@@ -53,7 +53,8 @@ enum chips { ltc2974, ltc2977, ltc2978, ltc3880, ltc3883 };
 /* LTC3883 only */
 #define LTC3883_MFR_IIN_PEAK		0xe1
 
-#define LTC2974_ID			0x0212
+#define LTC2974_ID_REV1			0x0212
+#define LTC2974_ID_REV2			0x0213
 #define LTC2977_ID			0x0130
 #define LTC2978_ID_REV1			0x0121
 #define LTC2978_ID_REV2			0x0122

@@ -394,7 +395,7 @@ static int ltc2978_probe(struct i2c_client *client,
 	if (chip_id < 0)
 		return chip_id;
 
-	if (chip_id = LTC2974_ID) {
+	if (chip_id = LTC2974_ID_REV1 || chip_id = LTC2974_ID_REV2) {
 		data->id = ltc2974;
 	} else if (chip_id = LTC2977_ID) {
 		data->id = ltc2977;
Signature · 7 lines
1.7.9.7


_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Reviewed-by on v2 1/1
#1 lore raw

Thank you Guenter.

Reviewed-by Robert Coulson <[email protected]>
Quoted 37 lines · Guenter Roeck

LTC2974 datasheet revision C lists the chip ID for LTC2974 as 0x0213.

Signed-off-by Guenter Roeck <[email protected]>

---
v2: Mark old revision ID as _REV1.

 drivers/hwmon/pmbus/ltc2978.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/hwmon/pmbus/ltc2978.c +2 -1
index de3c152..629bfe0 100644
@@ -53,7 +53,8 @@ enum chips { ltc2974, ltc2977, ltc2978, ltc3880, ltc3883
 };
 /* LTC3883 only */
 #define LTC3883_MFR_IIN_PEAK           0xe1
 
-#define LTC2974_ID                     0x0212
+#define LTC2974_ID_REV1                        0x0212
+#define LTC2974_ID_REV2                        0x0213
 #define LTC2977_ID                     0x0130
 #define LTC2978_ID_REV1                        0x0121

#define LTC2978_ID_REV2 0x0122

drivers/hwmon/pmbus/ltc2978.c +1 -2
@@ -394,7 +395,7 @@ static int ltc2978_probe(struct i2c_client *client,
        if (chip_id < 0)
                return chip_id;
 
-       if (chip_id = LTC2974_ID) {
+       if (chip_id = LTC2974_ID_REV1 || chip_id = LTC2974_ID_REV2) {
                data->id = ltc2974;
        } else if (chip_id = LTC2977_ID) {
                data->id = ltc2977;
--

1.7.9.7

Quoted 5 lines

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

author maintainer
#2 lore raw
In reply to Guenter Roeck
Quoted 4 lines · Robert Coulson

Thank you Guenter.

Reviewed-by Robert Coulson <[email protected] <mailto:[email protected]>>

Thanks ... but don't top-post, please :-)

Guenter

Quoted 35 lines · On Wed, Mar 5, 2014 at 9:26 PM, Guenter Roeck <[email protected]…
    LTC2974 datasheet revision C lists the chip ID for LTC2974 as 0x0213.

    Signed-off-by: Guenter Roeck <[email protected] <mailto:[email protected]>>
    ---
    v2: Mark old revision ID as _REV1.

      drivers/hwmon/pmbus/ltc2978.c |    5 +++--
      1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/hwmon/pmbus/ltc2978.c b/drivers/hwmon/pmbus/ltc2978.c
    index de3c152..629bfe0 100644
    --- a/drivers/hwmon/pmbus/ltc2978.c
    +++ b/drivers/hwmon/pmbus/ltc2978.c
    @@ -53,7 +53,8 @@ enum chips { ltc2974, ltc2977, ltc2978, ltc3880, ltc3883 };
      /* LTC3883 only */
      #define LTC3883_MFR_IIN_PEAK           0xe1

    -#define LTC2974_ID                     0x0212
    +#define LTC2974_ID_REV1                        0x0212
    +#define LTC2974_ID_REV2                        0x0213
      #define LTC2977_ID                     0x0130
      #define LTC2978_ID_REV1                        0x0121
      #define LTC2978_ID_REV2                        0x0122
    @@ -394,7 +395,7 @@ static int ltc2978_probe(struct i2c_client *client,
             if (chip_id < 0)
                     return chip_id;

    -       if (chip_id = LTC2974_ID) {
    +       if (chip_id = LTC2974_ID_REV1 || chip_id = LTC2974_ID_REV2) {
                     data->id = ltc2974;
             } else if (chip_id = LTC2977_ID) {
                     data->id = ltc2977;
Quoted 10 lines
    --
    1.7.9.7


    _______________________________________________
    lm-sensors mailing list
    [email protected] <mailto:[email protected]>
    http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#3 lore raw
In reply to Guenter Roeck
Quoted 11 lines · Guenter Roeck
Quoted 6 lines · Robert Coulson

Thank you Guenter.

Reviewed-by Robert Coulson <[email protected] <mailto:

[email protected]>>

Thanks ... but don't top-post, please :-)

Guenter

Your welcome .. your right and I'll remember next time. (-:

*** Rob.

Quoted 47 lines
Quoted 47 lines

On Wed, Mar 5, 2014 at 9:26 PM, Guenter Roeck <[email protected]<mailto:
[email protected]>> wrote:

LTC2974 datasheet revision C lists the chip ID for LTC2974 as 0x0213.

Signed-off-by Guenter Roeck <[email protected] <mailto:

[email protected]>>

    ---
    v2: Mark old revision ID as _REV1.

      drivers/hwmon/pmbus/ltc2978.c |    5 +++--
      1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/hwmon/pmbus/ltc2978.c
b/drivers/hwmon/pmbus/ltc2978.c
    index de3c152..629bfe0 100644
    --- a/drivers/hwmon/pmbus/ltc2978.c
    +++ b/drivers/hwmon/pmbus/ltc2978.c
    @@ -53,7 +53,8 @@ enum chips { ltc2974, ltc2977, ltc2978, ltc3880,
ltc3883 };
      /* LTC3883 only */
      #define LTC3883_MFR_IIN_PEAK           0xe1

    -#define LTC2974_ID                     0x0212
    +#define LTC2974_ID_REV1                        0x0212
    +#define LTC2974_ID_REV2                        0x0213
      #define LTC2977_ID                     0x0130
      #define LTC2978_ID_REV1                        0x0121
      #define LTC2978_ID_REV2                        0x0122
    @@ -394,7 +395,7 @@ static int ltc2978_probe(struct i2c_client

*client,
if (chip_id < 0)
return chip_id;

- if (chip_id = LTC2974_ID) {
+ if (chip_id = LTC2974_ID_REV1 || chip_id = LTC2974_ID_REV2)

{
                     data->id = ltc2974;
             } else if (chip_id = LTC2977_ID) {
                     data->id = ltc2977;
    --
    1.7.9.7
Quoted 8 lines
Quoted 7 lines

_______________________________________________
lm-sensors mailing list
[email protected] <mailto:[email protected]>
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors