Skip to contentSkip to conversation

hwmon: (pmbus/ltc2978) Add new chip ID for LTC2974

PATCH Superseded Guenter Roeck 2 participants 2 messages Mar 5, 2014 – Mar 6, 2014 Hardware monitoring

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Guenter Roeck

author maintainer
#0 lore raw

PATCH 1/1 hwmon: (pmbus/ltc2978) Add new chip ID for LTC2974

LTC2974 datasheet revision C lists the chip ID for LTC2974 as 0x0213.

---
 drivers/hwmon/pmbus/ltc2978.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/hwmon/pmbus/ltc2978.c +2 -1
index de3c152..7647c11 100644
@@ -54,6 +54,7 @@ enum chips { ltc2974, ltc2977, ltc2978, ltc3880, ltc3883 };
 #define LTC3883_MFR_IIN_PEAK		0xe1
 
 #define LTC2974_ID			0x0212
+#define LTC2974_ID_REV2			0x0213
 #define LTC2977_ID			0x0130
 #define LTC2978_ID_REV1			0x0121
 #define LTC2978_ID_REV2			0x0122
@@ -394,7 +395,7 @@ static int ltc2978_probe(struct i2c_client *client,
 	if (chip_id < 0)
 		return chip_id;
 
-	if (chip_id = LTC2974_ID) {
+	if (chip_id = LTC2974_ID || chip_id = LTC2974_ID_REV2) {
 		data->id = ltc2974;
 	} else if (chip_id = LTC2977_ID) {
 		data->id = ltc2977;
Signature · 7 lines
1.7.9.7


_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#1 lore raw
Quoted 12 lines · Guenter Roeck

LTC2974 datasheet revision C lists the chip ID for LTC2974 as 0x0213.

---
 drivers/hwmon/pmbus/ltc2978.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/hwmon/pmbus/ltc2978.c +0 -0
index de3c152..7647c11 100644

drivers/hwmon/pmbus/ltc2978.c enum chips { ltc2974, ltc2977, ltc2978, ltc3880, ltc3883 · line 59

Quoted 6 lines
drivers/hwmon/pmbus/ltc2978.c +1 -0
@@ -54,6 +54,7 @@ enum chips { ltc2974, ltc2977, ltc2978, ltc3880, ltc3883
 };
 #define LTC3883_MFR_IIN_PEAK           0xe1
 
 #define LTC2974_ID                     0x0212
+#define LTC2974_ID_REV2                        0x0213
 

Hello Guenter,

only a nit-pik; since the other devices in this file have REVx appended, should this device too?

thanks,

*** Rob.

#define LTC2977_ID 0x0130

Quoted 15 lines
drivers/hwmon/pmbus/ltc2978.c +0 -0
 #define LTC2978_ID_REV1                        0x0121

#define LTC2978_ID_REV2 0x0122

drivers/hwmon/pmbus/ltc2978.c +1 -2
@@ -394,7 +395,7 @@ static int ltc2978_probe(struct i2c_client *client,
        if (chip_id < 0)
                return chip_id;
 
-       if (chip_id = LTC2974_ID) {
+       if (chip_id = LTC2974_ID || chip_id = LTC2974_ID_REV2) {
                data->id = ltc2974;
        } else if (chip_id = LTC2977_ID) {
                data->id = ltc2977;
--

1.7.9.7

Quoted 5 lines

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors