sparc32: fix sparse warnings in unaligned_32.c
PATCH 18/24 sparc32: fix sparse warnings in unaligned_32.c
Fix following warnings:
unaligned_32.c:146:15: warning: symbol 'safe_compute_effective_address' was not declared. Should it be static? unaligned_32.c:235:17: warning: symbol 'kernel_unaligned_trap' was not declared. Should it be static? unaligned_32.c:319:17: warning: symbol 'user_unaligned_trap' was not declared. Should it be static?
Add proper declarations in kernel.h + setup.h
Signed-off-by Sam Ravnborg <[email protected]>
--- arch/sparc/include/asm/setup.h | 4 ++++ arch/sparc/kernel/kernel.h | 6 ++++++ arch/sparc/kernel/unaligned_32.c | 4 ++++ arch/sparc/mm/fault_32.c | 4 +--- 4 files changed, 15 insertions(+), 3 deletions(-)
arch/sparc/include/asm/setup.h +4 -0
@@ -42,6 +42,10 @@ extern unsigned long cmdline_memory_size;/* devices.c */ void __init device_scan (void ); +/* unaligned_32.c */ +extern unsigned long safe_compute_effective_address (struct pt_regs *, +unsigned int ); +#endif extern void sun_do_break (void );
arch/sparc/kernel/kernel.h +6 -0
@@ -113,6 +113,12 @@ asmlinkage int do_sys_sigstack(struct sigstack __user *ssptr,/* ptrace_32.c */ extern asmlinkage int syscall_trace(struct pt_regs *regs, int syscall_exit_p); +/* unaligned_32.c */ +extern asmlinkage void kernel_unaligned_trap(struct pt_regs *regs, +unsigned int insn); +extern asmlinkage void user_unaligned_trap(struct pt_regs *regs, +unsigned int insn); +/* windows.c */ void try_to_clear_window_buffer (struct pt_regs *regs,int who);
arch/sparc/kernel/unaligned_32.c +4 -0
@@ -16,6 +16,10 @@#include <linux/smp.h> #include <linux/perf_event.h> +#include <asm/setup.h> + +#include "kernel.h" +enum direction { load,/* ld, ldd, ldh, ldsh */ store,/* st, std, sth, stsh */
arch/sparc/mm/fault_32.c +1 -3
@@ -26,6 +26,7 @@#include <asm/pgtable.h> #include <asm/openprom.h> #include <asm/oplib.h> +#include <asm/setup.h> #include <asm/smp.h> #include <asm/traps.h> #include <asm/uaccess.h>
@@ -140,9 +141,6 @@ static void __do_fault_siginfo(int code, int sig, struct pt_regs *regs,force_sig_info (sig, &info, current); } -extern unsigned long safe_compute_effective_address (struct pt_regs *, -unsigned int ); -static unsigned long compute_si_addr (struct pt_regs *regs,int text_fault) {unsigned int insn;
Signature · 1 line
1.8.3.1