Skip to content

sparc: sparse warning fixes for arch/sparc/kernel

Sam Ravnborg sparclinux 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest24 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/24sparc32: fix sparse warning in traps_32.carch/sparc/include/asm/bug.h arch/sparc/kernel/traps_32.c+2 -20 replies
2/24sparc32: fix sparse warnings in sun4m_irq.c and sun4d_irq.carch/sparc/include/asm/timer_32.h arch/sparc/kernel/irq.h arch/sparc/kernel/leon_kernel.c +1 more+7 -40 replies
3/24sparc32: fix sparse warnings in sun4d_irq.carch/sparc/include/asm/irq_32.h arch/sparc/kernel/irq.h arch/sparc/kernel/sun4d_irq.c+13 -80 replies
4/24sparc32: fix sparse warnings in irq_32.carch/sparc/include/asm/floppy_32.h arch/sparc/include/asm/setup.h arch/sparc/kernel/irq.h +1 more+21 -100 replies
5/24sparc32: fix sparse warnings in process_32.harch/sparc/kernel/kernel.h arch/sparc/kernel/process_32.c+10 -00 replies
6/24sparc32: fix sparse warnings in signal_32.carch/sparc/kernel/kernel.h arch/sparc/kernel/signal_32.c+14 -50 replies
7/24sparc32: fix sparse warnings in ioport.carch/sparc/include/asm/pgalloc_32.h arch/sparc/kernel/ioport.c+5 -30 replies
8/24sparc32: fix sparse warnings in setup_32.carch/sparc/include/asm/setup.h arch/sparc/kernel/setup_32.c arch/sparc/mm/init_32.c+6 -30 replies
9/24sparc32: fix sparse warnings in windows.carch/sparc/kernel/kernel.h arch/sparc/kernel/windows.c+7 -00 replies
10/24sparc: fix sparse warnings in cpu.carch/sparc/include/asm/cpudata.h arch/sparc/include/asm/cpudata_64.h arch/sparc/kernel/cpu.c+11 -50 replies
11/24sparc32: fix sparse warning in devices.carch/sparc/include/asm/setup.h arch/sparc/kernel/devices.c arch/sparc/mm/init_32.c+4 -20 replies
12/24sparc32: fix sparse warnings in tadpole.carch/sparc/kernel/devices.c arch/sparc/kernel/kernel.h arch/sparc/kernel/tadpole.c+9 -20 replies
13/24sparc32: fix sparse warnings in leon_pci_grpci1.carch/sparc/kernel/leon_pci_grpci1.c+6 -60 replies
14/24sparc32: fix sparse warnings in leon_pci_grpci2.carch/sparc/kernel/leon_pci_grpci2.c+9 -90 replies
15/24sparc32: fix sparse warnings in auxio_32.carch/sparc/include/asm/auxio.h arch/sparc/include/asm/auxio_64.h arch/sparc/kernel/auxio_32.c +2 more+16 -80 replies
16/24sparc32: fix sparse warnings in smp_32.carch/sparc/kernel/smp_32.c+3 -30 replies
17/24sparc32: fix sparse warning in ptrace_32.carch/sparc/kernel/kernel.h arch/sparc/kernel/ptrace_32.c+5 -00 replies
18/24sparc32: fix sparse warnings in unaligned_32.carch/sparc/include/asm/setup.h arch/sparc/kernel/kernel.h arch/sparc/kernel/unaligned_32.c +1 more+15 -30 replies
19/24sparc: fix sparse warnings in of_device_common.carch/sparc/kernel/of_device_common.c+3 -10 replies
20/24sparc32: fix sparse warnings in leon_kernel.carch/sparc/kernel/leon_kernel.c+3 -30 replies
21/24sparc32: fix sparse warnings in leon_pmc.carch/sparc/kernel/leon_pmc.c+4 -40 replies
22/24sparc32: fix sparse warnings in sun4m_smp.carch/sparc/kernel/kernel.h arch/sparc/kernel/smp_32.c+7 -50 replies
23/24sparc32: fix sparse warnings in sun4d_smp.carch/sparc/kernel/kernel.h arch/sparc/kernel/smp_32.c+7 -50 replies
24/24sparc32: fix sparse warnings in leon_smp.carch/sparc/kernel/kernel.h arch/sparc/kernel/leon_smp.c+5 -103 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/24] sparc: sparse warning fixes for arch/sparc/kernel

With the following patch-set most of the sparse warnings in arch/sparc/kernel/ have been addressed.

There are a few warnings left which are related to __iomem. And still several "Should it be static?" but for which I was not sure about the best fix.
Any hints are appreciated.

The files with warnings from arch/sparc/kernel are:

    sys_sparc_32.c
    time_32.c
    auxio_32.c

When looking at tadpole.c I was left with the impression that most of the code was actually not used - but for now I added a "TODO".

This patch-set is on top of the previous 5 patches sent yesterday.

Sam

Sam Ravnborg (24):
sparc32: fix sparse warning in traps_32.c
sparc32: fix sparse warnings in sun4m_irq.c and sun4d_irq.c
sparc32: fix sparse warnings in sun4d_irq.c
sparc32: fix sparse warnings in irq_32.c
sparc32: fix sparse warnings in process_32.h
sparc32: fix sparse warnings in signal_32.c
sparc32: fix sparse warnings in ioport.c
sparc32: fix sparse warnings in setup_32.c
sparc32: fix sparse warnings in windows.c
sparc: fix sparse warnings in cpu.c
sparc32: fix sparse warning in devices.c
sparc32: fix sparse warnings in tadpole.c
sparc32: fix sparse warnings in leon_pci_grpci1.c
sparc32: fix sparse warnings in leon_pci_grpci2.c
sparc32: fix sparse warnings in auxio_32.c
sparc32: fix sparse warnings in smp_32.c
sparc32: fix sparse warning in ptrace_32.c
sparc32: fix sparse warnings in unaligned_32.c
sparc: fix sparse warnings in of_device_common.c
sparc32: fix sparse warnings in leon_kernel.c
sparc32: fix sparse warnings in leon_pmc.c
sparc32: fix sparse warnings in sun4m_smp.c
sparc32: fix sparse warnings in sun4d_smp.c
sparc32: fix sparse warnings in leon_smp.c

 arch/sparc/include/asm/auxio.h       |  7 +++++
 arch/sparc/include/asm/auxio_64.h    |  2 --
 arch/sparc/include/asm/bug.h         |  2 +-
 arch/sparc/include/asm/cpudata.h     | 10 +++++++
 arch/sparc/include/asm/cpudata_64.h  |  5 ----
 arch/sparc/include/asm/floppy_32.h   | 11 ++-----
 arch/sparc/include/asm/irq_32.h      |  1 +
 arch/sparc/include/asm/pgalloc_32.h  |  2 ++
 arch/sparc/include/asm/setup.h       | 26 +++++++++++++++-
 arch/sparc/include/asm/timer_32.h    |  2 +-
 arch/sparc/kernel/auxio_32.c         |  3 ++
 arch/sparc/kernel/cpu.c              |  1 +
 arch/sparc/kernel/devices.c          | 11 +++----
 arch/sparc/kernel/ioport.c           |  6 ++--
 arch/sparc/kernel/irq.h              |  9 ++++++
 arch/sparc/kernel/irq_32.c           |  1 +
 arch/sparc/kernel/kernel.h           | 58 ++++++++++++++++++++++++++++++++----
 arch/sparc/kernel/leon_kernel.c      | 11 +++----
 arch/sparc/kernel/leon_pci_grpci1.c  | 12 ++++----
 arch/sparc/kernel/leon_pci_grpci2.c  | 18 +++++------
 arch/sparc/kernel/leon_pmc.c         |  8 ++---
 arch/sparc/kernel/leon_smp.c         | 13 +-------
 arch/sparc/kernel/of_device_common.c |  4 ++-
 arch/sparc/kernel/process_32.c       |  4 +++
 arch/sparc/kernel/ptrace_32.c        |  2 ++
 arch/sparc/kernel/setup_32.c         |  4 +--
 arch/sparc/kernel/signal_32.c        | 11 +++----
 arch/sparc/kernel/smp_32.c           | 12 ++------
 arch/sparc/kernel/sun4d_irq.c        | 17 ++++++-----
 arch/sparc/kernel/tadpole.c          |  6 +++-
 arch/sparc/kernel/time_32.c          |  2 +-
 arch/sparc/kernel/traps_32.c         |  2 +-
 arch/sparc/kernel/unaligned_32.c     |  4 +++
 arch/sparc/kernel/windows.c          |  3 ++
 arch/sparc/mm/fault_32.c             |  4 +--
 arch/sparc/mm/init_32.c              |  4 +--
 36 files changed, 193 insertions(+), 105 deletions(-)