sparc32: fix sparse warnings in sun4m_smp.c

PATCH In review Sam Ravnborg 1 participant 1 message Apr 21, 2014 SPARC + UltraSPARC (sparc/sparc64)

Share & tools

Sam Ravnborg

author

2014-04-21 17:12 UTC #0 lore raw

PATCH 22/24 sparc32: fix sparse warnings in sun4m_smp.c

Fix following warnings:
sun4m_smp.c:72:13: warning: symbol 'smp4m_boot_cpus' was not declared. Should it be static? sun4m_smp.c:78:5: warning: symbol 'smp4m_boot_one_cpu' was not declared. Should it be static? sun4m_smp.c:120:13: warning: symbol 'smp4m_smp_done' was not declared. Should it be static? sun4m_smp.c:230:6: warning: symbol 'smp4m_cross_call_irq' was not declared. Should it be static? sun4m_smp.c:240:6: warning: symbol 'smp4m_percpu_timer_interrupt' was not declared. Should it be static?

Add proper declarations.

Signed-off-by Sam Ravnborg <[email protected]>

---
 arch/sparc/kernel/kernel.h | 9 +++++++--
 arch/sparc/kernel/smp_32.c | 3 ---
 2 files changed, 7 insertions(+), 5 deletions(-)

arch/sparc/kernel/kernel.h +7 -2

index d074dfa..fd36dc1 100644
@@ -49,8 +49,13 @@ extern void sun4m_unmask_profile_irq(void);
 extern void sun4m_clear_profile_irq(int cpu);
 
 /* sun4m_smp.c */
-void sun4m_cpu_pre_starting(void *arg);
-void sun4m_cpu_pre_online(void *arg);
+extern void sun4m_cpu_pre_starting(void *arg);
+extern void sun4m_cpu_pre_online(void *arg);
+extern void __init smp4m_boot_cpus(void);
+extern int smp4m_boot_one_cpu(int i, struct task_struct *idle);
+extern void __init smp4m_smp_done(void);
+extern void smp4m_cross_call_irq(void);
+extern void smp4m_percpu_timer_interrupt(struct pt_regs *regs);
 
 /* sun4d_irq.c */
 extern spinlock_t sun4d_imsk_lock;

arch/sparc/kernel/smp_32.c +0 -3

index 632bf7c..ab86c5e 100644
@@ -75,7 +75,6 @@ void smp_store_cpu_info(int id)
 
 void __init smp_cpus_done(unsigned int max_cpus)
 {
-	extern void smp4m_smp_done(void);
 	extern void smp4d_smp_done(void);
 	unsigned long bogosum = 0;
 	int cpu, num = 0;

@@ -183,7 +182,6 @@ int setup_profiling_timer(unsigned int multiplier)
 
 void __init smp_prepare_cpus(unsigned int max_cpus)
 {
-	extern void __init smp4m_boot_cpus(void);
 	extern void __init smp4d_boot_cpus(void);
 	int i, cpuid, extra;

@@ -261,7 +259,6 @@ void __init smp_prepare_boot_cpu(void)
 
 int __cpu_up(unsigned int cpu, struct task_struct *tidle)
 {
-	extern int smp4m_boot_one_cpu(int, struct task_struct *);
 	extern int smp4d_boot_one_cpu(int, struct task_struct *);
 	int ret=0;

Signature · 1 line

1.8.3.1