staging:rtl8192e:check return value of dev_skb_alloc
PATCH v2 1/1 staging:rtl8192e:check return value of dev_skb_alloc
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +2 -1
@@ -62,12 +62,15 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address, skb =dev_alloc_skb (frag_length +4 ); +if (!skb) +return !rt_status;memcpy ((unsigned char *)(skb->cb), &dev,sizeof (dev)); tcb_desc = (struct cb_desc *)(skb->cb +MAX_DEV_ADDR_SIZE ); tcb_desc->queue_index =TXCMD_QUEUE ; tcb_desc->bCmdOrInit =DESC_PACKET_TYPE_INIT ; tcb_desc->bLastIniPkt = bLastIniPkt; - seg_ptr = skb->data;for (i =0 ; i < frag_length; i +=4 ) {
Signature · 1 line
1.9.1
Greg KH
maintainerQuoted 8 lines · Nicholas Krause
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +1
-0@@ -62,12 +62,15 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address, skb =dev_alloc_skb (frag_length +4 ); +if (!skb)
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address, · line 73
Quoted 10 lines
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +1
-1+return !rt_status;memcpy ((unsigned char *)(skb->cb), &dev,sizeof (dev)); tcb_desc = (struct cb_desc *)(skb->cb +MAX_DEV_ADDR_SIZE ); tcb_desc->queue_index =TXCMD_QUEUE ; tcb_desc->bCmdOrInit =DESC_PACKET_TYPE_INIT ; tcb_desc->bLastIniPkt = bLastIniPkt; - seg_ptr = skb->data;for (i =0 ; i < frag_length; i +=4 ) {
Again, always use checkpatch.pl before sending out patches...