Skip to contentSkip to conversation

staging:rtl8192e:check return value of dev_skb_alloc

PATCH Superseded Nicholas Krause 2 participants 2 messages Jun 18, 2014 Staging

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging:rtl8192e:check return value of dev_skb_alloc

drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +2 -1
index 11e915e..fde17ff 100644
@@ -62,12 +62,15 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
 
 		skb  = dev_alloc_skb(frag_length + 4);
+		if (!skb) 
+			return !rt_status;
 		memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev));
 		tcb_desc = (struct cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE);
 		tcb_desc->queue_index = TXCMD_QUEUE;
 		tcb_desc->bCmdOrInit = DESC_PACKET_TYPE_INIT;
 		tcb_desc->bLastIniPkt = bLastIniPkt;
-		
 
 		seg_ptr = skb->data;
 		for (i = 0; i < frag_length; i += 4) {
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 8 lines · Nicholas Krause
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +1 -0
index 11e915e..fde17ff 100644
@@ -62,12 +62,15 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
 
 		skb  = dev_alloc_skb(frag_length + 4);
+		if (!skb) 

drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address, · line 73

Quoted 10 lines
drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +1 -1
+			return !rt_status;
 		memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev));
 		tcb_desc = (struct cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE);
 		tcb_desc->queue_index = TXCMD_QUEUE;
 		tcb_desc->bCmdOrInit = DESC_PACKET_TYPE_INIT;
 		tcb_desc->bLastIniPkt = bLastIniPkt;
-		
 
 		seg_ptr = skb->data;
 		for (i = 0; i < frag_length; i += 4) {

Again, always use checkpatch.pl before sending out patches...