PM / OPP: ARCH_HAS_OPP
Subsystems (6)
Mark,
Your commit 78c5e0bb145d ("PM / OPP: Remove ARCH_HAS_OPP") landed in today's linux-next (ie, next-20140728). It removes the Kconfig symbol ARCH_HAS_OPP and ten select statements for that symbol.
After that commit there are still nine select statements for that symbol left in linux-next. (These select statements are now actually NOPs.) The peculiar thing is that these nine statements are all found in Kconfig files also touched by that commit.
Anyhow, are patches to remove these pointless select statements queued somewhere?
Paul Bolle
Quoted 6 lines · Paul Bolle
Mark,
Your commit
78c5e0bb145d("PM / OPP: RemoveARCH_HAS_OPP") landed in today's linux-next (ie, next-20140728). It removes theKconfigsymbolARCH_HAS_OPPand ten select statements for that symbol.
Quoted 7 lines
After that commit there are still nine select statements for that symbol left in linux-next. (These select statements are now actually NOPs.) The peculiar thing is that these nine statements are all found in
Kconfigfiles also touched by that commit.Anyhow, are patches to remove these pointless select statements queued somewhere?
There a couple of such select in imx Kconfig, and I will clean them up.
Shawn
PATCH 1/1 PM / OPP: Remove ARCH_HAS_OPP completely
In reply to Paul BolleThe Kconfig symbol ARCH_HAS_OPP became redundant in v3.16: commit 049d595a4db3 ("PM / OPP: Make OPP invisible to users in Kconfig") removed the only dependency that used it. Setting it had no effect anymore.
So commit 78c5e0bb145d ("PM / OPP: Remove ARCH_HAS_OPP") removed it. For some reason that commit did not remove all select statements for that symbol. These statements are useless. Remove them too.
---
Done on top of next-20140912. Tested with git grep only!
arch/arm/mach-omap2/Kconfig | 5 ----- arch/arm/mach-shmobile/Kconfig | 1 - drivers/devfreq/Kconfig | 1 - 3 files changed, 7 deletions(-)
arch/arm/mach-omap2/Kconfig +0 -5
@@ -22,7 +22,6 @@ config ARCH_OMAP4 bool "TI OMAP4" depends on ARCH_MULTI_V7 select ARCH_OMAP2PLUS - select ARCH_HAS_OPP select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP select ARM_CPU_SUSPEND if PM select ARM_ERRATA_720789
@@ -41,7 +40,6 @@ config SOC_OMAP5 bool "TI OMAP5" depends on ARCH_MULTI_V7 select ARCH_OMAP2PLUS - select ARCH_HAS_OPP select ARM_CPU_SUSPEND if PM select ARM_GIC select HAVE_ARM_SCU if SMP
@@ -53,14 +51,12 @@ config SOC_AM33XX bool "TI AM33XX" depends on ARCH_MULTI_V7 select ARCH_OMAP2PLUS - select ARCH_HAS_OPP select ARM_CPU_SUSPEND if PM config SOC_AM43XX bool "TI AM43x" depends on ARCH_MULTI_V7 select ARCH_OMAP2PLUS - select ARCH_HAS_OPP select ARM_GIC select MACH_OMAP_GENERIC select MIGHT_HAVE_CACHE_L2X0
@@ -69,7 +65,6 @@ config SOC_DRA7XX bool "TI DRA7XX" depends on ARCH_MULTI_V7 select ARCH_OMAP2PLUS - select ARCH_HAS_OPP select ARM_CPU_SUSPEND if PM select ARM_GIC select HAVE_ARM_ARCH_TIMER
arch/arm/mach-shmobile/Kconfig +0 -1
@@ -36,7 +36,6 @@ menuconfig ARCH_SHMOBILE_MULTI select NO_IOPORT_MAP select PINCTRL select ARCH_REQUIRE_GPIOLIB - select ARCH_HAS_OPP if ARCH_SHMOBILE_MULTI
drivers/devfreq/Kconfig +0 -1
@@ -80,7 +80,6 @@ config ARM_EXYNOS4_BUS_DEVFREQ config ARM_EXYNOS5_BUS_DEVFREQ bool "ARM Exynos5250 Bus DEVFREQ Driver" depends on SOC_EXYNOS5250 - select ARCH_HAS_OPP select DEVFREQ_GOV_SIMPLE_ONDEMAND select PM_OPP help
Signature · 1 line
1.9.3
Re: [PATCH] PM / OPP: Remove ARCH_HAS_OPP completely
Quoted 9 lines · Paul Bolle
The
KconfigsymbolARCH_HAS_OPPbecame redundant in v3.16: commit049d595a4db3("PM / OPP: Make OPP invisible to users inKconfig") removed the only dependency that used it. Setting it had no effect anymore.So commit
78c5e0bb145d("PM / OPP: RemoveARCH_HAS_OPP") removed it. For some reason that commit did not remove all select statements for that symbol. These statements are useless. Remove them too.
Quoted 5 lines
Signed-off-by Paul Bolle <[email protected]>---
Done on top of next-20140912. Tested with git grep only!arch/arm/mach-omap2/Kconfig | 5 -----
there can be conflict here:
https://patchwork.kernel.org/patch/4857231/
http://marc.info/?l=linux-omap&m=141047815520894&w=2
Quoted 79 lines
arch/arm/mach-shmobile/Kconfig | 1 - drivers/devfreq/Kconfig | 1 - 3 files changed, 7 deletions(-)arch/arm/mach-omap2/Kconfig +0
-5@@ -22,7 +22,6 @@ config ARCH_OMAP4 bool "TI OMAP4" depends on ARCH_MULTI_V7 select ARCH_OMAP2PLUS - select ARCH_HAS_OPP select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP select ARM_CPU_SUSPEND if PM select ARM_ERRATA_720789@@ -41,7 +40,6 @@ config SOC_OMAP5 bool "TI OMAP5" depends on ARCH_MULTI_V7 select ARCH_OMAP2PLUS - select ARCH_HAS_OPP select ARM_CPU_SUSPEND if PM select ARM_GIC select HAVE_ARM_SCU if SMP@@ -53,14 +51,12 @@ config SOC_AM33XX bool "TI AM33XX" depends on ARCH_MULTI_V7 select ARCH_OMAP2PLUS - select ARCH_HAS_OPP select ARM_CPU_SUSPEND if PM config SOC_AM43XX bool "TI AM43x" depends on ARCH_MULTI_V7 select ARCH_OMAP2PLUS - select ARCH_HAS_OPP select ARM_GIC select MACH_OMAP_GENERIC select MIGHT_HAVE_CACHE_L2X0@@ -69,7 +65,6 @@ config SOC_DRA7XX bool "TI DRA7XX" depends on ARCH_MULTI_V7 select ARCH_OMAP2PLUS - select ARCH_HAS_OPP select ARM_CPU_SUSPEND if PM select ARM_GIC select HAVE_ARM_ARCH_TIMERarch/arm/mach-shmobile/Kconfig +0
-1@@ -36,7 +36,6 @@ menuconfig ARCH_SHMOBILE_MULTI select NO_IOPORT_MAP select PINCTRL select ARCH_REQUIRE_GPIOLIB - select ARCH_HAS_OPP if ARCH_SHMOBILE_MULTIdrivers/devfreq/Kconfig +0
-2@@ -80,7 +80,6 @@ config ARM_EXYNOS4_BUS_DEVFREQ config ARM_EXYNOS5_BUS_DEVFREQ bool "ARM Exynos5250 Bus DEVFREQ Driver" depends on SOC_EXYNOS5250 - select ARCH_HAS_OPP select DEVFREQ_GOV_SIMPLE_ONDEMAND select PM_OPP help --1.9.3
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 3 lines
--- Regards, Nishanth Menon
Re: [PATCH] PM / OPP: Remove ARCH_HAS_OPP completely
Quoted 14 lines · Nishanth Menon
Quoted 13 lines · Paul Bolle
The
KconfigsymbolARCH_HAS_OPPbecame redundant in v3.16: commit049d595a4db3("PM / OPP: Make OPP invisible to users inKconfig") removed the only dependency that used it. Setting it had no effect anymore.So commit
78c5e0bb145d("PM / OPP: RemoveARCH_HAS_OPP") removed it. For some reason that commit did not remove all select statements for that symbol. These statements are useless. Remove them too.Signed-off-by Paul Bolle <[email protected]>---
Done on top of next-20140912. Tested with git grep only!
Quoted 6 lines
Quoted 1 line
arch/arm/mach-omap2/Kconfig | 5 -----there can be conflict here:
https://patchwork.kernel.org/patch/4857231/
Thanks.
Quoted 2 lines
Quoted 2 lines
arch/arm/mach-shmobile/Kconfig | 1 - drivers/devfreq/Kconfig | 1 -
Were patches submitted for these two files too? If so, we can probably just drop my patch.
Paul Bolle
Re: [PATCH] PM / OPP: Remove ARCH_HAS_OPP completely
Hi Paul, Rafael,
Quoted 5 lines · Paul Bolle
Quoted 2 lines
Quoted 2 lines
arch/arm/mach-shmobile/Kconfig | 1 - drivers/devfreq/Kconfig | 1 -Were patches submitted for these two files too? If so, we can probably just drop my patch.
Rafael said: "I've queued this up for 3.17, thanks!"
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-July/274681.html
But it's not in -next.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH] PM / OPP: Remove ARCH_HAS_OPP completely
Quoted 6 lines · Geert Uytterhoeven
Hi Paul, Rafael,
Quoted 3 lines · Paul Bolle
Quoted 2 lines
Quoted 2 lines
arch/arm/mach-shmobile/Kconfig | 1 - drivers/devfreq/Kconfig | 1 -
Quoted 8 lines
Quoted 2 lines
Were patches submitted for these two files too? If so, we can probably just drop my patch.
Rafael said: "I've queued this up for 3.17, thanks!"
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-July/274681.html
But it's not in -next.
I think that patch landed as commit 78c5e0bb145d. But for some unknown reason it didn't remove all selects statements for ARCH_HAS_OPP.
The odd thing here is that the last select statements I remove in this patch are all to be found in Kconfig files that actually were touched in that commit. Perhaps these select statements were merged back in during conflict resolution. I have no idea.
Paul Bolle
Re: [PATCH] PM / OPP: Remove ARCH_HAS_OPP completely
In reply to Paul BolleQuoted 5 lines · Paul Bolle
The
KconfigsymbolARCH_HAS_OPPbecame redundant in v3.16: commit049d595a4db3("PM / OPP: Make OPP invisible to users inKconfig") removed the only dependency that used it. Setting it had no effect anymore.
Quoted 7 lines
So commit
78c5e0bb145d("PM / OPP: RemoveARCH_HAS_OPP") removed it. For some reason that commit did not remove all select statements for that symbol. These statements are useless. Remove them too.Signed-off-by Paul Bolle <[email protected]>---
Done on top of next-20140912. Tested with git grep only!
Hi Paul,
could you break the shmobile portion out into a separate patch for me to take through my renesas tree?
I am concerned that taking those changes via a different route will result in conflicts as arch/arm/mach-shmobile/Kconfig is often updated.
Quoted 76 lines
arch/arm/mach-omap2/Kconfig | 5 ----- arch/arm/mach-shmobile/Kconfig | 1 - drivers/devfreq/Kconfig | 1 - 3 files changed, 7 deletions(-)arch/arm/mach-omap2/Kconfig +0
-5@@ -22,7 +22,6 @@ config ARCH_OMAP4 bool "TI OMAP4" depends on ARCH_MULTI_V7 select ARCH_OMAP2PLUS - select ARCH_HAS_OPP select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP select ARM_CPU_SUSPEND if PM select ARM_ERRATA_720789@@ -41,7 +40,6 @@ config SOC_OMAP5 bool "TI OMAP5" depends on ARCH_MULTI_V7 select ARCH_OMAP2PLUS - select ARCH_HAS_OPP select ARM_CPU_SUSPEND if PM select ARM_GIC select HAVE_ARM_SCU if SMP@@ -53,14 +51,12 @@ config SOC_AM33XX bool "TI AM33XX" depends on ARCH_MULTI_V7 select ARCH_OMAP2PLUS - select ARCH_HAS_OPP select ARM_CPU_SUSPEND if PM config SOC_AM43XX bool "TI AM43x" depends on ARCH_MULTI_V7 select ARCH_OMAP2PLUS - select ARCH_HAS_OPP select ARM_GIC select MACH_OMAP_GENERIC select MIGHT_HAVE_CACHE_L2X0@@ -69,7 +65,6 @@ config SOC_DRA7XX bool "TI DRA7XX" depends on ARCH_MULTI_V7 select ARCH_OMAP2PLUS - select ARCH_HAS_OPP select ARM_CPU_SUSPEND if PM select ARM_GIC select HAVE_ARM_ARCH_TIMERarch/arm/mach-shmobile/Kconfig +0
-1@@ -36,7 +36,6 @@ menuconfig ARCH_SHMOBILE_MULTI select NO_IOPORT_MAP select PINCTRL select ARCH_REQUIRE_GPIOLIB - select ARCH_HAS_OPP if ARCH_SHMOBILE_MULTIdrivers/devfreq/Kconfig +0
-1@@ -80,7 +80,6 @@ config ARM_EXYNOS4_BUS_DEVFREQ config ARM_EXYNOS5_BUS_DEVFREQ bool "ARM Exynos5250 Bus DEVFREQ Driver" depends on SOC_EXYNOS5250 - select ARCH_HAS_OPP select DEVFREQ_GOV_SIMPLE_ONDEMAND select PM_OPP helpSignature · 1 line
1.9.3
Re: [PATCH] PM / OPP: Remove ARCH_HAS_OPP completely
Quoted 14 lines · Simon Horman
Quoted 5 lines · Paul Bolle
The
KconfigsymbolARCH_HAS_OPPbecame redundant in v3.16: commit049d595a4db3("PM / OPP: Make OPP invisible to users inKconfig") removed the only dependency that used it. Setting it had no effect anymore.Quoted 7 lines
So commit
78c5e0bb145d("PM / OPP: RemoveARCH_HAS_OPP") removed it. For some reason that commit did not remove all select statements for that symbol. These statements are useless. Remove them too.Signed-off-by Paul Bolle <[email protected]>---
Done on top of next-20140912. Tested with git grep only!
Quoted 8 lines
Hi Paul,
could you break the shmobile portion out into a separate patch for me to take through my renesas tree?
I am concerned that taking those changes via a different route will result in conflicts as
arch/arm/mach-shmobile/Kconfigis often updated.
Of course the above comment is redundant if Rafael has already taken this patch.
Quoted 82 lines
Quoted 77 lines
arch/arm/mach-omap2/Kconfig | 5 ----- arch/arm/mach-shmobile/Kconfig | 1 - drivers/devfreq/Kconfig | 1 - 3 files changed, 7 deletions(-)arch/arm/mach-omap2/Kconfig +0
-5@@ -22,7 +22,6 @@ config ARCH_OMAP4 bool "TI OMAP4" depends on ARCH_MULTI_V7 select ARCH_OMAP2PLUS - select ARCH_HAS_OPP select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP select ARM_CPU_SUSPEND if PM select ARM_ERRATA_720789@@ -41,7 +40,6 @@ config SOC_OMAP5 bool "TI OMAP5" depends on ARCH_MULTI_V7 select ARCH_OMAP2PLUS - select ARCH_HAS_OPP select ARM_CPU_SUSPEND if PM select ARM_GIC select HAVE_ARM_SCU if SMP@@ -53,14 +51,12 @@ config SOC_AM33XX bool "TI AM33XX" depends on ARCH_MULTI_V7 select ARCH_OMAP2PLUS - select ARCH_HAS_OPP select ARM_CPU_SUSPEND if PM config SOC_AM43XX bool "TI AM43x" depends on ARCH_MULTI_V7 select ARCH_OMAP2PLUS - select ARCH_HAS_OPP select ARM_GIC select MACH_OMAP_GENERIC select MIGHT_HAVE_CACHE_L2X0@@ -69,7 +65,6 @@ config SOC_DRA7XX bool "TI DRA7XX" depends on ARCH_MULTI_V7 select ARCH_OMAP2PLUS - select ARCH_HAS_OPP select ARM_CPU_SUSPEND if PM select ARM_GIC select HAVE_ARM_ARCH_TIMERarch/arm/mach-shmobile/Kconfig +0
-1@@ -36,7 +36,6 @@ menuconfig ARCH_SHMOBILE_MULTI select NO_IOPORT_MAP select PINCTRL select ARCH_REQUIRE_GPIOLIB - select ARCH_HAS_OPP if ARCH_SHMOBILE_MULTIdrivers/devfreq/Kconfig +0
-1@@ -80,7 +80,6 @@ config ARM_EXYNOS4_BUS_DEVFREQ config ARM_EXYNOS5_BUS_DEVFREQ bool "ARM Exynos5250 Bus DEVFREQ Driver" depends on SOC_EXYNOS5250 - select ARCH_HAS_OPP select DEVFREQ_GOV_SIMPLE_ONDEMAND select PM_OPP helpSignature · 1 line
1.9.3--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 1/1 ARM: shmobile: Remove ARCH_HAS_OPP completely
The Kconfig symbol ARCH_HAS_OPP became redundant in v3.16: commit 049d595a4db3 ("PM / OPP: Make OPP invisible to users in Kconfig") removed the only dependency that used it. Setting it had no effect anymore.
So commit 78c5e0bb145d ("PM / OPP: Remove ARCH_HAS_OPP") removed it. For some reason that commit did not remove all select statements for that symbol. These statements are now useless. Remove one from shmobile too.
---
Sent previously as part of the treewide patch "PM / OPP: Remove ARCH_HAS_OPP completely". But it turns out the changes for omap2 are already queued in omap-for-v3.18/soc (but not in linux-next!). Besides, Simon Horman wanted the shmobile change split off.
Done on top of next-20140922. Tested by grepping the tree.
arch/arm/mach-shmobile/Kconfig | 1 - 1 file changed, 1 deletion(-)
arch/arm/mach-shmobile/Kconfig +0 -1
@@ -36,7 +36,6 @@ menuconfig ARCH_SHMOBILE_MULTI select NO_IOPORT_MAP select PINCTRL select ARCH_REQUIRE_GPIOLIB - select ARCH_HAS_OPP if ARCH_SHMOBILE_MULTI
Signature · 1 line
1.9.3
Re: [PATCH] ARM: shmobile: Remove ARCH_HAS_OPP completely
Quoted 8 lines · Paul Bolle
The
KconfigsymbolARCH_HAS_OPPbecame redundant in v3.16: commit049d595a4db3("PM / OPP: Make OPP invisible to users inKconfig") removed the only dependency that used it. Setting it had no effect anymore.So commit
78c5e0bb145d("PM / OPP: RemoveARCH_HAS_OPP") removed it. For some reason that commit did not remove all select statements for that symbol. These statements are now useless. Remove one from shmobile too.
The explanation for "some reason" is very simple: new selects were introduced in parallel with the removal of the existing ones.
Quoted 1 line
Signed-off-by Paul Bolle <[email protected]>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH] ARM: shmobile: Remove ARCH_HAS_OPP completely
Quoted 10 lines · Geert Uytterhoeven
Quoted 8 lines · Paul Bolle
The
KconfigsymbolARCH_HAS_OPPbecame redundant in v3.16: commit049d595a4db3("PM / OPP: Make OPP invisible to users inKconfig") removed the only dependency that used it. Setting it had no effect anymore.So commit
78c5e0bb145d("PM / OPP: RemoveARCH_HAS_OPP") removed it. For some reason that commit did not remove all select statements for that symbol. These statements are now useless. Remove one from shmobile too.
Quoted 6 lines
The explanation for "some reason" is very simple: new selects were introduced in parallel with the removal of the existing ones.
Quoted 1 line
Signed-off-by Paul Bolle <[email protected]>
Thanks, I have queued this up for v3.19.
I will push it to a branch that will be included in linux-next once v3.18-rc1 has been released.
PATCH 1/1 PM / devfreq: Remove ARCH_HAS_OPP completely
In reply to Simon HormanThe Kconfig symbol ARCH_HAS_OPP became redundant in v3.16: commit 049d595a4db3 ("PM / OPP: Make OPP invisible to users in Kconfig") removed the only dependency that used it. Setting it had no effect anymore.
So commit 78c5e0bb145d ("PM / OPP: Remove ARCH_HAS_OPP") removed it. For some reason that commit did not remove all select statements for that symbol. These statements are now useless. Remove one from devfreq too.
---
Sent previously as part of the treewide patch "PM / OPP: Remove ARCH_HAS_OPP completely". But it turns out the changes for omap2 are already queued in omap-for-v3.18/soc (but not in linux-next!). Besides, Simon Horman wanted the shmobile change split off. As a result this change needs to be sent separately.
Done on top of next-20140922. Tested by grepping the tree.
drivers/devfreq/Kconfig | 1 - 1 file changed, 1 deletion(-)
drivers/devfreq/Kconfig +0 -1
@@ -80,7 +80,6 @@ config ARM_EXYNOS4_BUS_DEVFREQ config ARM_EXYNOS5_BUS_DEVFREQ bool "ARM Exynos5250 Bus DEVFREQ Driver" depends on SOC_EXYNOS5250 - select ARCH_HAS_OPP select DEVFREQ_GOV_SIMPLE_ONDEMAND select PM_OPP help
Signature · 1 line
1.9.3